f6eeeac649
more UDP debugging
2018-10-04 21:08:15 -07:00
d4f3abf461
more descriptive UDP logging
2018-10-02 12:52:24 -07:00
2fec84461d
use of CMD_* instead of magic numbers
2018-10-02 12:52:24 -07:00
b97e37da98
de-duplicate address lists
2018-07-02 14:50:24 -07:00
beb977bd78
revise address list expansion
2018-07-02 14:39:36 -07:00
c5419f9487
revise discoverInterfaces()
...
change interface to distingush between bcast and point2point.
add netmask to truly distinguish unicast from bcast.
fix some minor (I think) errors in the bsd socks impl (use of clobbered buffer).
cleanup win32 impl. bcast and p2p handling.
2018-07-02 14:39:36 -07:00
4baa72c91d
avoid data race
...
destroy() sets _serverSocketChannel=INVALID_SOCKET under the lock.
Other changes are made before the worker thread starts.
2018-06-26 10:45:14 -07:00
4b3237a20d
BlockingUDPTransport::enqueueSendRequest cleanup?
...
oh my was this bad code! It isn't clear what
lock()/unlock() are guarding, but let them
continue as before, but don't swallow any exception,
or unlock twice.
2018-06-22 13:28:49 -07:00
d424202323
client: exception propagation from callbacks
...
Swallowing exceptions here hides some of our errors.
Particularly unrecoverable introspectionRegistry misses.
Instead, propagate up to Thread and close connection.
2018-06-22 13:28:49 -07:00
1670ff8f7c
SerializationHelper cleanup and add error checks
2018-06-22 13:28:49 -07:00
c8292caf91
remote: Request larger stack for workers
...
Overflows observed on RTEMS/ppc (mvme6100).
2018-06-04 10:08:01 -07:00
7a523dd948
drop unused NOMINMAX
2018-05-18 15:20:26 -07:00
ba41fa6d62
notes
2018-05-18 15:17:27 -07:00
bab32c332a
codec: notes on thread self dtor
2018-04-04 18:40:46 -07:00
54bb30fd86
reftrack BlockingUDPTransport
2018-04-04 18:31:12 -07:00
a8e26123c7
minor doc
2018-04-04 18:31:12 -07:00
7f5eb1de4d
BlockingClientTCPTransportCodec collapse closedNotifyClients() into internalClose()
2018-04-04 18:31:12 -07:00
0eabf10005
codec: drop unused _shutdownEvent
...
using epicsThread::exitWait() instead
2018-04-04 18:31:12 -07:00
83a941c070
channelSearchManager minor
2018-04-04 14:53:52 -07:00
f2164ddb5a
fix typedef in security.h
...
Can't refer to typedef in (private) remote.h
from (public) security.h
2018-04-04 10:12:44 -07:00
fe5780521b
Context::getSecurityPlugins() no return of non-const ref.
...
Return of map as non-const ref. allows callers to modify.
Probably unintended.
2018-04-04 09:09:43 -07:00
df14a19ae0
codec: eliminate internalPostClose()
...
no reason to distinguish before and after
send worker break is _requested_ (won't
actually be stopped).
2018-04-02 11:30:19 -07:00
434a43dfe1
codec: less force-ful shutdown
...
eliminate unused 'force' argument.
2018-04-02 10:46:57 -07:00
da85d39c0c
codec: const-ify socket
...
Avoid possible data race of changing _channel
before worker threads are joined.
Was just using this as a boolean flag for a method
which is already guarded in BlockingTCPTransportCodec::close()
from being called twice.
2018-04-02 10:41:30 -07:00
38965bb847
codec: collapse internalDestroy() into internalClose()
2018-04-02 10:24:35 -07:00
6c2d20353a
minor, avoid extra string copys
2018-03-28 13:59:33 -07:00
a6d86d2a3c
hide MockTransportSendControl
2018-03-28 13:49:21 -07:00
735dc22e2d
collapse SimpleChannelSearchManagerImpl into ChannelSearchManager
...
Virtual base with only one sub-class. So avoid some unnecessary
indirection.
2018-03-28 13:37:42 -07:00
1a100a0955
client fix init order leading to *NULL
...
Avoid a race between the main thread alloc of SimpleChannelSearchManagerImpl
the the UDP socket worker trying to use the same.
Split allocation and initialization of search manager
around socket creation and worker start.
Also in-line initializeUDPTransport() to only call site.
2018-03-28 13:21:46 -07:00
aec1c7c9d7
client search: cleanup context pointer handling
2018-03-28 11:25:54 -07:00
18758fa497
throw new doesn't work
...
javaism...
2018-02-13 18:07:58 -08:00
a266777d82
destroyAllChannels() swap out channels list
...
avoid possible modifications while iterating.
2018-02-13 17:58:56 -08:00
e8347f17b4
minor
2018-02-07 20:16:38 -08:00
24ffccf90d
better TransportRegistry::remove()
...
now with the same complexity as the original...
2018-02-06 18:20:33 -08:00
40868b7b8b
cleanup
2018-02-06 18:15:13 -08:00
c92045620a
oops
2018-02-06 16:54:54 -08:00
d41d15d59e
drop some dead code
2018-02-01 19:51:32 -08:00
606669c62b
less verbose error message when ::connect() fails
2018-02-01 19:51:15 -08:00
9b828852c0
Transport::getRemoteAddress() return reference
...
make it clear that result is always !NULL
2018-02-01 19:09:44 -08:00
58f996fd98
update transportRegistry
...
avoid leaks of SOCKET and leaving mutex locked
when exceptions are thrown.
2018-02-01 18:54:25 -08:00
5a86835a6f
add ref-counter for Transport ABC
2018-02-01 11:17:56 -08:00
3bb2f25bed
Merge remote-tracking branch 'origin/master'
...
* origin/master:
prevent CAChannel::disconnectChannel() from calling ca_clear_channel twice This was causing a crash when exiting
Revert "When caProvider is destroyed make sure all channels are cleared"
make changes suggested by andrew that remove warning messages
Clean up compiler warnings
fix issue #77
2018-01-31 11:51:57 -08:00
9daf7a0cad
remove unnecessary includes
2018-01-31 11:51:13 -08:00
fa46935d35
Clean up compiler warnings
2018-01-04 17:52:36 -06:00
903d117485
pvAccessLog() add EPICS_PRINTF_STYLE()
...
and fixup incorrect specifiers
2017-12-28 10:49:54 -06:00
c30d4347d0
notate BlockingUDPTransport w/ OVERRIDE FINAL
...
and de-virtualize methods never actual overridden
2017-12-19 11:38:26 -06:00
a10534d74d
eliminate Connector interface
...
no code generically creates UDP or TCP connections,
so this abstraction results only in unnecessary
virtual calls and casts.
2017-12-19 11:38:26 -06:00
0161799c93
must zero osiSockAddr prior to use!
...
RTEMS depends on this or eg. bind()
will fail because comparison with
list of interface addresses is done
with memcmp()!
2017-11-28 17:54:25 -06:00
ba3b777978
missed one
...
cf 2f0bb7d448
2017-11-16 11:18:13 -06:00
2f0bb7d448
"Not-a-first segmented message" is a critical error
...
Let's try to scare users into reporting it more promptly.
2017-11-15 19:38:26 -06:00
Michael Davidsaver