minor, avoid extra string copys

src/remote/channelSearchManager.cpp

@@ -258,7 +258,7 @@ bool ChannelSearchManager::generateSearchRequestMessage(SearchInstance::shared_p
         return false;
     */
 
-    const std::string name = channel->getSearchInstanceName();
+    const std::string& name(channel->getSearchInstanceName());
     // not nice...
     const int addedPayloadSize = sizeof(int32)/sizeof(int8) + (1 + sizeof(int32)/sizeof(int8) + name.length());
     if(((int)requestMessage->getRemaining()) < addedPayloadSize)

src/remote/pv/channelSearchManager.h

@@ -32,11 +32,11 @@ public:
     /**
      * Destructor
      */
-    virtual ~SearchInstance() {};
+    virtual ~SearchInstance() {}
 
     virtual pvAccessID getSearchInstanceID() = 0;
 
-    virtual std::string getSearchInstanceName() = 0;
+    virtual const std::string& getSearchInstanceName() = 0;
 
     virtual int32_t& getUserValue() = 0;
 

src/remoteClient/clientContextImpl.cpp

@@ -3355,7 +3355,7 @@ public:
             return m_channelID;
         }
 
-        virtual string getSearchInstanceName() OVERRIDE FINAL {
+        virtual const string& getSearchInstanceName() OVERRIDE FINAL {
             return m_name;
         }