epics/epics-base
0
0 Fork 0
Code Issues Pull Requests Projects Wiki Activity

epicsRingBytes: fix reversed operands in ResetHighWaterMark

Browse Source 
The used-bytes count is nextPut - nextGet everywhere else in this file
(epicsRingBytesPut, epicsRingBytesUsedBytes), but
epicsRingBytesResetHighWaterMark computed nextGet - nextPut.  For a ring
holding u bytes it therefore stored size-u; since Put only raises the
mark, the high-water mark stayed permanently inflated and wrong.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jacqueline GarrahanandClaude Opus 4.8 authored and Dirk Zimoch committed 2026-10-14 11:24:59 +02:00
1 parent 547be3c935
commit a5eddfcd63
1 file changed
+1 -1
Download Patch File Download Diff File Expand all files Collapse all files
modules/libcom/src/ring/epicsRingBytes.c
+1 -1
View File
@@ -244,7 +244,7 @@ LIBCOM_API void epicsStdCall epicsRingBytesResetHighWaterMark(epicsRingBytesId i
ringPvt *pring = (ringPvt *)id;
int used;
if (pring->lock) epicsSpinLock(pring->lock);
used = pring->nextGet - pring->nextPut;
used = pring->nextPut - pring->nextGet;
if (used < 0) used += pring->size;
pring->highWaterMark = used;
if (pring->lock) epicsSpinUnlock(pring->lock);