merge fix

slsDetectorServers/slsDetectorServer/src/slsDetectorServer_funcs.c

@@ -1503,7 +1503,7 @@ int set_module(int file_des) {
     ret = OK;
     memset(mess, 0, sizeof(mess));
 
-#if !(defined(MYTHEN3D) && defined(EIGERD))
+#if !(defined(MYTHEN3D) || defined(EIGERD))
     functionNotImplemented();
 #else
 

slsDetectorSoftware/src/DetectorImpl.cpp

@@ -75,8 +75,8 @@ void DetectorImpl::freeSharedMemory(int detectorIndex, int detPos) {
 
 void DetectorImpl::freeSharedMemory() {
     zmqSocket.clear();
-    for (auto &d : modules) {
-        d->freeSharedMemory();
+    for (auto &module : modules) {
+        module->freeSharedMemory();
     }
     modules.clear();
 
@@ -92,9 +92,10 @@ std::string DetectorImpl::getUserDetails() {
 
     std::ostringstream sstream;
     sstream << "\nHostname: ";
-    for (auto &d : modules) {
-        sstream << (d->isFixedPatternSharedMemoryCompatible() ? d->getHostname()
-                                                              : "Unknown")
+    for (auto &module : modules) {
+        sstream << (module->isFixedPatternSharedMemoryCompatible()
+                        ? module->getHostname()
+                        : "Unknown")
                 << "+";
     }
     sstream << "\nType: ";
@@ -104,9 +105,9 @@ std::string DetectorImpl::getUserDetails() {
     }
     // get type from module shm
     else {
-        for (auto &d : modules) {
-            sstream << (d->isFixedPatternSharedMemoryCompatible()
-                            ? ToString(d->getDetectorType())
+        for (auto &module : modules) {
+            sstream << (module->isFixedPatternSharedMemoryCompatible()
+                            ? ToString(module->getDetectorType())
                             : "Unknown")
                     << "+";
         }
@@ -255,8 +256,8 @@ void DetectorImpl::addModule(const std::string &hostname) {
     }
 
     if (host != "localhost") {
-        for (auto &d : modules) {
-            if (d->getHostname() == host) {
+        for (auto &module : modules) {
+            if (module->getHostname() == host) {
                 LOG(logWARNING)
                     << "Module " << host << "already part of the Detector!"
                     << std::endl
@@ -331,8 +332,8 @@ void DetectorImpl::updateDetectorSize() {
                   << "\n\tNumber of Channels in Y direction:"
                   << shm()->numberOfChannels.y;
 
-    for (auto &d : modules) {
-        d->updateNumberOfModule(shm()->numberOfModule);
+    for (auto &module : modules) {
+        module->updateNumberOfModule(shm()->numberOfModule);
     }
 }
 

slsDetectorSoftware/tests/test-Module.cpp

@@ -29,7 +29,7 @@ TEST_CASE("Is shm fixed pattern shm compatible") {
     REQUIRE(m.isFixedPatternSharedMemoryCompatible() == true);
 
     // Set shm version to 0
-    sls::SharedMemory<sls::sharedSlsDetector> shm(0, 0);
+    sls::SharedMemory<sls::sharedModule> shm(0, 0);
     REQUIRE(shm.IsExisting() == true);
     shm.OpenSharedMemory();
     shm()->shmversion = 0;

slsSupportLib/include/sls/versionAPI.h

@@ -3,11 +3,11 @@
 #define APILIB 0x210831
 #define APIRECEIVER 0x210831
 #define APIGUI 0x210819
-
-#define APIEIGER 0x210916
-#define APICTB 0x210916
-#define APIGOTTHARD 0x210916
-#define APIGOTTHARD2 0x210916
-#define APIMYTHEN3 0x210916
+#define APICTB 0x210917
+#define APIGOTTHARD 0x210917
+#define APIGOTTHARD2 0x210917
+#define APIMYTHEN3 0x210917
 #define APIMOENCH 0x210916
+#define APIEIGER 0x210917
+
 #define APIJUNGFRAU 0x210917