ctb: vchip doesnt validate with vlimit anymore (#1404)
Build on RHEL9 / build (push) Successful in 4m9s
Build on RHEL8 / build (push) Successful in 5m5s
Run Simulator Tests on local RHEL9 / build (push) Successful in 14m41s
Build on local RHEL9 / build (push) Successful in 1m25s
Run Simulator Tests on local RHEL8 / build (push) Successful in 17m2s
Build on local RHEL8 / build (push) Successful in 3m34s

This commit is contained in:
2026-02-26 14:22:46 +01:00
committed by GitHub
parent 6a9eac17c8
commit a1c5bf971f
3 changed files with 8 additions and 6 deletions
@@ -1450,12 +1450,6 @@ int validateVchip(int val, char *mess) {
LOG(logERROR, (mess));
return FAIL;
}
if (vLimit > 0 && val > vLimit) {
sprintf(mess, "Invalid vchip value %d mV. Exceeds vLimit %d mV\n", val,
vLimit);
LOG(logERROR, (mess));
return FAIL;
}
return OK;
}
@@ -1108,6 +1108,14 @@ TEST_CASE("v_abcd", "[.detectorintegration]") {
caller.call(cmds[i], {}, -1, GET, oss2);
REQUIRE(oss2.str() == cmds[i] + " 1200\n");
}
{
auto vlimit = det.getDAC(defs::V_LIMIT)[0];
det.setDAC(defs::V_LIMIT, 1500, true, {0});
REQUIRE_NOTHROW(caller.call(cmds[i], {"1200"}, -1, PUT));
if (vlimit < 0)
vlimit = 0;
det.setDAC(defs::V_LIMIT, vlimit, true, {0});
}
for (int imod = 0; imod != det.size(); ++imod) {
if (det_type == defs::XILINX_CHIPTESTBOARD &&
prev_val[imod] == -100) {