Gac x05la 20250527 t131936 #31
Merged
wakonig_k
merged 3 commits from 2025-06-16 17:01:30 +02:00
gac-x05la_20250527T131936 into main
No Reviewers
Labels
Clear labels
issue::not confirmed
issue::not reproducible
issue::reproducible
priority::critical
priority::needed
priority::nice to have
scope::backend
scope::frontend
stage::in development
stage::on hold
stage::pre_release
stage::ready for review
stage::selected for development
stage::weekly backlog
type::bug
type::discussion
type::doc
type::feature
type::improvement
type::test
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Used if an issue has not yet been confirmed by a developer
Used if an issue is not reproducible
Used if a developer was able to reproduce the issue
Should be done as soon as possible
An important update to the code base
Not really needed but a good improvement
An issue regarding the backend services
An issue regarding the user-facing services
This issue is currently being worked on
Something is blocking the development
For issues that have been merged into a pre-release branch and are waiting for their release.
For issues that have been resolved and are ready for review
This issue has been selected for development but has not been scheduled yet
This issue has been selected for development for the next development cycle
It's a bug!
A discussion is wanted/needed
Improvements to the documentation
A new feature
Neither a feature nor a bug but an improvement to the code base
Missing tests or improvements to the test suite
Something is not working
This issue or pull request already exists
New feature
Need some help
Something is wrong
More information is needed
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
acerbo_a (acerbo_a)
appel_c (appel_c)
bec-gitea
bonnin_a (bonnin_a)
celcer_t (celcer_t)
debenjak_l (debenjak_l)
divall_e (divall_e)
haghta_s (haghta_s)
lombosi_c (lombosi_c)
lovric_g (lovric_g)
marone (marone)
perl_d (perl_d)
schlepuetz_c (schlepuetz_c)
stampanoni (stampanoni)
usov_i (usov_i)
wakonig_k (wakonig_k)
wang_x1 (wang_x1)
wyzula_j (wyzula_j)
zamofing_t (zamofing_t)
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: bec/tomcat_bec#31
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
assigned to @wakonig_k
Note, this does a .set(...).wait() on all passed signals..
this is pretty neat!
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
Maybe call this GigaFrostROISignalWithValidator
Is 'step' deprecated?
Maybe add typehints to make possible acquisition modes obvious
typehints please
I checked below, these are values that should be set on the Signals during on_connected. In principle, we did something similar before. For instance we did this for the DDG by passing the signals name value pair through the deviceConfig. The device_server will then automatically set the signals once the device is connected. In addition, we could define default values within on_connected in case signals are not passed!
see comment for init
file_components should already provide you with the full filepath, properly configured user input, but only missing the device suffix.
In theory, the fullpath should simply be
should we get rid of burst_at_each_point? This parameter is from us, not quite sure why you would delete it here otherwise!
why unstage? If this is simply to make sure that the camera is properly configured, maybe check a status and instead call
stopif needed, then wait for the status to be ready?Is the camera ready to take data once this method resolves?
Can we be certain that the camera is ready for communication again after this call. In stage there is a sleep(.5) after the unstage() call
This will block indefinitely, given that we handle theses statuses in back ontop, I would not wait for this here but return the status. The file_event message can then be attached as a callback, i.e.
If
on_unstageis just callingstop_camera(), I would switch these two. Soon_unstage()callson_stop()as you will keep thedevice.staged/unstagedflags based on what we call -> stop vs unstage...!I was going through the std_daq_client relatively quickly as it was a bit more difficult to judge what happens without knowing the interface. The Preview looks nice. as I said, please tread most comments rather as question or suggestions. Looks good from my point of view
yes, but the backend doesn't accept the full path, it wants it in pieces :D
added 1 commit
Compare with previous version
probably fine in this case though
changed this line in version 6 of the diff
changed this line in version 6 of the diff
changed this line in version 6 of the diff
changed this line in version 6 of the diff
changed this line in version 6 of the diff
changed this line in version 6 of the diff
changed this line in version 6 of the diff
changed this line in version 6 of the diff
added 1 commit
Compare with previous version
done
done
handled differently but I resolve this thread as we anyway discussed it offline
yes but as discussed offline, I changed it to a status return
done
I don't see it used anywhere. I will remove it for now but it is easy to add back
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
Well, the validator signal works for any type of validation. The validation functions are defined outside of the class.
I think it could be useful for more beamlines, so maybe it is even worth putting it in ophyd_devices
added 1 commit
Compare with previous version
done
done
added 3 commits
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 2 commits
Compare with previous version
added 5 commits
Compare with previous version
added 1 commit
Compare with previous version
added 2 commits
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 5 commits
Compare with previous version
added 1 commit
Compare with previous version
added 2 commits
Compare with previous version
resolved all threads
added 4 commits
96ca9c32- 1 commit from branchmainbbb61d71- chore: add tomcat as default sessionc82e7c3d- Added config fileae85d179- refactor: std daq integrationCompare with previous version
marked this merge request as ready