bec/tomcat_bec
0
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Gac x05la 20250527 t131936 #31

Merged
wakonig_k merged 3 commits from gac-x05la_20250527T131936 into main 2025-06-16 17:01:30 +02:00
Conversation 66 Commits 3 Files Changed 28 +3654 -2877
wakonig_k commented 2025-05-28 14:20:51 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
No description provided.
wakonig_k commented 2025-05-28 14:20:51 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

assigned to @wakonig_k

assigned to @wakonig_k
appel_c commented 2025-05-28 14:49:05 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Note, this does a .set(...).wait() on all passed signals..

Note, this does a .set(...).wait() on all passed signals..
appel_c commented 2025-05-28 14:52:26 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

this is pretty neat!

this is pretty neat!
wakonig_k commented 2025-05-28 15:28:07 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 9cb8de01 - chore: cleanup of repo

Compare with previous version

added 1 commit <ul><li>9cb8de01 - chore: cleanup of repo</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45633&start_sha=b9185af99d24cd4d5f538e2c30315859a20d09f5)
wakonig_k commented 2025-05-28 15:32:12 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 039833a4 - chore: re-enable tests

Compare with previous version

added 1 commit <ul><li>039833a4 - chore: re-enable tests</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45635&start_sha=9cb8de012aa89ed522e6862b63bba46760041db5)
wakonig_k commented 2025-05-28 15:36:08 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 9b7c0632 - chore: disabled pcocam for now

Compare with previous version

added 1 commit <ul><li>9b7c0632 - chore: disabled pcocam for now</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45637&start_sha=039833a428685a671485dda218db9c31e98b6e80)
appel_c commented 2025-05-28 15:36:40 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Maybe call this GigaFrostROISignalWithValidator

Maybe call this GigaFrostROISignalWithValidator
appel_c commented 2025-05-28 15:36:40 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Is 'step' deprecated?

Is 'step' deprecated?
appel_c commented 2025-05-28 15:36:40 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Maybe add typehints to make possible acquisition modes obvious

Maybe add typehints to make possible acquisition modes obvious
appel_c commented 2025-05-28 15:36:41 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

typehints please

typehints please
appel_c commented 2025-05-28 15:36:41 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

I checked below, these are values that should be set on the Signals during on_connected. In principle, we did something similar before. For instance we did this for the DDG by passing the signals name value pair through the deviceConfig. The device_server will then automatically set the signals once the device is connected. In addition, we could define default values within on_connected in case signals are not passed!

I checked below, these are values that should be set on the Signals during on_connected. In principle, we did something similar before. For instance we did this for the DDG by passing the signals name value pair through the deviceConfig. The device_server will then automatically set the signals once the device is connected. In addition, we could define default values within on_connected in case signals are not passed!
appel_c commented 2025-05-28 15:36:41 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

see comment for init

see comment for __init__
appel_c commented 2025-05-28 15:36:41 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

file_components should already provide you with the full filepath, properly configured user input, but only missing the device suffix.
In theory, the fullpath should simply be

filepath = f"{scan_msg.info["file_components"][0]}_gigafrost{scan_msg.info["file_components"][1]}"
file_components should already provide you with the full filepath, properly configured user input, but only missing the device suffix. In theory, the fullpath should simply be ```python filepath = f"{scan_msg.info["file_components"][0]}_gigafrost{scan_msg.info["file_components"][1]}" ```
appel_c commented 2025-05-28 15:36:41 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

should we get rid of burst_at_each_point? This parameter is from us, not quite sure why you would delete it here otherwise!

should we get rid of burst_at_each_point? This parameter is from us, not quite sure why you would delete it here otherwise!
appel_c commented 2025-05-28 15:36:41 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

why unstage? If this is simply to make sure that the camera is properly configured, maybe check a status and instead call stop if needed, then wait for the status to be ready?

why unstage? If this is simply to make sure that the camera is properly configured, maybe check a status and instead call `stop` if needed, then wait for the status to be ready?
appel_c commented 2025-05-28 15:36:41 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Is the camera ready to take data once this method resolves?

Is the camera ready to take data once this method resolves?
appel_c commented 2025-05-28 15:36:41 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Can we be certain that the camera is ready for communication again after this call. In stage there is a sleep(.5) after the unstage() call

Can we be certain that the camera is ready for communication again after this call. In stage there is a sleep(.5) after the unstage() call
appel_c commented 2025-05-28 15:36:41 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

This will block indefinitely, given that we handle theses statuses in back ontop, I would not wait for this here but return the status. The file_event message can then be attached as a callback, i.e.

status = self.acq_done()
def _file_event_cb(status):
  dev = status.device
  dev.backend.create_virtual_datasets(dev.file_path.get(), file_prefix=dev.file_prefix.get())
        target_file = os.path.join(dev.file_path.get(), f"{dev.file_prefix.get().removesuffix('_')}.h5")
        dev._run_subs(
            sub_type=dev.SUB_FILE_EVENT,
            file_path=target_file,
            done=True,
            successful=status.success,
            hinted_location={"data": "data"},
        )
status.add_callback(_file_event_cb)
return status
This will block indefinitely, given that we handle theses statuses in back ontop, I would not wait for this here but return the status. The file_event message can then be attached as a callback, i.e. ```python status = self.acq_done() def _file_event_cb(status): dev = status.device dev.backend.create_virtual_datasets(dev.file_path.get(), file_prefix=dev.file_prefix.get()) target_file = os.path.join(dev.file_path.get(), f"{dev.file_prefix.get().removesuffix('_')}.h5") dev._run_subs( sub_type=dev.SUB_FILE_EVENT, file_path=target_file, done=True, successful=status.success, hinted_location={"data": "data"}, ) status.add_callback(_file_event_cb) return status ```
appel_c commented 2025-05-28 15:36:41 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

If on_unstage is just calling stop_camera(), I would switch these two. So on_unstage() calls on_stop() as you will keep the device.staged/unstaged flags based on what we call -> stop vs unstage...!

If `on_unstage` is just calling `stop_camera()`, I would switch these two. So `on_unstage()` calls `on_stop()` as you will keep the `device.staged/unstaged` flags based on what we call -> stop vs unstage...!
appel_c commented 2025-05-28 15:36:42 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

I was going through the std_daq_client relatively quickly as it was a bit more difficult to judge what happens without knowing the interface. The Preview looks nice. as I said, please tread most comments rather as question or suggestions. Looks good from my point of view

I was going through the std_daq_client relatively quickly as it was a bit more difficult to judge what happens without knowing the interface. The Preview looks nice. as I said, please tread most comments rather as question or suggestions. Looks good from my point of view
wakonig_k commented 2025-05-28 15:39:07 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

yes, but the backend doesn't accept the full path, it wants it in pieces :D

yes, but the backend doesn't accept the full path, it wants it in pieces :D
wakonig_k commented 2025-05-28 15:44:08 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 10e9cf0a - chore: disabled outdated devices

Compare with previous version

added 1 commit <ul><li>10e9cf0a - chore: disabled outdated devices</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45639&start_sha=9b7c0632c2a4c394cddccc278afd3c47fa17fdc7)
wakonig_k commented 2025-05-28 17:13:24 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

probably fine in this case though

probably fine in this case though
wakonig_k commented 2025-05-28 17:32:32 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45644&start_sha=10e9cf0a100c093f8340abe4c603dc12000c8220#8e8553fcf13feb38dc3579611041f116677cd9a9_176_174)
wakonig_k commented 2025-05-28 17:32:32 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45644&start_sha=10e9cf0a100c093f8340abe4c603dc12000c8220#8e8553fcf13feb38dc3579611041f116677cd9a9_258_258)
wakonig_k commented 2025-05-28 17:32:32 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45644&start_sha=10e9cf0a100c093f8340abe4c603dc12000c8220#8e8553fcf13feb38dc3579611041f116677cd9a9_676_729)
wakonig_k commented 2025-05-28 17:32:32 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45644&start_sha=10e9cf0a100c093f8340abe4c603dc12000c8220#8e8553fcf13feb38dc3579611041f116677cd9a9_664_716)
wakonig_k commented 2025-05-28 17:32:32 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45644&start_sha=10e9cf0a100c093f8340abe4c603dc12000c8220#8e8553fcf13feb38dc3579611041f116677cd9a9_703_756)
wakonig_k commented 2025-05-28 17:32:33 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45644&start_sha=10e9cf0a100c093f8340abe4c603dc12000c8220#8e8553fcf13feb38dc3579611041f116677cd9a9_698_751)
wakonig_k commented 2025-05-28 17:32:33 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45644&start_sha=10e9cf0a100c093f8340abe4c603dc12000c8220#8e8553fcf13feb38dc3579611041f116677cd9a9_727_793)
wakonig_k commented 2025-05-28 17:32:33 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45644&start_sha=10e9cf0a100c093f8340abe4c603dc12000c8220#8e8553fcf13feb38dc3579611041f116677cd9a9_744_801)
wakonig_k commented 2025-05-28 17:32:33 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 6f7e9f73 - chore: cleanup of gfcam

Compare with previous version

added 1 commit <ul><li>6f7e9f73 - chore: cleanup of gfcam</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45644&start_sha=10e9cf0a100c093f8340abe4c603dc12000c8220)
wakonig_k commented 2025-05-28 17:47:42 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

done

done
wakonig_k commented 2025-05-28 17:47:52 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

done

done
wakonig_k commented 2025-05-28 17:48:27 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

handled differently but I resolve this thread as we anyway discussed it offline

handled differently but I resolve this thread as we anyway discussed it offline
wakonig_k commented 2025-05-28 17:48:58 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

yes but as discussed offline, I changed it to a status return

yes but as discussed offline, I changed it to a status return
wakonig_k commented 2025-05-28 17:49:19 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

done

done
wakonig_k commented 2025-05-28 17:50:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

I don't see it used anywhere. I will remove it for now but it is easy to add back

I don't see it used anywhere. I will remove it for now but it is easy to add back
wakonig_k commented 2025-05-29 12:59:46 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • afd75001 - chore: cleanup and tests

Compare with previous version

added 1 commit <ul><li>afd75001 - chore: cleanup and tests</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45649&start_sha=6f7e9f73dd344319b671430cf6b51fc87ff2dd39)
wakonig_k commented 2025-05-29 13:04:02 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • bfe2ca36 - chore: cleanup and tests

Compare with previous version

added 1 commit <ul><li>bfe2ca36 - chore: cleanup and tests</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45651&start_sha=afd750013efa347317177c8122169da3a011b89f)
wakonig_k commented 2025-05-29 13:07:43 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 4193ceee - chore: cleanup and tests

Compare with previous version

added 1 commit <ul><li>4193ceee - chore: cleanup and tests</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45653&start_sha=bfe2ca3679b59f024a28218af1c8f1a44aa7797b)
wakonig_k commented 2025-05-29 13:29:27 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • dd0c1bc7 - fix(gfcam): fix typo in nframes_mode

Compare with previous version

added 1 commit <ul><li>dd0c1bc7 - fix(gfcam): fix typo in nframes_mode</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45654&start_sha=4193ceee4ae9878622da8df6e098078127b0786c)
wakonig_k commented 2025-05-29 13:37:24 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Well, the validator signal works for any type of validation. The validation functions are defined outside of the class.

I think it could be useful for more beamlines, so maybe it is even worth putting it in ophyd_devices

Well, the validator signal works for any type of validation. The validation functions are defined outside of the class. I think it could be useful for more beamlines, so maybe it is even worth putting it in ophyd_devices
wakonig_k commented 2025-05-29 13:51:44 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 4d936d81 - fix: import of pco

Compare with previous version

added 1 commit <ul><li>4d936d81 - fix: import of pco</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45656&start_sha=dd0c1bc76820cf64892396ddb26ec4b4b80e85a3)
wakonig_k commented 2025-05-29 13:53:10 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

done

done
wakonig_k commented 2025-05-29 13:53:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

done

done
wakonig_k commented 2025-06-05 18:59:57 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 3 commits

  • 10f8d9e2 - fix: add auto monitor to gfcam signals
  • 72eabd59 - feat: add std daq live processing
  • cadb8e77 - feat: add std live processing to gfcam

Compare with previous version

added 3 commits <ul><li>10f8d9e2 - fix: add auto monitor to gfcam signals</li><li>72eabd59 - feat: add std daq live processing</li><li>cadb8e77 - feat: add std live processing to gfcam</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45765&start_sha=4d936d8131caa2a9ba5de0eafa1ad2925399229a)
wakonig_k commented 2025-06-05 19:06:05 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • d577f092 - refactor: rename processing to live_processing

Compare with previous version

added 1 commit <ul><li>d577f092 - refactor: rename processing to live_processing</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45767&start_sha=cadb8e7706271696d7e305d8a75c490a47251069)
wakonig_k commented 2025-06-05 19:09:51 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 4fdd1f1d - fix: rename enabled to set_enabled

Compare with previous version

added 1 commit <ul><li>4fdd1f1d - fix: rename enabled to set_enabled</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45769&start_sha=d577f092692c72ff80c6f87205a085b7e53fd268)
wakonig_k commented 2025-06-05 19:13:42 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • b564e884 - feat: add set_mode to change processing modes

Compare with previous version

added 1 commit <ul><li>b564e884 - feat: add set_mode to change processing modes</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45771&start_sha=4fdd1f1d2108e98eb4b1f0db9c61adcc86a4667e)
wakonig_k commented 2025-06-12 10:40:38 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 540cffaa - fix: fix data analysis signal update

Compare with previous version

added 1 commit <ul><li>540cffaa - fix: fix data analysis signal update</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45957&start_sha=b564e88421cb3a55406780b581b4e56bef116682)
wakonig_k commented 2025-06-12 10:41:55 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 5f6700ac - feat: add progress signal

Compare with previous version

added 1 commit <ul><li>5f6700ac - feat: add progress signal</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45958&start_sha=540cffaa4f0e386fb12a4b48a6e747929b19c3b5)
marone commented 2025-06-12 17:42:05 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • a68eef40 - Added config file

Compare with previous version

added 1 commit <ul><li>a68eef40 - Added config file</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45961&start_sha=5f6700ac626240f26cf59fe07fb1297ccd7f374c)
wakonig_k commented 2025-06-13 08:12:43 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 053e8541 - refactor: pco edge refactoring

Compare with previous version

added 1 commit <ul><li>053e8541 - refactor: pco edge refactoring</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45964&start_sha=a68eef401de93b216b4ac69561a03612449f5684)
wakonig_k commented 2025-06-15 10:37:07 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 2 commits

  • 0d938aa9 - fix(pcoedge): fix typos in component args
  • fe2bd4c7 - fix(pcocam): bug fixes towards a first working version

Compare with previous version

added 2 commits <ul><li>0d938aa9 - fix(pcoedge): fix typos in component args</li><li>fe2bd4c7 - fix(pcocam): bug fixes towards a first working version</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45991&start_sha=053e85415f865d663f807602c0ea02db07a4b97e)
wakonig_k commented 2025-06-15 12:33:08 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 5 commits

  • 4e11b0d8 - refactor(pco): cleanup
  • 15335d27 - feat(gfcam): add device manager
  • df26ef7e - fix(pco): cleanup
  • 062db0c5 - feat(stddaq): add live ref processing
  • a34b5f7d - test: add first round of tests

Compare with previous version

added 5 commits <ul><li>4e11b0d8 - refactor(pco): cleanup</li><li>15335d27 - feat(gfcam): add device manager</li><li>df26ef7e - fix(pco): cleanup</li><li>062db0c5 - feat(stddaq): add live ref processing</li><li>a34b5f7d - test: add first round of tests</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45992&start_sha=fe2bd4c722e70473b1f5bb889bf8506cbf913d5b)
wakonig_k commented 2025-06-15 12:35:59 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 3eb3c820 - test: add missing fakeredis depencency

Compare with previous version

added 1 commit <ul><li>3eb3c820 - test: add missing fakeredis depencency</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45994&start_sha=a34b5f7d9fd220f423fa82c17ee2219786c48d96)
wakonig_k commented 2025-06-15 14:49:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 2 commits

  • d057747c - test(live processing): add more tests
  • a32d93c0 - fix(live processing): fetch from redis if not available

Compare with previous version

added 2 commits <ul><li>d057747c - test(live processing): add more tests</li><li>a32d93c0 - fix(live processing): fetch from redis if not available</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45996&start_sha=3eb3c8200de0a221d4972a10b8b9a505280a60d4)
wakonig_k commented 2025-06-15 15:23:44 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • eb25a9fd - feat(live processing): add flat-dark correction

Compare with previous version

added 1 commit <ul><li>eb25a9fd - feat(live processing): add flat-dark correction</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45998&start_sha=a32d93c03f2277690f87bfb49e195370b1def859)
wakonig_k commented 2025-06-15 15:26:06 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • e74ee2bf - refactor(std_daq): lower requirements of status object to StatusBase

Compare with previous version

added 1 commit <ul><li>e74ee2bf - refactor(std_daq): lower requirements of status object to StatusBase</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=45999&start_sha=eb25a9fd4bfb27c9b04e03c22987a848feac2292)
wakonig_k commented 2025-06-15 19:11:26 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 5 commits

  • 0a5b9e08 - fix(std_daq_config): do not enforce optional config params
  • 232b138b - test(std_daq): exclude None when checking configs
  • c333e20c - refactor(std_daq): unify access to frames_per_trigger
  • bacb75e1 - feat(live processing): allow live processing to run in a background thread
  • 8029eade - feat: add rpc method for updating the live processing refs

Compare with previous version

added 5 commits <ul><li>0a5b9e08 - fix(std_daq_config): do not enforce optional config params</li><li>232b138b - test(std_daq): exclude None when checking configs</li><li>c333e20c - refactor(std_daq): unify access to frames_per_trigger</li><li>bacb75e1 - feat(live processing): allow live processing to run in a background thread</li><li>8029eade - feat: add rpc method for updating the live processing refs</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=46003&start_sha=e74ee2bf3ea54ad9cb6e3f490f88628bde94f587)
wakonig_k commented 2025-06-16 16:50:37 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • a9d7b942 - fix(pco): stop long-lasting status object on stop

Compare with previous version

added 1 commit <ul><li>a9d7b942 - fix(pco): stop long-lasting status object on stop</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=46020&start_sha=8029eade0eaaf04da8a884c5d40f07f0a06c3f13)
wakonig_k commented 2025-06-16 16:58:21 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 2 commits

  • 57b68011 - Added config file
  • 21fca437 - refactor: std daq integration

Compare with previous version

added 2 commits <ul><li>57b68011 - Added config file</li><li>21fca437 - refactor: std daq integration</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=46022&start_sha=a9d7b9428647e51906a460a28cde1ae74deabf05)
wakonig_k commented 2025-06-16 16:58:47 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

resolved all threads

resolved all threads
wakonig_k commented 2025-06-16 16:59:09 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 4 commits

Compare with previous version

added 4 commits <ul><li>96ca9c32 - 1 commit from branch <code>main</code></li><li>bbb61d71 - chore: add tomcat as default session</li><li>c82e7c3d - Added config file</li><li>ae85d179 - refactor: std daq integration</li></ul> [Compare with previous version](/bec/tomcat_bec/-/merge_requests/30/diffs?diff_id=46024&start_sha=21fca43724d27aceb5c00739bc2dc02c8989e478)
wakonig_k commented 2025-06-16 16:59:18 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

marked this merge request as ready

marked this merge request as **ready**
wakonig_k (Migrated from gitlab.psi.ch) scheduled this pull request to auto merge when all checks succeed 2025-06-16 16:59:28 +02:00
wakonig_k (Migrated from gitlab.psi.ch) merged commit into main 2025-06-16 17:01:31 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea bonnin_a celcer_t debenjak_l divall_e lombosi_c lovric_g marone perl_d schlepuetz_c stampanoni usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/tomcat_bec#31
Delete Branch "gac-x05la_20250527T131936"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?