bec/superxas_bec
0
0
Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Feat/add devices #8

Merged
appel_c merged 9 commits from feat/add_devices into main 2025-06-10 11:08:25 +02:00
Conversation 22 Commits 9 Files Changed 7 +985
appel_c commented 2025-03-20 16:45:55 +01:00 (Migrated from gitlab.psi.ch)
Copy Link

MR to integrating the Falcon and the Trigger card to the superXAS repository.

MR to integrating the Falcon and the Trigger card to the superXAS repository.
appel_c commented 2025-03-20 16:45:55 +01:00 (Migrated from gitlab.psi.ch)
Copy Link

assigned to @appel_c

assigned to @appel_c
wakonig_k (Migrated from gitlab.psi.ch) approved these changes 2025-03-20 16:45:55 +01:00
appel_c commented 2025-03-20 16:48:54 +01:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 97fd8c9f - fix: remove mono_energy, IOC not EPICSMotorRecord

Compare with previous version

added 1 commit <ul><li>97fd8c9f - fix: remove mono_energy, IOC not EPICSMotorRecord</li></ul> [Compare with previous version](/bec/superxas_bec/-/merge_requests/4/diffs?diff_id=43149&start_sha=2849325c928d8cefd0b025e31b6f0bd9a8f67a42)
appel_c commented 2025-03-22 11:25:44 +01:00 (Migrated from gitlab.psi.ch)
Copy Link

added 3 commits

  • bf3e79f4 - refactor: update config
  • ac9b6a1b - refactor(trigger): refactor trigger device, add tests
  • e6eeb41f - refactor(falcon): cleanup and add tests

Compare with previous version

added 3 commits <ul><li>bf3e79f4 - refactor: update config</li><li>ac9b6a1b - refactor(trigger): refactor trigger device, add tests</li><li>e6eeb41f - refactor(falcon): cleanup and add tests</li></ul> [Compare with previous version](/bec/superxas_bec/-/merge_requests/4/diffs?diff_id=43268&start_sha=97fd8c9fd13f3da3048b6d6a59700d2beee67927)
appel_c commented 2025-03-22 11:28:46 +01:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 54bb5928 - refactor: cleanup and formatter on exafs_scan

Compare with previous version

added 1 commit <ul><li>54bb5928 - refactor: cleanup and formatter on exafs_scan</li></ul> [Compare with previous version](/bec/superxas_bec/-/merge_requests/4/diffs?diff_id=43270&start_sha=e6eeb41f97710c1f9ee0183e22dbc64c029ea5e3)
appel_c commented 2025-03-22 11:42:53 +01:00 (Migrated from gitlab.psi.ch)
Copy Link

passes if pipeline runs against branch on ophyd that needs merge first:
https://gitlab.psi.ch/bec/superxas_bec/-/pipelines/54855

passes if pipeline runs against branch on ophyd that needs merge first: https://gitlab.psi.ch/bec/superxas_bec/-/pipelines/54855
appel_c commented 2025-05-12 19:19:58 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 46631a99 - refactor(falcon): moved logic to base class in ophyd_devices

Compare with previous version

added 1 commit <ul><li>46631a99 - refactor(falcon): moved logic to base class in ophyd_devices</li></ul> [Compare with previous version](/bec/superxas_bec/-/merge_requests/4/diffs?diff_id=45179&start_sha=54bb5928ff7440b4e7abb48054ad388407eb3a6b)
appel_c commented 2025-05-12 19:34:22 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed the description

changed the description
appel_c commented 2025-05-13 08:46:28 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 9 commits

  • 6992cd3a - 1 commit from branch main
  • 345807f7 - feat: add falcon integration
  • fda08595 - feat: add trigger card integration
  • 205f513f - feat: add exafs with k step scan
  • 4588a1b2 - refactor: update config
  • 5a0702f9 - refactor(trigger): refactor trigger device, add tests
  • cd91375f - refactor(falcon): cleanup and add tests
  • 61c36903 - refactor: cleanup and formatter on exafs_scan
  • b05f0a66 - refactor(falcon): moved logic to base class in ophyd_devices

Compare with previous version

added 9 commits <ul><li>6992cd3a - 1 commit from branch <code>main</code></li><li>345807f7 - feat: add falcon integration</li><li>fda08595 - feat: add trigger card integration</li><li>205f513f - feat: add exafs with k step scan</li><li>4588a1b2 - refactor: update config</li><li>5a0702f9 - refactor(trigger): refactor trigger device, add tests</li><li>cd91375f - refactor(falcon): cleanup and add tests</li><li>61c36903 - refactor: cleanup and formatter on exafs_scan</li><li>b05f0a66 - refactor(falcon): moved logic to base class in ophyd_devices</li></ul> [Compare with previous version](/bec/superxas_bec/-/merge_requests/4/diffs?diff_id=45190&start_sha=46631a9937de09c88e77e0b63b63e8de0e9596aa)
appel_c commented 2025-06-03 14:38:15 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

requested review from @wakonig_k

requested review from @wakonig_k
wakonig_k commented 2025-06-03 16:31:16 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

maybe elaborate a bit on this comment

maybe elaborate a bit on this comment
wakonig_k commented 2025-06-03 16:31:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

a slightly more informative error message would be nice ;P

a slightly more informative error message would be nice ;P
wakonig_k commented 2025-06-03 16:31:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

lgtm

lgtm
appel_c commented 2025-06-03 17:31:33 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/bec/superxas_bec/-/merge_requests/4/diffs?diff_id=45698&start_sha=b05f0a66216301e4847969856e215df3ba638560#c1693fdfd7dfb14dca163a5cc22604528eb5246c_76_78)
appel_c commented 2025-06-03 17:31:33 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/bec/superxas_bec/-/merge_requests/4/diffs?diff_id=45698&start_sha=b05f0a66216301e4847969856e215df3ba638560#c1693fdfd7dfb14dca163a5cc22604528eb5246c_79_81)
appel_c commented 2025-06-03 17:31:33 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 0bc35466 - refactor(exafs-scan): improve docstring and logmessage

Compare with previous version

added 1 commit <ul><li>0bc35466 - refactor(exafs-scan): improve docstring and logmessage</li></ul> [Compare with previous version](/bec/superxas_bec/-/merge_requests/4/diffs?diff_id=45698&start_sha=b05f0a66216301e4847969856e215df3ba638560)
appel_c commented 2025-06-03 17:32:10 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

done

done
wakonig_k commented 2025-06-03 17:57:32 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

resolved all threads

resolved all threads
wakonig_k commented 2025-06-03 17:57:36 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

approved this merge request

approved this merge request
appel_c commented 2025-06-03 18:32:48 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

marked this merge request as ready

marked this merge request as **ready**
appel_c (Migrated from gitlab.psi.ch) scheduled this pull request to auto merge when all checks succeed 2025-06-03 18:32:49 +02:00
appel_c commented 2025-06-03 18:33:12 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

mentioned in issue #2

mentioned in issue #2
appel_c commented 2025-06-03 18:33:29 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

mentioned in issue #1

mentioned in issue #1
appel_c (Migrated from gitlab.psi.ch) merged commit into main 2025-06-10 11:08:25 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
wakonig_k
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea celcer_t debenjak_l divall_e lombosi_c nachtegaal perl_d safonova_o stubbs_s usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/superxas_bec#8
Delete Branch "feat/add_devices"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?