bec/superxas_bec
0
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Migrate SuperXAS scans to V4 #21

Merged
hitz_s merged 4 commits from superxas-v4-migration into main 2026-06-02 12:49:40 +02:00
Conversation 2 Commits 4 Files Changed 13
+945 -476
appel_c commented 2026-05-28 08:51:38 +02:00
Owner
Copy Link
Copy Source

This is a first draft for migrating the XAS mono bragg/nidaq scans from the old interface to the V4 interface. This draft is mostly written by an agent, will be tested, reviewed and we will see if it is suitable to continue with it as it is.

This is a first draft for migrating the XAS mono bragg/nidaq scans from the old interface to the V4 interface. This draft is mostly written by an agent, will be tested, reviewed and we will see if it is suitable to continue with it as it is.
appel_c added 3 commits 2026-05-28 17:08:18 +02:00
refactor: migrate xas_scans to v4 e52c4d1f85
fix: minor fixes after test at the beamline d443f228bc
refactor: cleanup, and remove readability
CI for superxas_bec / test (push) Successful in 1m32s
Details
CI for superxas_bec / test (pull_request) Successful in 1m44s
Details
c1ba279b98
appel_c force-pushed superxas-v4-migration from 0134c07d0d to c1ba279b98 2026-05-28 17:08:18 +02:00 Compare
appel_c requested review from hitz_s 2026-05-28 17:08:38 +02:00
appel_c requested review from wakonig_k 2026-05-28 17:08:38 +02:00
appel_c commented 2026-05-28 17:09:14 +02:00
Author
Owner
Copy Link
Copy Source

@hitz_s

To me it looks good, I would suggest still testing the advanced scan before we merge this. Let me know if you need a hand with that on Monday.

@hitz_s To me it looks good, I would suggest still testing the advanced scan before we merge this. Let me know if you need a hand with that on Monday.
bec_bl_push-gitea added 1 commit 2026-06-02 10:44:34 +02:00
fix: mo1_bragg calculator
CI for superxas_bec / test (push) Successful in 1m32s
Details
CI for superxas_bec / test (pull_request) Successful in 1m54s
Details
3fb2fd9703
hitz_s merged commit 295e4ca9e7 into main 2026-06-02 12:49:40 +02:00
hitz_s deleted branch superxas-v4-migration 2026-06-02 12:49:51 +02:00
hitz_s commented 2026-06-02 12:50:41 +02:00
Member
Copy Link
Copy Source

Advanced scan tested and works (there was also a bug in the firmware of the mono)

Advanced scan tested and works (there was also a bug in the firmware of the mono)
Sign in to join this conversation.
Reviewers
No Reviewers
hitz_s
wakonig_k
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) clark_a (clark_a) debenjak_l (debenjak_l) divall_e (divall_e) haghta_s (haghta_s) hitz_s (hitz_s) lombosi_c (lombosi_c) nachtegaal (nachtegaal) perl_d (perl_d) safonova_o (safonova_o) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/superxas_bec#21
Delete Branch "superxas-v4-migration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?