bec/pxiii_bec
0
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(samcam): move to psi device base #26

Open
wakonig_k wants to merge 1 commits from fix/samcam into main
pull from: fix/samcam
merge into: bec:main
Conversation 1 Commits 1 Files Changed 1 +57 -25
wakonig_k commented 2025-11-14 10:53:47 +01:00
Owner
Copy Link

Moving the samcam from the deprecated DetectorBase class to PSIDeviceBase. No logic changes

Moving the samcam from the deprecated DetectorBase class to PSIDeviceBase. No logic changes
wakonig_k added 1 commit 2025-11-14 10:53:48 +01:00
fix(samcam): move to psi device base
All checks were successful
CI for pxiii_bec / test (pull_request) Successful in 1m16s
Details
CI for pxiii_bec / test (push) Successful in 29s
Details
2e428140e8
wakonig_k requested review from appel_c 2025-11-14 10:56:19 +01:00
wakonig_k requested review from perl_d 2025-11-14 10:56:19 +01:00
perl_d approved these changes 2025-11-17 08:49:36 +01:00
perl_d left a comment
Owner
Copy Link

lgtm 🚀

lgtm 🚀
All checks were successful
CI for pxiii_bec / test (pull_request) Successful in 1m16s
Details
CI for pxiii_bec / test (push) Successful in 29s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/samcam:fix/samcam
git checkout fix/samcam
Sign in to join this conversation.
Reviewers
No Reviewers
appel_c
perl_d
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c appleb_m beale_j bec_bl_push-gitea bec-gitea buntschu_d celcer_t debenjak_l divall_e duan_j dworkowski glettig_w gotthard_g huang_c kepa_m leonarski_f lombosi_c marsh_m mcauley_k meier_n2 olieric panepucci pauluhn perl_d plichta_e reber silvae_f stegma_d stubbs_s takaba_k tomizaki usov_i wakonig_k wang_m wang_x1 wyzula_j zamofing_t
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/pxiii_bec#26
Delete Branch "fix/samcam"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?