bec/phoenix_bec
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature/phoenix trigger #4

Merged
appel_c merged 4 commits from feature/phoenix_trigger into main 2024-08-28 16:54:36 +02:00
Conversation 5 Commits 4 Files Changed 5 +241 -159
appel_c commented 2024-08-28 16:03:42 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

This MR adds the PhoenixTrigger device to the repository. In addition, tests were added to ensure functionality of stage/unstage/trigger/stop commands.

This MR adds the PhoenixTrigger device to the repository. In addition, tests were added to ensure functionality of stage/unstage/trigger/stop commands.
appel_c commented 2024-08-28 16:03:42 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

requested review from @wakonig_k and @huthwelker

requested review from @wakonig_k and @huthwelker
appel_c commented 2024-08-28 16:03:42 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

assigned to @appel_c

assigned to @appel_c
appel_c commented 2024-08-28 16:09:06 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 90fdebe2 - fix: remove DummyDetector import from init; crashes pipeline due to syntax error

Compare with previous version

added 1 commit <ul><li>90fdebe2 - fix: remove DummyDetector import from init; crashes pipeline due to syntax error</li></ul> [Compare with previous version](/bec/phoenix_bec/-/merge_requests/4/diffs?diff_id=34620&start_sha=01775e0d18718c84439f7fd2565a0d4d095ed668)
appel_c commented 2024-08-28 16:13:28 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • b0040798 - fix: remove copy/paste bug

Compare with previous version

added 1 commit <ul><li>b0040798 - fix: remove copy/paste bug</li></ul> [Compare with previous version](/bec/phoenix_bec/-/merge_requests/4/diffs?diff_id=34627&start_sha=90fdebe20024a2078169f7f2301a2ee53d074acb)
appel_c commented 2024-08-28 16:21:42 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 5 commits

  • bfa06fe5 - 1 commit from branch main
  • b752a79c - refactor: cleanup phoenix_trigger device
  • 5ba10cdf - test: add tests for phoenix_trigger device
  • 66eff8e5 - fix: remove DummyDetector import from init; crashes pipeline due to syntax error
  • 3423a978 - fix: remove copy/paste bug

Compare with previous version

added 5 commits <ul><li>bfa06fe5 - 1 commit from branch <code>main</code></li><li>b752a79c - refactor: cleanup phoenix_trigger device</li><li>5ba10cdf - test: add tests for phoenix_trigger device</li><li>66eff8e5 - fix: remove DummyDetector import from init; crashes pipeline due to syntax error</li><li>3423a978 - fix: remove copy/paste bug</li></ul> [Compare with previous version](/bec/phoenix_bec/-/merge_requests/4/diffs?diff_id=34631&start_sha=b00407982925f6dc12aeab717893910f5047c37a)
huthwelker (Migrated from gitlab.psi.ch) merged commit into main 2024-08-28 16:54:36 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea borca celcer_t debenjak_l divall_e huthwelker lombosi_c perl_d stubbs_s usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/phoenix_bec#4
Delete Branch "feature/phoenix_trigger"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?