bec/ophyd_devices
1
0
Fork 0
Code Issues 9 Pull Requests 10 Actions Packages Projects Releases 126 Wiki Activity

fix: small bugfix to ensure motor_is_moving updates at the end of a move

Browse Source
This commit is contained in:
appel_c 2024-08-08 17:08:38 +02:00
parent 9f46069959
commit 577b35f287
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ophyd_devices/sim/sim_positioner.py
View File

@ -169,7 +169,6 @@ class SimPositioner(Device, PositionerBase):
self._update_state(ii) self._update_state(ii)
if self._stopped: if self._stopped:
raise DeviceStopError(f"{self.parent.name} was stopped") raise DeviceStopError(f"{self.parent.name} was stopped")
self._update_state(target)
st.set_finished() st.set_finished()
# pylint: disable=broad-except # pylint: disable=broad-except
except Exception as exc: except Exception as exc:
@ -180,6 +179,7 @@ class SimPositioner(Device, PositionerBase):
st.set_exception(exc=exc) st.set_exception(exc=exc)
finally: finally:
self._set_sim_state(self.motor_is_moving.name, 0) self._set_sim_state(self.motor_is_moving.name, 0)
self._update_state(target)
def move(self, value: float, **kwargs) -> DeviceStatus: def move(self, value: float, **kwargs) -> DeviceStatus:
"""Change the setpoint of the simulated device, and simultaneously initiate a motion.""" """Change the setpoint of the simulated device, and simultaneously initiate a motion."""
@ -196,9 +196,9 @@ class SimPositioner(Device, PositionerBase):
) )
self.move_thread.start() self.move_thread.start()
else: else:
self._update_state(value)
self._done_moving() self._done_moving()
self._set_sim_state(self.motor_is_moving.name, 0) self._set_sim_state(self.motor_is_moving.name, 0)
self._update_state(value)
st.set_finished() st.set_finished()
return st return st