bec/debye_bec
0
0
Fork 0
Code Issues 9 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Minor adjustments to Digital Twin Widget #80

Closed
wyzula_j wants to merge 3 commits from digital-twin-jan-review-1 into main
pull from: digital-twin-jan-review-1
merge into: :main
Conversation 1 Commits 3 Files Changed 11
+135 -184
wyzula_j commented 2026-06-09 16:04:53 +02:00
Owner
Copy Link
Copy Source
  • tighter layout and scroll area
  • fix offset file path
  • fix string checking in to ==
- tighter layout and scroll area - fix offset file path - fix string checking `in` to `==`
wyzula_j self-assigned this 2026-06-09 16:04:53 +02:00
wyzula_j added 3 commits 2026-06-09 16:04:53 +02:00
fix(digital-twin): use exact string comparisons 6bce6f8907 
Replace substring membership checks with equality for modes, stripes, scene names, and plot identifiers so partial strings cannot select the wrong branch.
refactor(digital-twin): compact widget layout dc6966ee31 
Wrap side panels in vertical scroll areas, tighten row and group spacing, use a balanced 1:1 plot area, and avoid assigning a second top-level layout.

Also aligns MotionWorker signal signatures with the slots connected to them as part of the widget cleanup.
fix(digital-twin): resolve offsets file from package
CI for debye_bec / test (push) Successful in 1m0s
Details
CI for debye_bec / test (pull_request) Successful in 57s
Details
d820d5adb5 
Load x01da_offsets.yaml relative to digital_twin.py instead of the process working directory so the widget starts correctly from any launch location.
wyzula_j requested review from hitz_s 2026-06-09 16:04:53 +02:00
hitz_s commented 2026-06-10 15:52:20 +02:00
Member
Copy Link
Copy Source

Cherry-picked your commits into feat/digital-twin-adaption-superxas since this is the development branch of digital twin.

Cherry-picked your commits into feat/digital-twin-adaption-superxas since this is the development branch of digital twin.
hitz_s closed this pull request 2026-06-10 15:52:28 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
hitz_s
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) clark_a (clark_a) debenjak_l (debenjak_l) divall_e (divall_e) haghta_s (haghta_s) hitz_s (hitz_s) lombosi_c (lombosi_c) nachtegaal (nachtegaal) perl_d (perl_d) tiefenbacher_s (tiefenbacher_s) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees wyzula_j
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/debye_bec#80