bec/debye_bec
0
0
Fork 0
Code Issues 9 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

chore(nidaq): improve readbability of nidaq signal definition #71

Open
wakonig_k wants to merge 1 commits from chore/nidaq_formatter into feat/various-improvements
pull from: chore/nidaq_formatter
merge into: bec:feat/various-improvements
Conversation 6 Commits 1 Files Changed 1
+91 -396
wakonig_k commented 2026-05-05 11:32:37 +02:00
Owner
Copy Link
Copy Source

To improve the readability of the signal definition in the nidaq ophyd device, I propose to disable the formatter. The PR does not change anything else, just formatting

image.png
To improve the readability of the signal definition in the nidaq ophyd device, I propose to disable the formatter. The PR does not change anything else, just formatting <img width="935" alt="image.png" src="attachments/9d21c252-37a9-403c-af25-a20995979ebf">
image.png
1.1 MiB
wakonig_k requested review from appel_c 2026-05-05 11:32:51 +02:00
wakonig_k requested review from clark_a 2026-05-05 11:32:52 +02:00
wakonig_k requested review from hitz_s 2026-05-05 11:32:52 +02:00
hitz_s commented 2026-05-05 12:24:23 +02:00
Member
Copy Link
Copy Source

I'm fine with the changes, however they should be made in the feat/various-improvements branch, as we edited that file there already quite a bit.

I'm fine with the changes, however they should be made in the feat/various-improvements branch, as we edited that file there already quite a bit.
👍 1
wakonig_k commented 2026-05-05 12:25:29 +02:00
Author
Owner
Copy Link
Copy Source

@hitz_s I can push it to the branch if you want

@hitz_s I can push it to the branch if you want
hitz_s commented 2026-05-05 12:32:02 +02:00
Member
Copy Link
Copy Source

Sure, just please use the current order of the signals. It is the order in which they are listed in the gui (for example waveform signal selection).

Sure, just please use the current order of the signals. It is the order in which they are listed in the gui (for example waveform signal selection).
image.png
41 KiB
image.png
wakonig_k changed target branch from main to feat/various-improvements 2026-05-05 12:45:47 +02:00
wakonig_k added 1 commit 2026-05-05 12:45:47 +02:00
chore(nidaq): improve readbability of nidaq signal definition
CI for debye_bec / test (pull_request) Failing after 1m12s
Details
CI for debye_bec / test (push) Failing after 1m36s
Details
b00b157e3e
wakonig_k commented 2026-05-05 12:47:17 +02:00
Author
Owner
Copy Link
Copy Source

@hitz_s I rebased it on your feature branch and redirected the PR to it.

@hitz_s I rebased it on your feature branch and redirected the PR to it.
wakonig_k commented 2026-05-05 14:55:26 +02:00
Author
Owner
Copy Link
Copy Source

@hitz_s @clark_a I would suggest that we merge your long-standing feature (feat/various-improvements) branch soon. It is already quite long and has been open for quite some time. If you need help with rebasing or cleanup, just let us know!

@hitz_s @clark_a I would suggest that we merge your long-standing feature (feat/various-improvements) branch soon. It is already quite long and has been open for quite some time. If you need help with rebasing or cleanup, just let us know!
hitz_s commented 2026-05-05 15:08:24 +02:00
Member
Copy Link
Copy Source

Sure, once the digital twin is more or less running.

Sure, once the digital twin is more or less running.
Some checks are pending
CI for debye_bec / test (pull_request) Failing after 1m12s
Details
CI for debye_bec / test (push) Failing after 1m36s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin chore/nidaq_formatter:chore/nidaq_formatter
git checkout chore/nidaq_formatter
Sign in to join this conversation.
Reviewers
No Reviewers
appel_c
hitz_s
clark_a
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) clark_a (clark_a) debenjak_l (debenjak_l) divall_e (divall_e) haghta_s (haghta_s) hitz_s (hitz_s) lombosi_c (lombosi_c) nachtegaal (nachtegaal) perl_d (perl_d) tiefenbacher_s (tiefenbacher_s) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/debye_bec#71
Delete Branch "chore/nidaq_formatter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?