bec/debye_bec
0
0
Fork 0
Code Issues 9 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Refactor/remove run subs add psi signals #57

Merged
appel_c merged 11 commits from refactor/remove_run_subs_add_psi_signals into main 2025-06-23 18:24:24 +02:00
Conversation 20 Commits 11 Files Changed 15 +316 -213
appel_c commented 2025-06-20 09:18:12 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
No description provided.
appel_c commented 2025-06-20 09:18:12 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

assigned to @appel_c

assigned to @appel_c
wakonig_k (Migrated from gitlab.psi.ch) approved these changes 2025-06-20 09:18:12 +02:00
clark_a (Migrated from gitlab.psi.ch) approved these changes 2025-06-20 09:18:12 +02:00
appel_c commented 2025-06-20 09:19:54 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>abf432f2 - refactor: fix formatting</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/34/diffs?diff_id=46095&start_sha=b3672cf5f5b5439c8bec5be05790d819019a093f)
appel_c commented 2025-06-20 09:30:56 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 43e8aea6 - tests: fix test for MR, mo1_bragg and nidaq tests skipped, check issue 22

Compare with previous version

added 1 commit <ul><li>43e8aea6 - tests: fix test for MR, mo1_bragg and nidaq tests skipped, check issue 22</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/34/diffs?diff_id=46097&start_sha=abf432f2a920dcc54c498e81a92384eb06338420)
appel_c commented 2025-06-20 09:40:05 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

requested review from @wakonig_k, @clark_a, and @hitz_s

requested review from @wakonig_k, @clark_a, and @hitz_s
appel_c commented 2025-06-20 09:40:08 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

marked this merge request as ready

marked this merge request as **ready**
appel_c commented 2025-06-20 09:41:16 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

FYI, I will work on #22, and add callback mechanism to our mock_pv. Not sure if we rather wait for this, or merge this first. I left comments for 3 tests that I had to modify. This is now linked with changes related to using TranisitionStatus and CompareStatus.

FYI, I will work on #22, and add callback mechanism to our mock_pv. Not sure if we rather wait for this, or merge this first. I left comments for 3 tests that I had to modify. This is now linked with changes related to using `TranisitionStatus` and `CompareStatus`.
wakonig_k commented 2025-06-20 11:38:14 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

num_rotation_90 should be a positive integer. So 3 in your case

num_rotation_90 should be a positive integer. So 3 in your case
wakonig_k commented 2025-06-20 11:38:14 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

3

3
appel_c commented 2025-06-23 16:07:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/bec/debye_bec/-/merge_requests/34/diffs?diff_id=46114&start_sha=43e8aea6c8330066caa554d6491a1531b4d4086a#f71cdbc14c03d12e76cf6bbf445abd304c936f90_37_37)
appel_c commented 2025-06-23 16:07:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • bfd5b08f - fix(camera): fix num_rotation_90 for cameras

Compare with previous version

added 1 commit <ul><li>bfd5b08f - fix(camera): fix num_rotation_90 for cameras</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/34/diffs?diff_id=46114&start_sha=43e8aea6c8330066caa554d6491a1531b4d4086a)
appel_c commented 2025-06-23 16:07:26 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

done

done
appel_c commented 2025-06-23 16:07:29 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

done

done
wakonig_k commented 2025-06-23 16:08:06 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

approved this merge request

approved this merge request
appel_c commented 2025-06-23 16:31:49 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • ed6d64c7 - fix(camera): fix num_rotation_90 for cameras

Compare with previous version

added 1 commit <ul><li>ed6d64c7 - fix(camera): fix num_rotation_90 for cameras</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/34/diffs?diff_id=46116&start_sha=bfd5b08fea8900768aede3f4701d57198705490c)
appel_c commented 2025-06-23 16:32:01 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

resolved all threads

resolved all threads
appel_c commented 2025-06-23 16:32:02 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

reset approvals from @wakonig_k by pushing to the branch

reset approvals from @wakonig_k by pushing to the branch
wakonig_k commented 2025-06-23 16:55:08 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

approved this merge request

approved this merge request
clark_a commented 2025-06-23 18:16:22 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

approved this merge request

approved this merge request
appel_c (Migrated from gitlab.psi.ch) merged commit into main 2025-06-23 18:24:24 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
wakonig_k
clark_a
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea celcer_t clark_a debenjak_l divall_e hitz_s lombosi_c nachtegaal perl_d tiefenbacher_s usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/debye_bec#57
Delete Branch "refactor/remove_run_subs_add_psi_signals"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?