bec/debye_bec
0
0
Fork 0
Code Issues 9 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Fix/operational improvements #54

Merged
appel_c merged 10 commits from fix/operational_improvements into main 2025-06-18 14:28:24 +02:00
Conversation 14 Commits 10 Files Changed 9 +876 -26
appel_c commented 2025-05-13 15:52:49 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

MR to add additional functionally based on the latest beamline developements. It adds a new scan (nidaq_continous_scan), and extends the integration of the nidaq for this use case. In addition, tests were added for the device integration among other minor changes.

Last but not least, two issues were created to improve tests for the NIDAQ #21 and #22. Those will be addressed in future.

MR to add additional functionally based on the latest beamline developements. It adds a new scan (nidaq_continous_scan), and extends the integration of the `nidaq` for this use case. In addition, tests were added for the device integration among other minor changes. Last but not least, two issues were created to improve tests for the NIDAQ #21 and #22. Those will be addressed in future.
appel_c commented 2025-05-13 15:52:49 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

assigned to @appel_c

assigned to @appel_c
clark_a commented 2025-05-13 15:57:03 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • ad75e67c - update of test_config to include focusing mirror

Compare with previous version

added 1 commit <ul><li>ad75e67c - update of test_config to include focusing mirror</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/31/diffs?diff_id=45219&start_sha=c4c2f40e901b20519fb596ff21f2a55d422abf5f)
appel_c commented 2025-05-16 14:53:16 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 9717b399 - refactor(nidaq): add energy pv from nidaq

Compare with previous version

added 1 commit <ul><li>9717b399 - refactor(nidaq): add energy pv from nidaq</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/31/diffs?diff_id=45312&start_sha=ad75e67c19b9a2f2692c8b0883426d69cf2f1de2)
appel_c commented 2025-05-16 15:24:45 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 17 commits

  • 9717b399...e4556ad9 - 13 commits from branch main
  • b4647a75 - refactor: update configs with optic slit config, machine config
  • 728e4d16 - feat(nidaq): ensure nidaq is powered on during on_connected
  • c41593aa - update of test_config to include focusing mirror
  • 809a8af5 - refactor(nidaq): add energy pv from nidaq

Compare with previous version

added 17 commits <ul><li>9717b399...e4556ad9 - 13 commits from branch <code>main</code></li><li>b4647a75 - refactor: update configs with optic slit config, machine config</li><li>728e4d16 - feat(nidaq): ensure nidaq is powered on during on_connected</li><li>c41593aa - update of test_config to include focusing mirror</li><li>809a8af5 - refactor(nidaq): add energy pv from nidaq</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/31/diffs?diff_id=45330&start_sha=9717b399d19094d1ae74a8e515d0db6054a83c0e)
hitz_s commented 2025-05-27 09:16:20 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 4a4c96e3 - typo and adding pinhole motors

Compare with previous version

added 1 commit <ul><li>4a4c96e3 - typo and adding pinhole motors</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/31/diffs?diff_id=45584&start_sha=809a8af5612c845a070f8a6983d4d4dc88bfaeb5)
appel_c commented 2025-05-27 11:48:02 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 4 commits

  • 6c25c7f9 - feat: add nidaq_continuous_scan scan
  • eaea315a - fix: double timeout for for wait for ScanControlMessage
  • f421e2fd - wip: add test file for nidaq scan
  • bb332054 - wip update config

Compare with previous version

added 4 commits <ul><li>6c25c7f9 - feat: add nidaq_continuous_scan scan</li><li>eaea315a - fix: double timeout for for wait for ScanControlMessage</li><li>f421e2fd - wip: add test file for nidaq scan</li><li>bb332054 - wip update config</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/31/diffs?diff_id=45593&start_sha=4a4c96e30b867be0d4fa9c0471a13f8c0ceae401)
appel_c commented 2025-05-27 16:04:08 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 5 commits

  • d38e74e3 - typo and adding pinhole motors
  • adc7b79b - feat: add nidaq_continuous_scan scan
  • 4d1cdb0d - fix: double timeout for for wait for ScanControlMessage
  • d89cab98 - test: add test for nidaq continous scan
  • bb72ae4a - fix(nidaq): fix proper handling return of DeviceStatus for complete method

Compare with previous version

added 5 commits <ul><li>d38e74e3 - typo and adding pinhole motors</li><li>adc7b79b - feat: add nidaq_continuous_scan scan</li><li>4d1cdb0d - fix: double timeout for for wait for ScanControlMessage</li><li>d89cab98 - test: add test for nidaq continous scan</li><li>bb72ae4a - fix(nidaq): fix proper handling return of DeviceStatus for complete method</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/31/diffs?diff_id=45603&start_sha=bb33205482ea83019b93d1d00fa92c1b8fb1e4dc)
appel_c commented 2025-05-27 16:04:55 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

marked this merge request as ready

marked this merge request as **ready**
appel_c commented 2025-05-27 16:06:32 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed the description

changed the description
appel_c commented 2025-05-27 16:06:32 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

requested review from @wakonig_k, @clark_a, and @hitz_s

requested review from @wakonig_k, @clark_a, and @hitz_s
appel_c commented 2025-05-27 17:26:23 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 44358457 - fix(device-configs): change to relative path for !include syntax

Compare with previous version

added 1 commit <ul><li>44358457 - fix(device-configs): change to relative path for !include syntax</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/31/diffs?diff_id=45607&start_sha=bb72ae4aefec4b7e19f217ae50cd34b1d1f5b8e9)
appel_c commented 2025-05-27 17:31:56 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

MR needs fix for the yaml loader to accept a relative filepaths.

MR needs fix for the yaml loader to accept a relative filepaths.
appel_c commented 2025-06-18 14:23:28 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 11 commits

  • 0d87e958 - 1 commit from branch main
  • c934aa8e - refactor: update configs with optic slit config, machine config
  • 79ead32e - feat(nidaq): ensure nidaq is powered on during on_connected
  • a1433efb - update of test_config to include focusing mirror
  • f038679d - refactor(nidaq): add energy pv from nidaq
  • 718a001a - typo and adding pinhole motors
  • 89cc27a8 - feat: add nidaq_continuous_scan scan
  • bc666dc8 - fix: double timeout for for wait for ScanControlMessage
  • 39adeb72 - test: add test for nidaq continous scan
  • 07d05f94 - fix(nidaq): fix proper handling return of DeviceStatus for complete method
  • 27ff5697 - fix(device-configs): change to relative path for !include syntax

Compare with previous version

added 11 commits <ul><li>0d87e958 - 1 commit from branch <code>main</code></li><li>c934aa8e - refactor: update configs with optic slit config, machine config</li><li>79ead32e - feat(nidaq): ensure nidaq is powered on during on_connected</li><li>a1433efb - update of test_config to include focusing mirror</li><li>f038679d - refactor(nidaq): add energy pv from nidaq</li><li>718a001a - typo and adding pinhole motors</li><li>89cc27a8 - feat: add nidaq_continuous_scan scan</li><li>bc666dc8 - fix: double timeout for for wait for ScanControlMessage</li><li>39adeb72 - test: add test for nidaq continous scan</li><li>07d05f94 - fix(nidaq): fix proper handling return of DeviceStatus for complete method</li><li>27ff5697 - fix(device-configs): change to relative path for !include syntax</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/31/diffs?diff_id=46054&start_sha=443584576815f4a65fd9c11abd9ef07578c82e47)
appel_c commented 2025-06-18 14:27:36 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

resolved all threads

resolved all threads
appel_c (Migrated from gitlab.psi.ch) merged commit into main 2025-06-18 14:28:24 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea celcer_t clark_a debenjak_l divall_e hitz_s lombosi_c nachtegaal perl_d tiefenbacher_s usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/debye_bec#54
Delete Branch "fix/operational_improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?