bec/debye_bec
0
0
Fork 0
Code Issues 9 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Fix/fix camera live mode handling #53

Merged
appel_c merged 4 commits from fix/fix_camera_live_mode_handling into main 2025-05-16 15:16:44 +02:00
Conversation 10 Commits 4 Files Changed 5 +321 -43
appel_c commented 2025-05-09 17:10:11 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Summary

MR to improve the integration of the prosilica and Basler camera at Debye. It adds a base class for cameras at Debye with option to activate/deactivate a live_mode where camera images are streamed to BEC at fixed frequency.

Related issues

Type of changes

  • add base class with live_mode property
  • Throttled emission of data to BEC (1Hz)

Additional notes

We were experiencing issues (most likely network related), once we increased the live_monitoring to frequencies of 5Hz and above. 3 cameras with ~4.5MP, 8bit. The beamline will further investigate the network structure of computers and switches.

## Summary MR to improve the integration of the prosilica and Basler camera at Debye. It adds a base class for cameras at Debye with option to activate/deactivate a live_mode where camera images are streamed to BEC at fixed frequency. ## Related issues - closes #20 - relates to #15 ## Type of changes - add base class with live_mode property - Throttled emission of data to BEC (1Hz) ## Additional notes We were experiencing issues (most likely network related), once we increased the live_monitoring to frequencies of 5Hz and above. 3 cameras with ~4.5MP, 8bit. The beamline will further investigate the network structure of computers and switches.
appel_c commented 2025-05-09 17:10:11 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

assigned to @appel_c

assigned to @appel_c
wakonig_k (Migrated from gitlab.psi.ch) approved these changes 2025-05-09 17:10:11 +02:00
appel_c commented 2025-05-12 08:32:30 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • c5889af5 - test(test-camers): Add unit tests for camera integration of prosilica and basler cameras

Compare with previous version

added 1 commit <ul><li>c5889af5 - test(test-camers): Add unit tests for camera integration of prosilica and basler cameras</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/30/diffs?diff_id=45143&start_sha=9fbb0bd1a7ef492ea725eab30f52e2d5855c9b47)
appel_c commented 2025-05-12 08:36:29 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed the description

changed the description
appel_c commented 2025-05-12 08:37:09 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed the description

changed the description
appel_c commented 2025-05-13 08:06:40 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

marked this merge request as ready

marked this merge request as **ready**
appel_c commented 2025-05-13 08:07:07 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

requested review from @wakonig_k, @clark_a, and @hitz_s

requested review from @wakonig_k, @clark_a, and @hitz_s
wakonig_k commented 2025-05-13 08:21:44 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

lgtm

lgtm
wakonig_k commented 2025-05-13 08:22:18 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

approved this merge request

approved this merge request
appel_c commented 2025-05-16 15:14:18 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 11 commits

  • c5889af5...0c1f41cd - 7 commits from branch main
  • 415c601d - feat(debye-base-cam): introduce base class for cameras at debye
  • ca2cf40d - refactor: refactor basler and prosilica cameras
  • 10b0608d - fix: debug with devices, throttle live_view to 1Hz
  • 665c290a - test(test-camers): Add unit tests for camera integration of prosilica and basler cameras

Compare with previous version

added 11 commits <ul><li>c5889af5...0c1f41cd - 7 commits from branch <code>main</code></li><li>415c601d - feat(debye-base-cam): introduce base class for cameras at debye</li><li>ca2cf40d - refactor: refactor basler and prosilica cameras</li><li>10b0608d - fix: debug with devices, throttle live_view to 1Hz</li><li>665c290a - test(test-camers): Add unit tests for camera integration of prosilica and basler cameras</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/30/diffs?diff_id=45318&start_sha=c5889af5d8e209bb938d0a0ed8e18d347f192658)
appel_c (Migrated from gitlab.psi.ch) scheduled this pull request to auto merge when all checks succeed 2025-05-16 15:14:23 +02:00
appel_c (Migrated from gitlab.psi.ch) merged commit into main 2025-05-16 15:16:44 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
wakonig_k
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea celcer_t clark_a debenjak_l divall_e hitz_s lombosi_c nachtegaal perl_d tiefenbacher_s usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/debye_bec#53
Delete Branch "fix/fix_camera_live_mode_handling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?