bec/debye_bec
0
0
Fork 0
Code Issues 9 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Feat/add mo1bragg angle positioner #52

Merged
appel_c merged 6 commits from feat/add_mo1bragg_angle_positioner into main 2025-05-16 15:05:53 +02:00
Conversation 13 Commits 6 Files Changed 8 +149 -146
appel_c commented 2025-05-09 15:59:03 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Summary

MR to introduce a small wrapper around Mo1BraggPositioner (energy readback), to allow its usage as a motor based on the angle readback. Minor adaption to the Mo1BraggPositioner were done.

Related Issues

Closes #14
relates to #15

Additional comments

  • Tested once again for all xas scan modes at the beamline. So far only xas_simple_scan was tested!
## Summary MR to introduce a small wrapper around `Mo1BraggPositioner` (energy readback), to allow its usage as a motor based on the angle readback. Minor adaption to the `Mo1BraggPositioner` were done. ## Related Issues Closes #14 relates to #15 ## Additional comments - [ ] Tested once again for all xas scan modes at the beamline. So far only xas_simple_scan was tested!
appel_c commented 2025-05-09 15:59:03 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

requested review from @wakonig_k, @perl_d, @clark_a, and @hitz_s

requested review from @wakonig_k, @perl_d, @clark_a, and @hitz_s
appel_c commented 2025-05-09 15:59:03 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

assigned to @appel_c

assigned to @appel_c
clark_a (Migrated from gitlab.psi.ch) approved these changes 2025-05-09 15:59:03 +02:00
appel_c commented 2025-05-09 15:59:10 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

marked this merge request as draft

marked this merge request as **draft**
appel_c commented 2025-05-09 16:26:03 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 3 commits

  • 4d9a062b - tests: fix tests and formatting
  • 87ea95e9 - fix: improve move method of mo1_bragg_devices
  • b3f63f4f - tests(mo1-bragg-angle): add tests for mo1_bragg_angle

Compare with previous version

added 3 commits <ul><li>4d9a062b - tests: fix tests and formatting</li><li>87ea95e9 - fix: improve move method of mo1_bragg_devices</li><li>b3f63f4f - tests(mo1-bragg-angle): add tests for mo1_bragg_angle</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/29/diffs?diff_id=45128&start_sha=c782324065d49d1a6726f496099afad25ac4db36)
appel_c commented 2025-05-09 16:28:25 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed the description

changed the description
appel_c commented 2025-05-09 16:28:37 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed the description

changed the description
appel_c commented 2025-05-12 08:37:39 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

changed the description

changed the description
appel_c commented 2025-05-13 08:06:32 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

marked this merge request as ready

marked this merge request as **ready**
wakonig_k commented 2025-05-13 08:23:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

approved this merge request

approved this merge request
appel_c commented 2025-05-16 15:03:13 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

added 1 commit

  • 0cdad97d - refactor: add mo1_bragg_angle to x01da_test_config

Compare with previous version

added 1 commit <ul><li>0cdad97d - refactor: add mo1_bragg_angle to x01da_test_config</li></ul> [Compare with previous version](/bec/debye_bec/-/merge_requests/29/diffs?diff_id=45314&start_sha=b3f63f4f765ad42e77d12fa9ca1a596b057f4185)
appel_c commented 2025-05-16 15:03:24 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

reset approvals from @wakonig_k by pushing to the branch

reset approvals from @wakonig_k by pushing to the branch
appel_c (Migrated from gitlab.psi.ch) scheduled this pull request to auto merge when all checks succeed 2025-05-16 15:03:52 +02:00
clark_a commented 2025-05-16 15:04:19 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

approved this merge request

approved this merge request
appel_c (Migrated from gitlab.psi.ch) merged commit into main 2025-05-16 15:05:53 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
clark_a
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea celcer_t clark_a debenjak_l divall_e hitz_s lombosi_c nachtegaal perl_d tiefenbacher_s usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/debye_bec#52
Delete Branch "feat/add_mo1bragg_angle_positioner"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?