bec/debye_bec
0
0
Fork 0
Code Issues 9 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

WIP: Draft: fix: add pytest-redis to a list of dev deps #30

Closed
usov_i wants to merge 1 commits from fix-missing-dep into main
pull from: fix-missing-dep
merge into: bec:main
Conversation 3 Commits 1 Files Changed 1 +1 -1
usov_i commented 2024-04-16 10:49:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Fix ModuleNotFoundError in tests by adding a missing pytest-redis dependency.
This exposes a new issue:

Traceback:
/usr/local/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_file_writer_service.py:8: in <module>
    from bec_plugins.services.NIDAQ_writer import NIDAQWriterService
bec_plugins/services/NIDAQ_writer/__init__.py:1: in <module>
    from .NIDAQ_writer import NIDAQWriterService
bec_plugins/services/NIDAQ_writer/NIDAQ_writer.py:12: in <module>
    from bec_lib.file_utils import FileWriterMixin
E   ImportError: cannot import name 'FileWriterMixin' from 'bec_lib.file_utils' (/usr/local/lib/python3.10/site-packages/bec_lib/file_utils.py)

It seems to be related to https://gitlab.psi.ch/bec/bec/-/merge_requests/544. Should FileWriterMixin be replaced by FileWriter? But the corresponding issue states the opposite: https://gitlab.psi.ch/bec/bec/-/issues/244

Fix `ModuleNotFoundError` in tests by adding a missing `pytest-redis` dependency. This exposes a new issue: ``` Traceback: /usr/local/lib/python3.10/importlib/__init__.py:126: in import_module return _bootstrap._gcd_import(name[level:], package, level) tests/test_file_writer_service.py:8: in <module> from bec_plugins.services.NIDAQ_writer import NIDAQWriterService bec_plugins/services/NIDAQ_writer/__init__.py:1: in <module> from .NIDAQ_writer import NIDAQWriterService bec_plugins/services/NIDAQ_writer/NIDAQ_writer.py:12: in <module> from bec_lib.file_utils import FileWriterMixin E ImportError: cannot import name 'FileWriterMixin' from 'bec_lib.file_utils' (/usr/local/lib/python3.10/site-packages/bec_lib/file_utils.py) ``` It seems to be related to https://gitlab.psi.ch/bec/bec/-/merge_requests/544. Should `FileWriterMixin` be replaced by `FileWriter`? But the corresponding issue states the opposite: https://gitlab.psi.ch/bec/bec/-/issues/244
usov_i commented 2024-04-16 10:49:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

requested review from @appel_c and @wakonig_k

requested review from @appel_c and @wakonig_k
wakonig_k commented 2024-04-16 10:54:43 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

https://gitlab.psi.ch/bec/bec/-/merge_requests/572 moves the dependencies from bec_lib to bec_client / bec_ipython_client. Let's wait until this is merged

https://gitlab.psi.ch/bec/bec/-/merge_requests/572 moves the dependencies from bec_lib to bec_client / bec_ipython_client. Let's wait until this is merged
appel_c commented 2024-04-24 11:34:08 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

can be closed -> https://gitlab.psi.ch/bec/debye-bec/-/merge_requests/8

can be closed -> https://gitlab.psi.ch/bec/debye-bec/-/merge_requests/8
appel_c (Migrated from gitlab.psi.ch) closed this pull request 2024-04-24 11:34:08 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea celcer_t clark_a debenjak_l divall_e hitz_s lombosi_c nachtegaal perl_d tiefenbacher_s usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/debye_bec#30
Delete Branch "fix-missing-dep"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?