x12saandClaude Sonnet 5
26df688512
The GUI "Motion Stop" button did not stop the stages when pressed during a sample transfer: - stop_all_axes was not in the Galil controllers' USER_ACCESS, so the foptx stop over RPC could never work (only logged in the GUI server). - fsamroy's controller (port 8084) was never stopped. - an unresolvable device in _stop_device_controller returned silently. The widget now takes hard_stop_device_names (flomni: ftransy, foptx, fsamroy; transfer controller first) and sends stop_all_axes() to each controller from its own thread, so a hung RPC cannot delay the others. Devices are resolved freshly at click time with retries, every outcome is logged and shown in the widget's message label, and positioning mode is restored on the first controller only after all stops were sent. If stop_all_axes is not yet exposed by the device server, the raw XQ#STOP,1 is sent via socket_put_and_receive. The legacy hard_stop_device_name/extra_hard_stop_device_name kwargs still work. Not yet tested on hardware. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Getting Started with Testing using pytest
BEC is using the pytest framework. It can be installed via
pip install pytest
in your python environment.
We note that pytest is part of the optional-dependencies [dev] of the plugin package.
Introduction
Tests in this package should be stored in the tests directory.
We suggest to sort tests of different submodules, i.e. scans or devices in the respective folder structure, and to folow a naming convention of <test_module_name.py>.
It is mandatory for test files to begin with test_ for pytest to discover them.
To run all tests, navigate to the directory of the plugin from the command line, and run the command
pytest -v --random-order ./tests
Note, the python environment needs to be active.
The additional arg -v allows pytest to run in verbose mode which provides more detailed information about the tests being run.
The argument --random-order instructs pytest to run the tests in random order, which is the default in the CI pipelines.
Test examples
Writing tests can be quite specific for the given function. We recommend writing tests as isolated as possible, i.e. try to test single functions instead of full classes. A very useful class to enable isolated testing is MagicMock. In addition, we also recommend to take a look at the How-to guides from pytest.