x12saandClaude Sonnet 5
bbede883b0
PandaBoxOMNY inherited on_pre_scan, which waits forever for the PandA READY event before sending Arm(). After rapid abort/retry cycles the readout thread can be left parked, so READY never arrives and pre_scan_all_devices() hangs with no error (flomni_fermat_scan 11998/12000). on_pre_scan now runs a bounded arm task: wait pre_scan_timeout (default 5 s) for READY; on failure force-reset the box, restart the readout thread (after the old loop finished its cleanup) and try once more, printing and logging a warning with diagnostics. If the second attempt fails too, the status fails with a RuntimeError so the scan aborts. Arm() is sent from the task, not a status callback, so the scan is only released after it went out. A stop is not retried. Also records the outcome and the still-open ophyd_devices race in AGENTS_mirko.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017szgTwuHG65YhjoBGiK2Gj
Getting Started with Testing using pytest
BEC is using the pytest framework. It can be installed via
pip install pytest
in your python environment.
We note that pytest is part of the optional-dependencies [dev] of the plugin package.
Introduction
Tests in this package should be stored in the tests directory.
We suggest to sort tests of different submodules, i.e. scans or devices in the respective folder structure, and to folow a naming convention of <test_module_name.py>.
It is mandatory for test files to begin with test_ for pytest to discover them.
To run all tests, navigate to the directory of the plugin from the command line, and run the command
pytest -v --random-order ./tests
Note, the python environment needs to be active.
The additional arg -v allows pytest to run in verbose mode which provides more detailed information about the tests being run.
The argument --random-order instructs pytest to run the tests in random order, which is the default in the CI pipelines.
Test examples
Writing tests can be quite specific for the given function. We recommend writing tests as isolated as possible, i.e. try to test single functions instead of full classes. A very useful class to enable isolated testing is MagicMock. In addition, we also recommend to take a look at the How-to guides from pytest.