bec/csaxs_bec
0
0
Fork 1
Code Issues 13 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Fix roi_signal after AsyncSignal refactoring #98

Merged
appel_c merged 2 commits from fix/async_signal_refactoring into main 2025-10-22 14:57:07 +02:00
Conversation 1 Commits 2 Files Changed 2 +2 -10
appel_c commented 2025-10-16 14:07:05 +02:00
Owner
Copy Link

PR to adapt the ids-camera to the refactored AsyncSignal

PR to adapt the ids-camera to the refactored AsyncSignal
appel_c added 1 commit 2025-10-16 14:07:06 +02:00
fix(ids-camera): fix roi_signal after AsyncSignal refactoring
Some checks failed
CI for csaxs_bec / test (push) Failing after 29s
Details
CI for csaxs_bec / test (pull_request) Failing after 25s
Details
14d171a886
appel_c requested review from wakonig_k 2025-10-16 14:07:18 +02:00
appel_c self-assigned this 2025-10-16 14:07:25 +02:00
appel_c added 2 commits 2025-10-16 14:09:18 +02:00
fix(ids-camera): fix roi_signal after AsyncSignal refactoring
Some checks failed
CI for csaxs_bec / test (push) Failing after 29s
Details
CI for csaxs_bec / test (pull_request) Failing after 25s
Details
14d171a886
fix(ids-camera): fix roi_signal after AsyncSignal refactoring
Some checks failed
CI for csaxs_bec / test (push) Failing after 27s
Details
CI for csaxs_bec / test (pull_request) Failing after 27s
Details
9d39bac7fa
wakonig_k reviewed 2025-10-21 20:39:49 +02:00
pyproject.toml Outdated
@@ -17,3 +17,3 @@
"bec_lib",
"bec_server",
"ophyd_devices",
"ophyd_devices, #ophyd_devices~=1.28",
wakonig_k commented 2025-10-21 20:39:49 +02:00
Owner
Copy Link

what's the reason for the commented dependency? Was it put there before ophyd_devices was released?

what's the reason for the commented dependency? Was it put there before ophyd_devices was released?
appel_c commented 2025-10-21 20:42:01 +02:00
Author
Owner
Copy Link

yes, also outdated now. Once "https://github.com/bec-project/ophyd_devices/pull/138" is merged, the version needs to be adjusted.

yes, also outdated now. Once "https://github.com/bec-project/ophyd_devices/pull/138" is merged, the version needs to be adjusted.
👍 1
appel_c marked this conversation as resolved
appel_c added 2 commits 2025-10-22 10:48:52 +02:00
fix(ids-camera): fix roi_signal after AsyncSignal refactoring
Some checks failed
CI for csaxs_bec / test (push) Failing after 27s
Details
CI for csaxs_bec / test (pull_request) Failing after 27s
Details
9d39bac7fa
fix(ids-camera): fix roi_signal after AsyncSignal refactoring
Some checks failed
CI for csaxs_bec / test (pull_request) Failing after 3s
Details
CI for csaxs_bec / test (push) Failing after 23s
Details
32d3232008
appel_c added 1 commit 2025-10-22 10:56:03 +02:00
w
All checks were successful
CI for csaxs_bec / test (pull_request) Successful in 1m16s
Details
CI for csaxs_bec / test (push) Successful in 1m19s
Details
7233fb8d35
appel_c merged commit 7233fb8d35 into main 2025-10-22 14:57:07 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
wakonig_k
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea celcer_t debenjak_l diaz divall_e guizar_m holler lombosi_c menzel perl_d stubbs_s usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees appel_c
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#98
Delete Branch "fix/async_signal_refactoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?