fix(omny): remove OMNYTemperatures._set_TEMP_default_setpoints - defaults only in the controllers #345

Merged

holler merged 1 commits from omny-temperature-defaults-in-controllers into main 2026-10-27 20:43:23 +01:00

Conversation 0 Commits 1 Files Changed 2

+8 -63

holler commented 2026-10-27 20:39:37 +01:00

Member

Copy link

Copy source

The default setpoints are stored in the OMNY temperature controllers (EEPROM). The
second copy here could overwrite them; the OMNY service tempcontrol.py (mpc3217)
seeds the :SET PVs from the controllers and writes only real changes.

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01M8zoDvfTY6VYunNtWse9VZ

The default setpoints are stored in the OMNY temperature controllers (EEPROM). The second copy here could overwrite them; the OMNY service tempcontrol.py (mpc3217) seeds the :SET PVs from the controllers and writes only real changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M8zoDvfTY6VYunNtWse9VZ

holler added 1 commit 2026-10-27 20:39:37 +01:00

fix(omny): remove OMNYTemperatures._set_TEMP_default_setpoints - defaults only in the controllers ... bd2448b746

The default setpoints are stored in the OMNY temperature controllers (EEPROM). The
second copy here could overwrite them; the OMNY service tempcontrol.py (mpc3217)
seeds the :SET PVs from the controllers and writes only real changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M8zoDvfTY6VYunNtWse9VZ

holler merged commit bd2448b746 into main 2026-10-27 20:43:23 +01:00

holler deleted branch omny-temperature-defaults-in-controllers 2026-10-27 20:43:23 +01:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

issue::not confirmed

Used if an issue has not yet been confirmed by a developer

issue::not reproducible

Used if an issue is not reproducible

issue::reproducible

Used if a developer was able to reproduce the issue

priority::critical

Should be done as soon as possible

priority::needed

An important update to the code base

priority::nice to have

Not really needed but a good improvement

scope::backend

An issue regarding the backend services

scope::frontend

An issue regarding the user-facing services

stage::in development

This issue is currently being worked on

stage::on hold

Something is blocking the development

stage::pre_release

For issues that have been merged into a pre-release branch and are waiting for their release.

stage::ready for review

For issues that have been resolved and are ready for review

stage::selected for development

This issue has been selected for development but has not been scheduled yet

stage::weekly backlog

This issue has been selected for development for the next development cycle

type::bug

It's a bug!

type::discussion

A discussion is wanted/needed

type::doc

Improvements to the documentation

type::feature

A new feature

type::improvement

Neither a feature nor a bug but an improvement to the code base

type::test

Missing tests or improvements to the test suite

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

acerbo_a (acerbo_a) bec-gitea chen_h2 (chen_h2) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) malu_s (malu_s) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t) zhang_y7 (zhang_y7)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bec/csaxs_bec#345