bec/csaxs_bec
0
0 Fork 3
Code Issues 17 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Flomni fixes 3 #325

Merged
holler merged 5 commits from flomni_fixes_3 into main 2026-09-29 12:44:42 +02:00
Conversation 0 Commits 5 Files Changed 8
+360 -51
holler commented 2026-09-29 12:37:31 +02:00
Member
Copy link
Copy source
No description provided.
holler added 4 commits 2026-09-29 12:37:32 +02:00
docs(flomni): document that PandA stdev needs the analog cap-sensor term
CI for csaxs_bec / test (push) Successful in 3m2s
Details
9ad88f048b 
Cross-checked PandA's raw within-point sample stdev against RT's own
per-point control-loop stdev on S06313. Confirmed the capacitive-sensor
subtraction from the position conversion formula isn't optional for a
noise estimate either: dropping it (interferometer counts alone) gives a
noise estimate ~10x too large and nearly uncorrelated with RT's (r~0.2),
because interf and cap are anti-correlated at r~-0.96 within a point. With
the full formula, PandA and RT's independent stdev estimates agree to
~8-14% and correlate at r~0.98-0.99. Also flags
average_stdeviations_x_st_fzp/_y as a cumulative-mean field, not a
per-point stdev, to avoid it being used by mistake in a future session.
feat(eiger): integrate Eiger 2 Si 500K and make NeXus writer detector-agnostic 88026e8210 
Add the Eiger2Si500K device class (subclassing the shared JungfrauJoch Eiger
base) and make it the active detector in bl_detectors.yaml. The cSAXS NeXus
writer hardcoded "eiger_1_5" everywhere, so switching the active detector
silently dropped the frame-data links (entry_ptycho/data, data_soft, and the
NXdetector group) for any other Eiger model. Resolve the active detector via
a new "eiger" deviceTag instead, and look up per-model NXdetector metadata
(pixel size, sensor description/thickness, orientation) from a small table so
a future model can't reintroduce the same silent failure.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
fix(flomni): adjust heater/X-ray-eye calibration and Galil limit message
CI for csaxs_bec / test (push) Successful in 3m2s
Details
c88256b9f6 
Correct fttrx_in offset for feyex (-2.4 -> -2.3), disable fheater
(enabled: 0) pending further commissioning, and clarify the Galil
"Limit reached." console message to "Limit switch reached."

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
fix(eiger): resolve live preview data channel per detector, not "default" only
CI for csaxs_bec / test (push) Successful in 2m55s
Details
CI for csaxs_bec / test (pull_request) Successful in 2m59s
Details
addffa1299 
The Eiger2 Si 500K's multi-threshold JFJ preview messages key the frame
under a threshold name (e.g. "threshold_1"), not "default" as eiger_1_5/
eiger_9 do -- confirmed by capturing the live JFJ ZMQ preview stream.
_preview_callback hardcoded "default", so it silently dropped every
frame for eiger2_si_500k (251+ "without data" errors in DeviceServer.log,
matching the empty BEC image widget). Now prefers "default" when present
and falls back to whichever single channel the broker actually sent.

Also document the JFJoch Web UI (http://sls-jfjoch-001.psi.ch:8080) and
the Eiger 2 Si 500K detector server address (129.129.122.159) in
bl_detectors.yaml's Eiger section.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
holler added 1 commit 2026-09-29 12:40:40 +02:00
Merge branch 'main' into flomni_fixes_3
CI for csaxs_bec / test (pull_request) Successful in 2m59s
Details
CI for csaxs_bec / test (push) Successful in 3m2s
Details
fd892879b8
holler merged commit 00ddc5f560 into main 2026-09-29 12:44:42 +02:00
holler deleted branch flomni_fixes_3 2026-09-29 12:44:42 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) bec-gitea chen_h2 (chen_h2) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) malu_s (malu_s) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t) zhang_y7 (zhang_y7)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#325