Feat/flomni cont panda data #321

Merged

holler merged 7 commits from feat/flomni_cont_panda_data into main 2026-09-15 15:34:22 +02:00

Conversation 0 Commits 7 Files Changed 9

+2456 -2

holler commented 2026-09-15 15:31:49 +02:00

Member

Copy Link

Copy Source

No description provided.

holler added 7 commits 2026-09-15 15:31:49 +02:00

feat(flomni): add continuous free-running raw-sample mode to PandaBoxOMNY ... 82ecab4c21

Adds an opt-in raw_stream_mode to omny_panda alongside the existing
per-gate averaged burst acquisition, so a burst window can instead be
captured as continuous raw samples plus a detector-gate bit and a
monotonic frame counter for completeness checking. Client-side
coalescing bounds the message rate to the BEC message bus regardless of
PandA's own network-frame batching, and completion uses a settle-based
check since an exact expected sample count isn't predictable for
continuous capture. Defaults to off, preserving today's behavior
exactly; hardware wiring/layout and the raw data schema are documented
under docs/developer/ pending PandA hardware access to configure and
validate against.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

fix(flomni): mask gate_detector_active to its own bit, record confirmed PandA wiring ... 3012cd3154

TTLIN1 (detector trigger) drives both COUNTER1 (frame_counter) and the
PCAP.BITS0 gate-bit capture, confirmed 2026-09-15 against the omny-panda
hardware via TTLIN1.VAL.CAPTURE_WORD?/OFFSET? (PCAP.BITS0, bit 0).

PCAP.BITS0 is a shared 32-bit word -- other captured bit_out signals may
occupy other bit positions of it, so the raw word is not itself a clean
0/1. PandaBoxOMNY now masks gate_detector_active down to bit 0 before
publishing it, instead of trusting the whole word.

Also records the confirmed free-running setup in the developer docs: all
four encoders plus both FMC_IN channels switched to raw Value capture,
CLOCK1 driving continuous PCAP gate/trig, and the initial 100 Hz test
rate.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TsfqLcPWspjJ6vedMyCxco

feat(flomni): split omny_panda into two devices, fix free-running completion check ... f93e591227

Mode A (per-gate aggregate) and Mode B (continuous raw-sample) need
different PandA hardware layouts and can't run simultaneously, so
omny_panda is now two device config entries in ptycho_flomni.yaml:
omny_panda (legacy, kept commented as the restore reference) and
omny_panda_continuous (raw_stream_mode: true, enabled).

Also fixes on_complete for the continuous case. PCAP.CAPTURED can't be
used to detect end-of-acquisition on this layout: CLOCK1 drives
PCAP.gate/trig continuously, so the captured count never naturally
stops increasing while armed -- the previous settle-based wait would
have just run out its timeout. COUNTER1 (frame_counter) instead counts
completed exposures directly (triggered on the detector-trigger's
falling edge), so PandaBoxOMNY now waits for it to reach the exact
expected num_points * frames_per_trigger, mirroring the legacy
exact-count check instead of guessing when capture has "settled".

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TsfqLcPWspjJ6vedMyCxco

config(flomni): switch panda config back to Mode A, record Mode B success ... 6415db0e2d

Mode B (omny_panda_continuous) confirmed working end-to-end against real
PandA hardware on 2026-09-15: correct per-channel raw values, masked
gate_detector_active, and frame_counter-based completion all verified.
Switching back to Mode A (omny_panda) for A/B comparison testing.

Both device entries now stay uncommented in ptycho_flomni.yaml, toggled
via enabled: true/false, rather than commenting/uncommenting blocks --
confirmed a disabled device is an inert placeholder that BEC's device
server never connects to. Speed testing Mode B beyond the initial 100 Hz
is still TODO.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TsfqLcPWspjJ6vedMyCxco

fix(flomni): comment out omny_panda_continuous, enabled:false wasn't enough ... f82fd51a72

Both omny_panda and omny_panda_continuous ended up connected and active
simultaneously against the same physical PandA, even though only
omny_panda was enabled: true -- a device already connected apparently
doesn't disconnect just because a later config reload disables it.

Comment the inactive mode's block out entirely instead of relying on
enabled: false, so BEC never constructs the device object at all. Docs
updated to correct the earlier (wrong) guidance that toggling enabled
alone was sufficient to switch between modes.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TsfqLcPWspjJ6vedMyCxco

config(flomni): swap panda config back to Mode B for speed testing ... 842efeb553

Mode A commented out, omny_panda_continuous active -- next step is
testing above the initial 100 Hz CLOCK1 rate now that Mode B is
confirmed working end-to-end.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TsfqLcPWspjJ6vedMyCxco

docs(flomni): save the confirmed Mode A/Mode B PandA layouts ... acdca82137

Captured 2026-09-15 directly from the omny-panda hardware via
GetState() (ophyd_devices/devices/panda_box/utility_scripts.py), one
per Design: omny.ini (Mode A) and omny_freerun.ini (Mode B). Mode B was
speed-tested successfully up to 20 kHz same day, though the saved
omny_freerun.ini itself reflects CLOCK1.PERIOD=0.0001 (10 kHz) -- flagged
in the setup doc as a discrepancy to double-check rather than assumed
away.

Setup doc updated with the exact save/load commands and a diff summary
of the two layouts' mode-specific differences (PCAP.GATE/TRIG source,
CLOCK1.ENABLE, capture types).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TsfqLcPWspjJ6vedMyCxco

holler merged commit acdca82137 into main 2026-09-15 15:34:22 +02:00

holler deleted branch feat/flomni_cont_panda_data 2026-09-15 15:34:22 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

issue::not confirmed

Used if an issue has not yet been confirmed by a developer

issue::not reproducible

Used if an issue is not reproducible

issue::reproducible

Used if a developer was able to reproduce the issue

priority::critical

Should be done as soon as possible

priority::needed

An important update to the code base

priority::nice to have

Not really needed but a good improvement

scope::backend

An issue regarding the backend services

scope::frontend

An issue regarding the user-facing services

stage::in development

This issue is currently being worked on

stage::on hold

Something is blocking the development

stage::pre_release

For issues that have been merged into a pre-release branch and are waiting for their release.

stage::ready for review

For issues that have been resolved and are ready for review

stage::selected for development

This issue has been selected for development but has not been scheduled yet

stage::weekly backlog

This issue has been selected for development for the next development cycle

type::bug

It's a bug!

type::discussion

A discussion is wanted/needed

type::doc

Improvements to the documentation

type::feature

A new feature

type::improvement

Neither a feature nor a bug but an improvement to the code base

type::test

Missing tests or improvements to the test suite

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

acerbo_a (acerbo_a) bec-gitea chen_h2 (chen_h2) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) malu_s (malu_s) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t) zhang_y7 (zhang_y7)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bec/csaxs_bec#321