Fix/falcon layout xml

Conversation 0 Commits 2 Files Changed 2

+165 -3

2 Commits

Author	SHA1	Message	Date
menzelandClaude Opus 5	b20afd15ea	fix(falcon): name prefix in __init__ so the device server stops dropping it CI for csaxs_bec / test (push) Successful in 1m45s Details CI for csaxs_bec / test (pull_request) Successful in 1m51s Details The __init__ added in the previous commit took (args, *kwargs). The device server builds a device's init kwargs by intersecting the deviceConfig keys with the NAMED parameters of the class signature (bec_server/device_server/devices/devicemanager.py:469-475), so 'prefix' was silently discarded and the Falcon was constructed with an empty prefix. Every signal then pointed at a bare suffix -- HDF1:FilePath_RBV instead of X12SA-SITORO:HDF1:FilePath_RBV -- and instantiation failed with "TimeoutError: Failed to connect to all signals" listing several hundred PVs. That reads like an unreachable IOC, which is how it was diagnosed at the beamline for two hours, while caget from the same host worked perfectly. The signature now names name, prefix, scan_info, device_manager and xml_file_name explicitly, matching DDG1. Two tests guard it: one asserts every deviceConfig key is a named parameter, the other that a configured prefix reaches the signal PV names. Reported-by: Klaus Wakonig <klaus.wakonig@psi.ch> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KLnmUurqcNd1FiDY5M2uZr	2026-09-01 21:49:21 +02:00
menzelandClaude Opus 5	46fe7baa4d	fix(falcon): set the layout the IOC can actually resolve, and verify it CI for csaxs_bec / test (push) Successful in 1m48s Details _initialize_detector_backend put a bare "layout.xml" into the HDF5 plugin. The IOC resolves that relative to its own working directory, where no such file exists: the cSAXS SITORO IOC ships the layout as cfg/layout.xml (installed at /ioc/X12SA-CPCL-FALCONX1/cfg/layout.xml), and that is what the IOC configures at startup. BEC was overwriting a correct value with a broken one on every device init. The failure was silent and badly signposted. An unreadable layout does not raise; the plugin simply refuses to open the output file later, reporting "Error opening file ..., status=-1" with the actual cause buried in XMLErrorMsg_RBV. Because a caget taken before a BEC device reload showed the IOC's own valid value, the two readings disagreed and the layout looked innocent. The default is now cfg/layout.xml, overridable per deployment with an xml_file_name key in deviceConfig ("" selects the plugin's built-in layout), and on_connected reads XMLValid_RBV back and logs an error naming the file and the IOC's message if the layout was rejected. The existing on_connected test asserted the broken value; it now asserts the default constant. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KLnmUurqcNd1FiDY5M2uZr	2026-09-01 15:11:47 +02:00

Author

SHA1

Message

Date

menzelandClaude Opus 5

b20afd15ea

fix(falcon): name prefix in __init__ so the device server stops dropping it

CI for csaxs_bec / test (push) Successful in 1m45s

Details

CI for csaxs_bec / test (pull_request) Successful in 1m51s

Details

The __init__ added in the previous commit took (*args, **kwargs). The device
server builds a device's init kwargs by intersecting the deviceConfig keys
with the NAMED parameters of the class signature
(bec_server/device_server/devices/devicemanager.py:469-475), so 'prefix' was
silently discarded and the Falcon was constructed with an empty prefix.

Every signal then pointed at a bare suffix -- HDF1:FilePath_RBV instead of
X12SA-SITORO:HDF1:FilePath_RBV -- and instantiation failed with
"TimeoutError: Failed to connect to all signals" listing several hundred PVs.
That reads like an unreachable IOC, which is how it was diagnosed at the
beamline for two hours, while caget from the same host worked perfectly.

The signature now names name, prefix, scan_info, device_manager and
xml_file_name explicitly, matching DDG1. Two tests guard it: one asserts every
deviceConfig key is a named parameter, the other that a configured prefix
reaches the signal PV names.

Reported-by: Klaus Wakonig <klaus.wakonig@psi.ch>

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KLnmUurqcNd1FiDY5M2uZr

2026-09-01 21:49:21 +02:00

menzelandClaude Opus 5

46fe7baa4d

fix(falcon): set the layout the IOC can actually resolve, and verify it

CI for csaxs_bec / test (push) Successful in 1m48s

Details

_initialize_detector_backend put a bare "layout.xml" into the HDF5 plugin.
The IOC resolves that relative to its own working directory, where no such
file exists: the cSAXS SITORO IOC ships the layout as cfg/layout.xml
(installed at /ioc/X12SA-CPCL-FALCONX1/cfg/layout.xml), and that is what the
IOC configures at startup. BEC was overwriting a correct value with a broken
one on every device init.

The failure was silent and badly signposted. An unreadable layout does not
raise; the plugin simply refuses to open the output file later, reporting
"Error opening file ..., status=-1" with the actual cause buried in
XMLErrorMsg_RBV. Because a caget taken before a BEC device reload showed the
IOC's own valid value, the two readings disagreed and the layout looked
innocent.

The default is now cfg/layout.xml, overridable per deployment with an
xml_file_name key in deviceConfig ("" selects the plugin's built-in layout),
and on_connected reads XMLValid_RBV back and logs an error naming the file
and the IOC's message if the layout was rejected.

The existing on_connected test asserted the broken value; it now asserts the
default constant.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KLnmUurqcNd1FiDY5M2uZr

2026-09-01 15:11:47 +02:00

Fix/falcon layout xml #313