bec/csaxs_bec
0
0
Fork 2
Code Issues 17 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

fix(lamni,omny): consolidate ad-hoc y/n prompts onto OMNYTools.yesno() #294

Merged
holler merged 2 commits from lamni_fixes into main 2026-08-14 10:43:47 +02:00
Conversation 0 Commits 2 Files Changed 6
+36 -59
2 Commits
Author SHA1 Message Date
x01dcandClaude Sonnet 5 abb933e10d fix(tests): patch input() where yesno() actually calls it
CI for csaxs_bec / test (pull_request) Successful in 1m52s
Details
Read the Docs Deploy Trigger / trigger-rtd-webhook (push) Successful in 2s
Details
CI for csaxs_bec / test (push) Successful in 1m48s
Details 
find_rotation_center()'s y/n prompts now go through OMNYTools.yesno()
(omny_general_tools.py) instead of a raw input() in x_ray_eye_align.py,
but these tests were still patching input() on the old module -- so
the real input() got called under pytest's captured stdin and raised
"reading from stdin while output is captured".

Patch input() on omny_general_tools instead, where yesno() actually
calls it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
 2026-08-14 10:39:12 +02:00
x01dcandClaude Sonnet 5 f0152fe028 fix(lamni,omny): consolidate ad-hoc y/n prompts onto OMNYTools.yesno()
CI for csaxs_bec / test (push) Failing after 1m44s
Details
CI for csaxs_bec / test (pull_request) Failing after 1m44s
Details 
Several confirmation prompts hand-rolled their own input() parsing
instead of using the established yesno() helper, including one
weaker variant (no default, no retry, case-sensitive) and a "Close
the shutter now?" prompt duplicated verbatim four times.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
 2026-08-13 14:46:49 +02:00