bec/csaxs_bec
0
0
Fork 2
Code Issues 17 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(lamni): tolerate transient GUI heartbeat race, fix sample-name prompt order #289

Merged
holler merged 1 commits from fix/lamni-xrayeye-gui-heartbeat-retry into main 2026-07-30 16:10:32 +02:00
Conversation 0 Commits 1 Files Changed 1
+36 -16
holler commented 2026-07-30 16:08:44 +02:00
Member
Copy Link
Copy Source

xrayeye_rotation_center_calibration_isolated/smear_experimental() reproducibly
crashed with "RuntimeError: GUI is not alive" when keep_shutter_open=True, right
after a long blocking device move (interferometer feedback reset, live rotation
sweep). Root cause: bec_widgets' GUI liveness check is a Redis heartbeat with a
10s TTL refreshed from the same Qt event loop that renders live-view frames;
with live view left on continuously, a long blocking move can starve that
heartbeat past its TTL even though the GUI process is still alive. Add
_gui_call_with_retry() and use it at the on_live_view_enabled(True) call sites
that follow these blocking waits, so the transient false negative is retried
instead of crashing the calibration.

Also reorder the sample-name prompt in find_rotation_center() and
find_rotation_center_smear_experimental() to run before the alignment GUI is
shown -- showing the GUI first steals OS focus, forcing the operator to click
back to the terminal to answer the prompt.

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com

xrayeye_rotation_center_calibration_isolated/smear_experimental() reproducibly crashed with "RuntimeError: GUI is not alive" when keep_shutter_open=True, right after a long blocking device move (interferometer feedback reset, live rotation sweep). Root cause: bec_widgets' GUI liveness check is a Redis heartbeat with a 10s TTL refreshed from the same Qt event loop that renders live-view frames; with live view left on continuously, a long blocking move can starve that heartbeat past its TTL even though the GUI process is still alive. Add _gui_call_with_retry() and use it at the on_live_view_enabled(True) call sites that follow these blocking waits, so the transient false negative is retried instead of crashing the calibration. Also reorder the sample-name prompt in find_rotation_center() and find_rotation_center_smear_experimental() to run before the alignment GUI is shown -- showing the GUI first steals OS focus, forcing the operator to click back to the terminal to answer the prompt. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
holler added 1 commit 2026-07-30 16:08:44 +02:00
fix(lamni): tolerate transient GUI heartbeat race, fix sample-name prompt order
CI for csaxs_bec / test (pull_request) Successful in 1m46s
Details
Read the Docs Deploy Trigger / trigger-rtd-webhook (push) Successful in 1s
Details
CI for csaxs_bec / test (push) Successful in 1m46s
Details
fa30e11b3c 
xrayeye_rotation_center_calibration_isolated/smear_experimental() reproducibly
crashed with "RuntimeError: GUI is not alive" when keep_shutter_open=True, right
after a long blocking device move (interferometer feedback reset, live rotation
sweep). Root cause: bec_widgets' GUI liveness check is a Redis heartbeat with a
10s TTL refreshed from the same Qt event loop that renders live-view frames;
with live view left on continuously, a long blocking move can starve that
heartbeat past its TTL even though the GUI process is still alive. Add
_gui_call_with_retry() and use it at the on_live_view_enabled(True) call sites
that follow these blocking waits, so the transient false negative is retried
instead of crashing the calibration.

Also reorder the sample-name prompt in find_rotation_center() and
find_rotation_center_smear_experimental() to run before the alignment GUI is
shown -- showing the GUI first steals OS focus, forcing the operator to click
back to the terminal to answer the prompt.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
holler scheduled this pull request to auto merge when all checks succeed 2026-07-30 16:08:52 +02:00
holler merged commit fa30e11b3c into main 2026-07-30 16:10:32 +02:00
holler deleted branch fix/lamni-xrayeye-gui-heartbeat-retry 2026-07-30 16:10:32 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#289