bec/csaxs_bec
0
0
Fork 2
Code Issues 17 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

perf(LamNI): skip redundant lsamrot rotate-to-0 right after loptics_out() #275

Merged
holler merged 1 commits from lamni_skip_redundant_tomo_rotate_after_loptics_out into main 2026-07-27 12:35:42 +02:00
Conversation 0 Commits 1 Files Changed 1
+17 -2
holler commented 2026-07-27 12:22:03 +02:00
Member
Copy Link
Copy Source

loptics_out() already drives lsamrot to 0 via
RtLamniController.feedback_enable_with_reset() when rtx is enabled, so the
explicit tomo_rotate(0) that followed in find_rotation_center() and
find_rotation_center_smear_experimental() was reissuing a move that had
mostly already happened -- align() already skips this same step (see its
commented-out disable/rotate/re-enable at the equivalent spot).

_tomo_rotate_if_needed() keeps the still-needed pieces: it still corrects
small residual drift from feedback briefly running before
_disable_rt_feedback(), and still performs the move when rtx is disabled
(loptics_out() then never touches lsamrot at all).

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com

loptics_out() already drives lsamrot to 0 via RtLamniController.feedback_enable_with_reset() when rtx is enabled, so the explicit tomo_rotate(0) that followed in find_rotation_center() and find_rotation_center_smear_experimental() was reissuing a move that had mostly already happened -- align() already skips this same step (see its commented-out disable/rotate/re-enable at the equivalent spot). _tomo_rotate_if_needed() keeps the still-needed pieces: it still corrects small residual drift from feedback briefly running before _disable_rt_feedback(), and still performs the move when rtx is disabled (loptics_out() then never touches lsamrot at all). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
holler added 1 commit 2026-07-27 12:22:03 +02:00
perf(LamNI): skip redundant lsamrot rotate-to-0 right after loptics_out()
CI for csaxs_bec / test (push) Successful in 1m55s
Details
CI for csaxs_bec / test (pull_request) Successful in 2m40s
Details
1af89d1dd4 
loptics_out() already drives lsamrot to 0 via
RtLamniController.feedback_enable_with_reset() when rtx is enabled, so the
explicit tomo_rotate(0) that followed in find_rotation_center() and
find_rotation_center_smear_experimental() was reissuing a move that had
mostly already happened -- align() already skips this same step (see its
commented-out disable/rotate/re-enable at the equivalent spot).

_tomo_rotate_if_needed() keeps the still-needed pieces: it still corrects
small residual drift from feedback briefly running before
_disable_rt_feedback(), and still performs the move when rtx is disabled
(loptics_out() then never touches lsamrot at all).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
holler merged commit b7154e665e into main 2026-07-27 12:35:42 +02:00
holler deleted branch lamni_skip_redundant_tomo_rotate_after_loptics_out 2026-07-27 12:35:43 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#275