bec/csaxs_bec
0
0
Fork 1
Code Issues 17 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

feat: add machine config #223

Merged
appel_c merged 1 commits from feature/machine_config into main 2026-06-16 16:36:17 +02:00
Conversation 3 Commits 1 Files Changed 2
+48
wakonig_k commented 2026-06-15 22:59:59 +02:00
Owner
Copy Link
Copy Source

This PR adds a new config file for the machine, including SLS operator messages, ring current, shutter and orbit feedback.

requires https://github.com/bec-project/ophyd_devices/pull/206 to get merged first

This PR adds a new config file for the machine, including SLS operator messages, ring current, shutter and orbit feedback. ~~requires https://github.com/bec-project/ophyd_devices/pull/206 to get merged first~~
wakonig_k requested review from appel_c 2026-06-15 23:01:53 +02:00
wakonig_k requested review from diaz 2026-06-15 23:01:53 +02:00
wakonig_k requested review from holler 2026-06-15 23:01:53 +02:00
wakonig_k requested review from menzel 2026-06-15 23:01:53 +02:00
wakonig_k requested review from perl_d 2026-06-15 23:01:53 +02:00
wakonig_k requested review from wyzula_j 2026-06-15 23:01:53 +02:00
diaz commented 2026-06-16 08:20:21 +02:00
Member
Copy Link
Copy Source

Vey nice, thank you!

Vey nice, thank you!
wakonig_k marked the pull request as ready for review 2026-06-16 09:51:16 +02:00
wakonig_k commented 2026-06-16 09:52:14 +02:00
Author
Owner
Copy Link
Copy Source

the branch in ophyd_devices got merged, so we can proceed with this one. Please note that we will have to redeploy BEC to get the newest version of ophyd_devices as well.

the branch in ophyd_devices got merged, so we can proceed with this one. Please note that we will have to redeploy BEC to get the newest version of ophyd_devices as well.
appel_c added 1 commit 2026-06-16 16:27:14 +02:00
feat: add machine config
CI for csaxs_bec / test (pull_request) Successful in 1m32s
Details
Read the Docs Deploy Trigger / trigger-rtd-webhook (push) Successful in 2s
Details
CI for csaxs_bec / test (push) Successful in 1m30s
Details
00651450d0
appel_c force-pushed feature/machine_config from 3f896ebd39 to 00651450d0 2026-06-16 16:27:14 +02:00 Compare
appel_c approved these changes 2026-06-16 16:36:12 +02:00
appel_c merged commit 00651450d0 into main 2026-06-16 16:36:17 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
diaz
holler
menzel
perl_d
wyzula_j
appel_c
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#223
Delete Branch "feature/machine_config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?