bec/csaxs_bec
0
0
Fork 1
Code Issues 17 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

implement 2 sets of slits in optics hutch #220

Merged
wakonig_k merged 2 commits from update_slits into main 2026-06-08 13:47:47 +02:00
Conversation 2 Commits 2 Files Changed 3
+321 -98
diaz commented 2026-06-08 13:42:02 +02:00
Member
Copy Link
Copy Source

We have implemented the two sets of slits in the optics hutch in BEC. We have also changed the names of the slits motors in the endfront and in the experimental hutch according to a common convention. I have tested motors and checked that they behave as expected, including the pseudo motors for the center and the size of the slits.

We have implemented the two sets of slits in the optics hutch in BEC. We have also changed the names of the slits motors in the endfront and in the experimental hutch according to a common convention. I have tested motors and checked that they behave as expected, including the pseudo motors for the center and the size of the slits.
wakonig_k was assigned by diaz 2026-06-08 13:42:02 +02:00
diaz added 2 commits 2026-06-08 13:42:02 +02:00
implement 2 sets of slits in optics hutch
CI for csaxs_bec / test (push) Successful in 1m36s
Details
a0068a8ecd
change slit names according to convention
CI for csaxs_bec / test (pull_request) Successful in 1m39s
Details
Read the Docs Deploy Trigger / trigger-rtd-webhook (push) Successful in 1s
Details
CI for csaxs_bec / test (push) Successful in 1m41s
Details
f04aacff8c
diaz requested review from appel_c 2026-06-08 13:42:02 +02:00
diaz requested review from menzel 2026-06-08 13:42:02 +02:00
diaz requested review from wakonig_k 2026-06-08 13:42:02 +02:00
wakonig_k approved these changes 2026-06-08 13:46:44 +02:00
wakonig_k left a comment
Owner
Copy Link
Copy Source

looks good to me

looks good to me
wakonig_k merged commit f04aacff8c into main 2026-06-08 13:47:47 +02:00
diaz deleted branch update_slits 2026-06-08 13:50:18 +02:00
diaz commented 2026-06-08 13:50:43 +02:00
Author
Member
Copy Link
Copy Source

OK, great, thank you!
I also saw that I can delete the branch manually afterwards, so I did it

OK, great, thank you! I also saw that I can delete the branch manually afterwards, so I did it
🚀 1
Sign in to join this conversation.
Reviewers
No Reviewers
appel_c
menzel
wakonig_k
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees wakonig_k
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#220
Delete Branch "update_slits"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?