bec/csaxs_bec
0
0
Fork 2
Code Issues 17 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(gui_tools): minimal ring progress bar safeguard in order to not interupt any script using it #216

Merged
holler merged 3 commits from fix/minimal-safeguard-for-progress-update into main 2026-06-20 14:05:15 +02:00
Conversation 0 Commits 3 Files Changed 1
+32 -23
wyzula_j commented 2026-05-22 17:32:18 +02:00
Owner
Copy Link
Copy Source

Summary

Adds a minimal flOMNI progress GUI safeguard so tomo_scan continues if the progress widget is missing, deleted, unreachable, or fails during update.

Also removes flOMNI-specific GUI RPC timeout overrides so progress/GUI calls use the shared BEC Widgets client default timeout.

Additional Comments

This should be merged together with the BEC Widgets RPC logging/timeout PR, which adds the 60s default GUI RPC timeout and improved RPC diagnostics.

Future follow-up: add reconstruction logic for the progress bar when the GUI crashes, is closed, or becomes unresponsive.

## Summary Adds a minimal flOMNI progress GUI safeguard so `tomo_scan` continues if the progress widget is missing, deleted, unreachable, or fails during update. Also removes flOMNI-specific GUI RPC timeout overrides so progress/GUI calls use the shared BEC Widgets client default timeout. ## Additional Comments This should be merged together with the [BEC Widgets RPC logging/timeout PR](https://github.com/bec-project/bec_widgets/pull/1175), which adds the 60s default GUI RPC timeout and improved RPC diagnostics. Future follow-up: add reconstruction logic for the progress bar when the GUI crashes, is closed, or becomes unresponsive.
wyzula_j self-assigned this 2026-05-22 17:32:25 +02:00
wyzula_j requested review from appel_c 2026-05-22 18:10:25 +02:00
wyzula_j requested review from holler 2026-05-22 18:10:25 +02:00
wyzula_j requested review from perl_d 2026-05-22 18:10:26 +02:00
wyzula_j requested review from wakonig_k 2026-05-22 18:10:26 +02:00
wyzula_j added 2 commits 2026-06-17 09:52:37 +02:00
fix(gui_tools): minimal ring progress bar safeguard in order to not interupt any script using it 5624467544
fix(gui_tools): remove all custom gui timeouts
CI for csaxs_bec / test (pull_request) Successful in 1m31s
Details
CI for csaxs_bec / test (push) Successful in 1m34s
Details
d449e01f95
wyzula_j force-pushed fix/minimal-safeguard-for-progress-update from 29594219c2 to d449e01f95 2026-06-17 09:52:37 +02:00 Compare
holler added 1 commit 2026-06-20 14:03:40 +02:00
Merge branch 'main' into fix/minimal-safeguard-for-progress-update
CI for csaxs_bec / test (push) Successful in 1m30s
Details
CI for csaxs_bec / test (pull_request) Successful in 1m30s
Details
dc3860e79b
holler scheduled this pull request to auto merge when all checks succeed 2026-06-20 14:04:17 +02:00
holler merged commit 906e91cc7f into main 2026-06-20 14:05:15 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
holler
appel_c
wakonig_k
perl_d
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees wyzula_j
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#216