bec/csaxs_bec
0
0
Fork 1
Code Issues 17 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Fix Eiger to respect message_severity of JFJ broker status #199

Merged
appel_c merged 2 commits from feat/add-error-handling-to-on-complete-eiger into main 2026-05-18 09:15:48 +02:00
Conversation 1 Commits 2 Files Changed 2
+58 -4
appel_c commented 2026-04-28 10:16:18 +02:00
Owner
Copy Link
Copy Source

This PR adds additional logic to the complete method of the Eiger called at the end of a scan. It now checks more metadata from the JungfrauJoch to improve error handling of backend issues and forward information to the users.

  • Fix tests from Eiger.
This PR adds additional logic to the complete method of the Eiger called at the end of a scan. It now checks more metadata from the JungfrauJoch to improve error handling of backend issues and forward information to the users. - [ ] Fix tests from Eiger.
appel_c requested review from diaz 2026-04-28 10:16:34 +02:00
appel_c requested review from holler 2026-04-28 10:16:34 +02:00
appel_c requested review from menzel 2026-04-28 10:16:34 +02:00
appel_c requested review from wakonig_k 2026-04-28 10:16:34 +02:00
appel_c requested review from wyzula_j 2026-04-28 10:16:34 +02:00
appel_c marked the pull request as work in progress 2026-04-28 10:17:12 +02:00
diaz commented 2026-04-28 16:43:26 +02:00
Member
Copy Link
Copy Source

Thank you, Christian. I cannot judge much here...

Thank you, Christian. I cannot judge much here...
appel_c force-pushed feat/add-error-handling-to-on-complete-eiger from 0f4e8b2867 to 46a8c9fcec 2026-05-05 19:36:12 +02:00 Compare
appel_c added 1 commit 2026-05-18 08:45:39 +02:00
fix(eiger): Fix on_complete from eiger to respect message_severity of JFJ broker status
CI for csaxs_bec / test (pull_request) Failing after 1m27s
Details
CI for csaxs_bec / test (push) Failing after 1m28s
Details
d8ab6d56f3 
Co-authored-by: Copilot <copilot@github.com>
appel_c force-pushed feat/add-error-handling-to-on-complete-eiger from 46a8c9fcec to d8ab6d56f3 2026-05-18 08:45:39 +02:00 Compare
appel_c added 1 commit 2026-05-18 09:14:00 +02:00
test(eiger): fix test with broker
CI for csaxs_bec / test (pull_request) Successful in 1m31s
Details
Read the Docs Deploy Trigger / trigger-rtd-webhook (push) Successful in 2s
Details
CI for csaxs_bec / test (push) Successful in 1m34s
Details
a3b1a4eb2f
appel_c marked the pull request as ready for review 2026-05-18 09:15:38 +02:00
appel_c merged commit a3b1a4eb2f into main 2026-05-18 09:15:48 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
diaz
holler
menzel
wakonig_k
wyzula_j
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#199
Delete Branch "feat/add-error-handling-to-on-complete-eiger"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?