bec/csaxs_bec
0
0
Fork 1
Code Issues 16 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

fix: lamni scan adjustments and refactor #198

Open
holler wants to merge 9 commits from fix/update_lamni into main
pull from: fix/update_lamni
merge into: bec:main
Conversation 0 Commits 9 Files Changed 17
+1528 -872
holler commented 2026-04-22 16:36:42 +02:00
Member
Copy Link
Copy Source
No description provided.
holler force-pushed fix/update_lamni from b7a4576237 to 49def798fc 2026-04-22 16:37:06 +02:00 Compare
holler scheduled this pull request to auto merge when all checks succeed 2026-04-22 16:37:22 +02:00
appel_c added 7 commits 2026-04-22 17:22:03 +02:00
feat(LamNI): migrate X-ray eye alignment from LabView/EPICS to BEC GUI 97ed0b8546 
- Add x_ray_eye_align.py: GUI-based alignment procedure collecting sample
  centre at 8 angles (0-315 deg, full 360 deg rotation), submitting x/y
  offsets to XRayEye widget fit tab, reading sinusoidal fit parameters back
  via omny_xray_gui device signals
- Update gui_tools.py: modernise to current BEC widget API (single new()
  call with object_name, _is_deleted() existence checks, add_ring() progress
  bar API, start/eta time display); add lamnigui_show_xeyealign_fittab()
- Update alignment.py: add read_xray_eye_correction_from_gui(), remove
  obsolete GUI-procedure methods now in x_ray_eye_align.py, fix __init__
  (remove orphaned _reset_init_values() call)
- Update lamni.py: add set_client() call in __init__, add
  xrayeye_alignment_start(keep_shutter_open) and xrayeye_update_frame()
  matching FlOMNI naming convention, import XrayEyeAlignGUI
- Fix LamNIMoveToScanCenter: replace arg_input/arg_bundle_size device-bundle
  pattern with required_kwargs; float dict keys caused msgpack >= 1.0
  ValueError with strict_map_key=True
- Update all lamni_move_to_scan_center() call sites to keyword arguments
- Update docs/user/ptychography/lamni.md: document new commands, remove
  MATLAB/LabView references
documentation update flomni fzp 3da241ca10
refactor 1f209156e3
path corrections a426b61536
refactor 4d27268cc9
fix test 8df8ea9d04
wip for tests
CI for csaxs_bec / test (pull_request) Failing after 2m25s
Details
CI for csaxs_bec / test (push) Failing after 3m3s
Details
e3ea1d1a3f
appel_c force-pushed fix/update_lamni from bd976b32d4 to e3ea1d1a3f 2026-04-22 17:22:03 +02:00 Compare
bec_bl_push-gitea added 1 commit 2026-04-22 17:22:36 +02:00
fix omny docs
CI for csaxs_bec / test (pull_request) Failing after 1m57s
Details
CI for csaxs_bec / test (push) Failing after 2m21s
Details
cd61ea8e57
bec_bl_push-gitea added 1 commit 2026-04-24 13:05:11 +02:00
fix typo
CI for csaxs_bec / test (push) Failing after 1m56s
Details
CI for csaxs_bec / test (pull_request) Failing after 1m56s
Details
af5004154c
Some required checks failed
CI for csaxs_bec / test (push) Failing after 1m56s
Details
CI for csaxs_bec / test (pull_request) Failing after 1m56s
Required
Details
Some required checks were not successful.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/update_lamni:fix/update_lamni
git checkout fix/update_lamni
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#198
Delete Branch "fix/update_lamni"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?