bec/csaxs_bec
0
0
Fork 1
Code Issues 16 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Moving flomni to async signals #167

Merged
appel_c merged 1 commits from fix/flomni_async_readout into main 2026-03-19 11:13:26 +01:00
Conversation 2 Commits 1 Files Changed 3 +211 -134
appel_c commented 2026-03-16 13:09:06 +01:00
Owner
Copy Link

This PR moves the flomni integration to async signals. This allows for a more predictable signal interface, in particular for BEC Widgets. We also used the opportunity to clean up the kickoff / complete logic.

To test, run a scan with flomni and:

  • verify that the progress bar in the CLI works
  • data is written properly (note that it now writes into rt_flyer)
  • open BEC Widgets and add rt_flyer signals to a live plot
This PR moves the flomni integration to async signals. This allows for a more predictable signal interface, in particular for BEC Widgets. We also used the opportunity to clean up the kickoff / complete logic. To test, run a scan with flomni and: * verify that the progress bar in the CLI works * data is written properly (note that it now writes into rt_flyer) * open BEC Widgets and add rt_flyer signals to a live plot
wakonig_k changed title from wip - flomni async readout to Moving flomni to async signals 2026-03-16 15:19:45 +01:00
wakonig_k requested review from holler 2026-03-16 15:21:24 +01:00
holler approved these changes 2026-03-16 16:38:37 +01:00
appel_c commented 2026-03-19 11:11:04 +01:00
Author
Owner
Copy Link

@wakonig_k We merge this as it is for now, and take a better look at tests individually later!

@wakonig_k We merge this as it is for now, and take a better look at tests individually later!
🚀 1
appel_c added 1 commit 2026-03-19 11:11:12 +01:00
fix: flomni async readout
All checks were successful
CI for csaxs_bec / test (push) Successful in 1m58s
Details
CI for csaxs_bec / test (pull_request) Successful in 2m0s
Details
f40fe32317
appel_c force-pushed fix/flomni_async_readout from 94a0094733 to f40fe32317 2026-03-19 11:11:12 +01:00 Compare
appel_c merged commit c97b00cc8c into main 2026-03-19 11:13:26 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
holler
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea celcer_t debenjak_l diaz divall_e guizar_m haghta_s holler lombosi_c menzel perl_d usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#167
Delete Branch "fix/flomni_async_readout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?