bec/csaxs_bec
0
0
Fork 1
Code Issues 16 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Fix MCS card omit callbacks on stop #151

Merged
appel_c merged 2 commits from fix/mcs-card-extra-point-on-stop into main 2026-03-19 11:11:55 +01:00
Conversation 1 Commits 2 Files Changed 2
+14 -4
appel_c commented 2026-03-04 13:42:44 +01:00
Owner
Copy Link
Copy Source

Previously, callbacks were not omitted when stop was called. This resulted in potentially receiving more data then expected, for example if an acquisition was stopped at the end of a scan due to other systems not completing in success. The subsequent erase_all.put(1) call would trigger a reading of a single value on all mca counter channels. The context manager now helps to avoid any updates that arrive after stop was called.

Previously, callbacks were not omitted when stop was called. This resulted in potentially receiving more data then expected, for example if an acquisition was stopped at the end of a scan due to other systems not completing in success. The subsequent `erase_all.put(1)` call would trigger a reading of a single value on all mca counter channels. The context manager now helps to avoid any updates that arrive after stop was called.
appel_c self-assigned this 2026-03-04 13:43:03 +01:00
appel_c requested review from holler 2026-03-04 13:43:12 +01:00
appel_c requested review from menzel 2026-03-04 13:43:12 +01:00
appel_c requested review from perl_d 2026-03-04 13:43:12 +01:00
appel_c requested review from wakonig_k 2026-03-04 13:43:12 +01:00
appel_c added 1 commit 2026-03-13 14:05:45 +01:00
fix(mcs): omit_mca_callbacks if stop is called.
CI for csaxs_bec / test (pull_request) Successful in 1m56s
Details
CI for csaxs_bec / test (push) Successful in 1m57s
Details
80afe2e3f0
appel_c force-pushed fix/mcs-card-extra-point-on-stop from c7db607aab to 80afe2e3f0 2026-03-13 14:05:45 +01:00 Compare
appel_c added 1 commit 2026-03-16 13:41:09 +01:00
fix(mcs): fix _progress_udpate
CI for csaxs_bec / test (push) Successful in 1m56s
Details
CI for csaxs_bec / test (pull_request) Successful in 1m58s
Details
90e0f0f3b3
holler approved these changes 2026-03-17 19:58:00 +01:00
appel_c merged commit d6a4fd37fc into main 2026-03-19 11:11:55 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
perl_d
menzel
wakonig_k
holler
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees appel_c
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#151
Delete Branch "fix/mcs-card-extra-point-on-stop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?