bec/csaxs_bec
0
0
Fork 1
Code Issues 13 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

fix: remove deprecated bl_check #113

Merged
wakonig_k merged 1 commits from fix/remove_bl_check into main 2025-12-08 12:34:58 +01:00
Conversation 2 Commits 1 Files Changed 1 -22
wakonig_k commented 2025-12-05 17:20:12 +01:00
Owner
Copy Link

Will be replaced with the new beamline conditions

Will be replaced with the new beamline conditions
wakonig_k added 1 commit 2025-12-05 17:20:13 +01:00
fix: remove deprecated bl_check
All checks were successful
CI for csaxs_bec / test (pull_request) Successful in 1m15s
Details
CI for csaxs_bec / test (push) Successful in 1m22s
Details
90d2c99c4a
wakonig_k requested review from appel_c 2025-12-05 17:20:29 +01:00
wakonig_k requested review from holler 2025-12-05 17:20:29 +01:00
wakonig_k requested review from wyzula_j 2025-12-05 17:20:29 +01:00
wakonig_k requested review from perl_d 2025-12-05 17:20:36 +01:00
holler approved these changes 2025-12-08 11:35:31 +01:00
holler left a comment
Member
Copy Link

will there be a new concept for bl_check? In principle one could already implement shutter conditions etc.

will there be a new concept for bl_check? In principle one could already implement shutter conditions etc.
wakonig_k commented 2025-12-08 12:34:32 +01:00
Author
Owner
Copy Link

Hi @holler
Yes, there will be a new bl_check which hopefully better synchronizes with GUI users and does not wait for a scan to finish just to realize that the bl condition has failed. The new beamline condition also allows to easily add conditions, e.g. for a signal or motor to be within a certain range. Any readback signal in BEC can be used for this.

For now, the GUI will simply highlight the state if it is in an error or warning state and we will add the additional logic for restarting scans will be added in a follow-up PR.

Hi @holler Yes, there will be a new bl_check which hopefully better synchronizes with GUI users and does not wait for a scan to finish just to realize that the bl condition has failed. The new beamline condition also allows to easily add conditions, e.g. for a signal or motor to be within a certain range. Any readback signal in BEC can be used for this. For now, the GUI will simply highlight the state if it is in an error or warning state and we will add the additional logic for restarting scans will be added in a follow-up PR.
wakonig_k merged commit 90d2c99c4a into main 2025-12-08 12:34:58 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
appel_c
wyzula_j
perl_d
holler
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea celcer_t debenjak_l diaz divall_e guizar_m holler lombosi_c menzel perl_d stubbs_s usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#113
Delete Branch "fix/remove_bl_check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?