fix(x_ray_eye): added 20s rpc timeout to most rpc calls

csaxs_bec/bec_ipython_client/plugins/flomni/gui_tools.py

@@ -17,10 +17,17 @@ class flomniGuiToolsError(Exception):
 
 
 class flomniGuiTools:
+    GUI_RPC_TIMEOUT = 20
 
     def __init__(self):
         self.text_box = None
         self.progressbar = None
+        self.flomni_window = None
+        self.xeyegui = None
+        self.pdf_viewer = None
+        self.idle_text_box = None
+        self.camera_gripper_image = None
+        self.camera_overview_image = None
 
     def set_client(self, client):
         self.client = client
@@ -28,9 +35,10 @@ class flomniGuiTools:
 
     def flomnigui_show_gui(self):
         if "flomni" in self.gui.windows:
+            self.flomni_window = self.gui.windows["flomni"]
             self.gui.flomni.raise_window()
         else:
-            self.gui.new("flomni")
+            self.flomni_window = self.gui.new("flomni", timeout=self.GUI_RPC_TIMEOUT)
 
     def flomnigui_stop_gui(self):
         self.gui.flomni.hide()
@@ -40,9 +48,11 @@ class flomniGuiTools:
 
     def flomnigui_show_xeyealign(self):
         self.flomnigui_show_gui()
-        if self._flomnigui_check_attribute_not_exists("xeyegui"):
+        if self._flomnigui_is_missing("xeyegui"):
             self.flomnigui_remove_all_docks()
-            self.xeyegui = self.gui.flomni.new("XRayEye", object_name="xrayeye")
+            self.xeyegui = self.gui.flomni.new(
+                "XRayEye", object_name="xrayeye", timeout=self.GUI_RPC_TIMEOUT
+            )
         # start live
         if not dev.cam_xeye.live_mode_enabled.get():
             dev.cam_xeye.live_mode_enabled.put(True)
@@ -50,9 +60,11 @@ class flomniGuiTools:
 
     def flomnigui_show_xeyealign_fittab(self):
         self.flomnigui_show_gui()
-        if self._flomnigui_check_attribute_not_exists("xeyegui"):
+        if self._flomnigui_is_missing("xeyegui"):
             self.flomnigui_remove_all_docks()
-            self.xeyegui = self.gui.flomni.new("XRayEye")
+            self.xeyegui = self.gui.flomni.new(
+                "XRayEye", object_name="xrayeye", timeout=self.GUI_RPC_TIMEOUT
+            )
         self.xeyegui.switch_tab("fit")
 
     def _flomnigui_check_attribute_not_exists(self, attribute_name):
@@ -61,31 +73,39 @@ class flomniGuiTools:
                 return False
         return True
 
+    def _flomnigui_is_missing(self, attribute_name):
+        widget = getattr(self, attribute_name, None)
+        if widget is None:
+            return True
+        if hasattr(widget, "_is_deleted") and widget._is_deleted():
+            return True
+        return False
+
     def flomnigui_show_cameras(self):
         self.flomnigui_show_gui()
-        if self._flomnigui_check_attribute_not_exists(
-            "camera_gripper"
-        ) or self._flomnigui_check_attribute_not_exists("camera_overview"):
+        if self._flomnigui_is_missing("camera_gripper_image") or self._flomnigui_is_missing(
+            "camera_overview_image"
+        ):
             self.flomnigui_remove_all_docks()
-            camera_gripper_image = self.gui.flomni.new("Image")
+            self.camera_gripper_image = self.gui.flomni.new("Image")
             if self._flomnicam_check_device_exists(dev.cam_flomni_gripper):
-                camera_gripper_image.image(device="cam_flomni_gripper", signal="preview")
-                camera_gripper_image.lock_aspect_ratio = True
-                camera_gripper_image.enable_fps_monitor = True
-                camera_gripper_image.enable_toolbar = False
-                camera_gripper_image.outer_axes = False
-                camera_gripper_image.inner_axes = False
+                self.camera_gripper_image.image(device="cam_flomni_gripper", signal="preview")
+                self.camera_gripper_image.lock_aspect_ratio = True
+                self.camera_gripper_image.enable_fps_monitor = True
+                self.camera_gripper_image.enable_toolbar = False
+                self.camera_gripper_image.outer_axes = False
+                self.camera_gripper_image.inner_axes = False
                 dev.cam_flomni_gripper.start_live_mode()
             else:
                 print("Cannot open camera_gripper. Device does not exist.")
-            camera_overview_image = self.gui.flomni.new("Image")
+            self.camera_overview_image = self.gui.flomni.new("Image")
             if self._flomnicam_check_device_exists(dev.cam_flomni_overview):
-                camera_overview_image.image(device="cam_flomni_overview", signal="preview")
-                camera_overview_image.lock_aspect_ratio = True
-                camera_overview_image.enable_fps_monitor = True
-                camera_overview_image.enable_toolbar = False
-                camera_overview_image.outer_axes = False
-                camera_overview_image.inner_axes = False
+                self.camera_overview_image.image(device="cam_flomni_overview", signal="preview")
+                self.camera_overview_image.lock_aspect_ratio = True
+                self.camera_overview_image.enable_fps_monitor = True
+                self.camera_overview_image.enable_toolbar = False
+                self.camera_overview_image.outer_axes = False
+                self.camera_overview_image.inner_axes = False
                 dev.cam_flomni_overview.start_live_mode()
             else:
                 print("Cannot open camera_overview. Device does not exist.")
@@ -94,15 +114,21 @@ class flomniGuiTools:
         # dev.cam_flomni_overview.stop_live_mode()
         # dev.cam_flomni_gripper.stop_live_mode()
         # dev.cam_xeye.live_mode = False
-        self.gui.flomni.delete_all()
+        if "flomni" in self.gui.windows:
+            self.gui.flomni.delete_all(timeout=self.GUI_RPC_TIMEOUT)
         self.progressbar = None
         self.text_box = None
+        self.xeyegui = None
+        self.pdf_viewer = None
+        self.idle_text_box = None
+        self.camera_gripper_image = None
+        self.camera_overview_image = None
 
     def flomnigui_idle(self):
         self.flomnigui_show_gui()
-        if self._flomnigui_check_attribute_not_exists("idle_text_box"):
+        if self._flomnigui_is_missing("idle_text_box"):
             self.flomnigui_remove_all_docks()
-            idle_text_box = self.gui.flomni.new("TextBox")
+            self.idle_text_box = self.gui.flomni.new("TextBox")
         text = (
             "<pre>"
             + "██████╗ ███████╗ ██████╗     ███████╗██╗      ██████╗ ███╗   ███╗███╗   ██╗██╗\n"
@@ -113,7 +139,7 @@ class flomniGuiTools:
             + "╚═════╝ ╚══════╝ ╚═════╝     ╚═╝     ╚══════╝ ╚═════╝ ╚═╝     ╚═╝╚═╝  ╚═══╝╚═╝\n"
             + "</pre>"
         )
-        idle_text_box.set_html_text(text)
+        self.idle_text_box.set_html_text(text)
 
     def flomnigui_docs(self, filename: str | None = None):
         import csaxs_bec
@@ -157,7 +183,7 @@ class flomniGuiTools:
         # --- GUI handling (active existence check) ----------------------------
         self.flomnigui_show_gui()
 
-        if self._flomnigui_check_attribute_not_exists("PdfViewerWidget"):
+        if self._flomnigui_is_missing("pdf_viewer"):
             self.flomnigui_remove_all_docks()
             self.pdf_viewer = self.gui.flomni.new(widget="PdfViewerWidget")
 
@@ -175,7 +201,7 @@ class flomniGuiTools:
 
     def flomnigui_show_progress(self):
         self.flomnigui_show_gui()
-        if self._flomnigui_check_attribute_not_exists("progressbar"):
+        if self._flomnigui_is_missing("progressbar"):
             self.flomnigui_remove_all_docks()
             # Add a new dock with a RingProgressBar widget
             self.progressbar = self.gui.flomni.new("RingProgressBar")

csaxs_bec/bec_widgets/widgets/client.py

@@ -38,12 +38,14 @@ class XRayEye(RPCBase):
         None
         """
 
+    @rpc_timeout(20)
     @rpc_call
     def on_live_view_enabled(self, enabled: "bool"):
         """
         None
         """
 
+    @rpc_timeout(20)
     @rpc_call
     def on_motors_enable(self, x_enable: "bool", y_enable: "bool"):
         """
@@ -54,6 +56,7 @@ class XRayEye(RPCBase):
             y_enable(bool): enable y motor controls
         """
 
+    @rpc_timeout(20)
     @rpc_call
     def enable_submit_button(self, enable: "bool"):
         """
@@ -90,12 +93,14 @@ class XRayEye(RPCBase):
         None
         """
 
+    @rpc_timeout(20)
     @rpc_call
     def switch_tab(self, tab: "str"):
         """
         None
         """
 
+    @rpc_timeout(20)
     @rpc_call
     def submit_fit_array(self, fit_array):
         """

csaxs_bec/bec_widgets/widgets/xray_eye/x_ray_eye.py

@@ -4,6 +4,7 @@ from bec_lib import bec_logger
 from bec_lib.endpoints import MessageEndpoints
 from bec_qthemes import material_icon
 from bec_widgets import BECWidget, SafeProperty, SafeSlot
+from bec_widgets.utils.rpc_decorator import rpc_timeout
 from bec_widgets.widgets.plots.image.image import Image
 from bec_widgets.widgets.plots.waveform.waveform import Waveform
 from bec_widgets.widgets.plots.image.setting_widgets.image_roi_tree import ROIPropertyTree
@@ -366,6 +367,7 @@ class XRayEye(BECWidget, QWidget):
         return self.message_line_edit.text()
 
     @user_message.setter
+    @rpc_timeout(20)
     def user_message(self, message: str):
         self.message_line_edit.setText(message)
 
@@ -374,6 +376,7 @@ class XRayEye(BECWidget, QWidget):
         return self.sample_name_line_edit.text()
 
     @sample_name.setter
+    @rpc_timeout(20)
     def sample_name(self, message: str):
         self.sample_name_line_edit.setText(message)
 
@@ -394,6 +397,7 @@ class XRayEye(BECWidget, QWidget):
     ################################################################################
 
     @SafeSlot(str)
+    @rpc_timeout(20)
     def switch_tab(self, tab: str):
         if tab == "fit":
             self.tab_widget.setCurrentIndex(1)
@@ -411,6 +415,7 @@ class XRayEye(BECWidget, QWidget):
         return roi.get_coordinates()
 
     @SafeSlot(bool)
+    @rpc_timeout(20)
     def on_live_view_enabled(self, enabled: bool):
         logger.info(f"Live view is enabled: {enabled}")
         self.live_preview_toggle.blockSignals(True)
@@ -459,6 +464,7 @@ class XRayEye(BECWidget, QWidget):
         self.shutter_toggle.blockSignals(False)
 
     @SafeSlot(bool, bool)
+    @rpc_timeout(20)
     def on_motors_enable(self, x_enable: bool, y_enable: bool):
         """
         Enable/Disable motor controls
@@ -471,6 +477,7 @@ class XRayEye(BECWidget, QWidget):
         self.motor_control_2d.enable_controls_ver(y_enable)
 
     @SafeSlot(bool)
+    @rpc_timeout(20)
     def enable_submit_button(self, enable: bool):
         """
         Enable/disable submit button.
@@ -508,6 +515,7 @@ class XRayEye(BECWidget, QWidget):
         print(f"meta: {meta}")
 
     @SafeSlot()
+    @rpc_timeout(20)
     def submit_fit_array(self, fit_array):
         self.tab_widget.setCurrentIndex(1)
         # self.fix_x.title = " got fit array"