added docs for burst acquisition

csaxs_bec/bec_ipython_client/plugins/LamNI/lamni_optics_mixin.py

@@ -9,9 +9,11 @@ from csaxs_bec.bec_ipython_client.plugins.cSAXS import epics_put, fshclose
 
 # import builtins to avoid linter errors
 dev = builtins.__dict__.get("dev")
-umv = builtins.__dict__.get("umv")
 bec = builtins.__dict__.get("bec")
+scans = builtins.__dict__.get("scans")
 
+def umv(*args):
+    return scans.umv(*args, relative=False)
 
 class LamNIInitError(Exception):
     pass

csaxs_bec/bec_ipython_client/plugins/cSAXS/cSAXSDLPCA200.py

@@ -0,0 +1,443 @@
+"""
+csaxs_dlpca200.py
+=================
+BEC control script for FEMTO DLPCA-200 Variable Gain Low Noise Current Amplifiers
+connected to Galil RIO digital outputs.
+
+DLPCA-200 Remote Control (datasheet page 4)
+-------------------------------------------
+Sub-D pin → function:
+  Pin 10  →  gain LSB   (digital out channel, index 0 in bit-tuple)
+  Pin 11  →  gain MID   (digital out channel, index 1 in bit-tuple)
+  Pin 12  →  gain MSB   (digital out channel, index 2 in bit-tuple)
+  Pin 13  →  coupling   LOW = AC,  HIGH = DC
+  Pin 14  →  speed mode HIGH = low noise (Pin14=1), LOW = high speed (Pin14=0)
+
+Gain truth table (MSB, MID, LSB):
+  0,0,0  →  low-noise: 1e3   high-speed: 1e5
+  0,0,1  →  low-noise: 1e4   high-speed: 1e6
+  0,1,0  →  low-noise: 1e5   high-speed: 1e7
+  0,1,1  →  low-noise: 1e6   high-speed: 1e8
+  1,0,0  →  low-noise: 1e7   high-speed: 1e9
+  1,0,1  →  low-noise: 1e8   high-speed: 1e10
+  1,1,0  →  low-noise: 1e9   high-speed: 1e11
+
+Strategy: prefer low-noise mode (1e3–1e9). For 1e10 and 1e11,
+automatically fall back to high-speed mode.
+
+Device wiring example (galilrioesxbox):
+  bpm4:  Pin10→ch0, Pin11→ch1, Pin12→ch2, Pin13→ch3, Pin14→ch4
+  bim:   Pin10→ch6, Pin11→ch7, Pin12→ch8, Pin13→ch9, Pin14→ch10
+
+Usage examples
+--------------
+  csaxs_amp = cSAXSDLPCA200(client)
+
+  csaxs_amp.set_gain("bpm4", 1e7)          # low-noise if possible
+  csaxs_amp.set_gain("bim",  1e10)         # auto high-speed
+  csaxs_amp.set_coupling("bpm4", "DC")
+  csaxs_amp.set_coupling("bim",  "AC")
+  csaxs_amp.info("bpm4")                   # print current settings
+  csaxs_amp.info_all()                     # print all configured amplifiers
+"""
+
+import builtins
+
+from bec_lib import bec_logger
+
+logger = bec_logger.logger
+
+bec = builtins.__dict__.get("bec")
+dev = builtins.__dict__.get("dev")
+
+
+# ---------------------------------------------------------------------------
+# Amplifier registry
+# ---------------------------------------------------------------------------
+# Each entry describes one DLPCA-200 amplifier connected to a Galil RIO.
+#
+# Keys inside "channels":
+#   gain_lsb   → digital output channel number wired to DLPCA-200 Pin 10
+#   gain_mid   → digital output channel number wired to DLPCA-200 Pin 11
+#   gain_msb   → digital output channel number wired to DLPCA-200 Pin 12
+#   coupling   → digital output channel number wired to DLPCA-200 Pin 13
+#   speed_mode → digital output channel number wired to DLPCA-200 Pin 14
+#
+# To add a new amplifier, simply extend this dict.
+# ---------------------------------------------------------------------------
+DLPCA200_AMPLIFIER_CONFIG: dict[str, dict] = {
+    "bpm4": {
+        "rio_device": "galilrioesxbox",
+        "description": "Beam Position Monitor 4 current amplifier",
+        "channels": {
+            "gain_lsb":   0,   # Pin 10 → Galil ch0
+            "gain_mid":   1,   # Pin 11 → Galil ch1
+            "gain_msb":   2,   # Pin 12 → Galil ch2
+            "coupling":   3,   # Pin 13 → Galil ch3
+            "speed_mode": 4,   # Pin 14 → Galil ch4
+        },
+    },
+    "bim": {
+        "rio_device": "galilrioesxbox",
+        "description": "Beam Intensity Monitor current amplifier",
+        "channels": {
+            "gain_lsb":   6,   # Pin 10 → Galil ch6
+            "gain_mid":   7,   # Pin 11 → Galil ch7
+            "gain_msb":   8,   # Pin 12 → Galil ch8
+            "coupling":   9,   # Pin 13 → Galil ch9
+            "speed_mode": 10,  # Pin 14 → Galil ch10
+        },
+    },
+}
+
+# ---------------------------------------------------------------------------
+# DLPCA-200 gain encoding tables
+# ---------------------------------------------------------------------------
+# (msb, mid, lsb) → gain in V/A
+_GAIN_BITS_LOW_NOISE: dict[tuple, int] = {
+    (0, 0, 0): int(1e3),
+    (0, 0, 1): int(1e4),
+    (0, 1, 0): int(1e5),
+    (0, 1, 1): int(1e6),
+    (1, 0, 0): int(1e7),
+    (1, 0, 1): int(1e8),
+    (1, 1, 0): int(1e9),
+}
+
+_GAIN_BITS_HIGH_SPEED: dict[tuple, int] = {
+    (0, 0, 0): int(1e5),
+    (0, 0, 1): int(1e6),
+    (0, 1, 0): int(1e7),
+    (0, 1, 1): int(1e8),
+    (1, 0, 0): int(1e9),
+    (1, 0, 1): int(1e10),
+    (1, 1, 0): int(1e11),
+}
+
+# Inverse maps: gain → (msb, mid, lsb, low_noise_flag)
+# low_noise_flag: True = Pin14 HIGH, False = Pin14 LOW
+_GAIN_TO_BITS: dict[int, tuple] = {}
+for _bits, _gain in _GAIN_BITS_LOW_NOISE.items():
+    _GAIN_TO_BITS[_gain] = (*_bits, True)
+for _bits, _gain in _GAIN_BITS_HIGH_SPEED.items():
+    if _gain not in _GAIN_TO_BITS:          # low-noise takes priority
+        _GAIN_TO_BITS[_gain] = (*_bits, False)
+
+VALID_GAINS = sorted(_GAIN_TO_BITS.keys())
+
+
+class cSAXSDLPCA200Error(Exception):
+    pass
+
+
+class cSAXSDLPCA200:
+    """
+    Control class for FEMTO DLPCA-200 current amplifiers connected via Galil RIO
+    digital outputs in a BEC environment.
+
+    Supports:
+    - Forward control: set_gain(), set_coupling()
+    - Readback reporting: info(), info_all(), read_settings()
+    - Robust error handling and logging following cSAXS conventions.
+    """
+
+    TAG = "[DLPCA200]"
+
+    def __init__(self, client, config: dict | None = None) -> None:
+        """
+        Parameters
+        ----------
+        client : BEC client object (passed through for future use)
+        config : optional override for DLPCA200_AMPLIFIER_CONFIG.
+                 Falls back to the module-level dict if not provided.
+        """
+        self.client = client
+        self._config: dict[str, dict] = config if config is not None else DLPCA200_AMPLIFIER_CONFIG
+
+    # ------------------------------------------------------------------
+    # Internal helpers
+    # ------------------------------------------------------------------
+
+    def _require_dev(self) -> None:
+        if dev is None:
+            raise cSAXSDLPCA200Error(
+                f"{self.TAG} BEC 'dev' namespace is not available in this session."
+            )
+
+    def _get_cfg(self, amp_name: str) -> dict:
+        """Return config dict for a named amplifier, raising on unknown names."""
+        if amp_name not in self._config:
+            known = ", ".join(sorted(self._config.keys()))
+            raise cSAXSDLPCA200Error(
+                f"{self.TAG} Unknown amplifier '{amp_name}'. Known: [{known}]"
+            )
+        return self._config[amp_name]
+
+    def _get_rio(self, amp_name: str):
+        """Return the live RIO device object for a given amplifier."""
+        self._require_dev()
+        cfg = self._get_cfg(amp_name)
+        rio_name = cfg["rio_device"]
+        try:
+            rio = getattr(dev, rio_name)
+        except AttributeError:
+            raise cSAXSDLPCA200Error(
+                f"{self.TAG} RIO device '{rio_name}' not found in BEC 'dev'."
+            )
+        return rio
+
+    def _dout_get(self, rio, ch: int) -> int:
+        """Read one digital output channel (returns 0 or 1)."""
+        attr = getattr(rio.digital_out, f"ch{ch}")
+        val = attr.get()
+        return int(val)
+
+    def _dout_set(self, rio, ch: int, value: bool) -> None:
+        """Write one digital output channel (True=HIGH=1, False=LOW=0)."""
+        attr = getattr(rio.digital_out, f"ch{ch}")
+        attr.set(value)
+
+    def _read_gain_bits(self, amp_name: str) -> tuple[int, int, int, int]:
+        """
+        Read current gain bit-state from hardware.
+
+        Returns
+        -------
+        (msb, mid, lsb, speed_mode)
+            speed_mode: 1 = low-noise (Pin14=HIGH), 0 = high-speed (Pin14=LOW)
+        """
+        rio = self._get_rio(amp_name)
+        ch = self._get_cfg(amp_name)["channels"]
+        msb        = self._dout_get(rio, ch["gain_msb"])
+        mid        = self._dout_get(rio, ch["gain_mid"])
+        lsb        = self._dout_get(rio, ch["gain_lsb"])
+        speed_mode = self._dout_get(rio, ch["speed_mode"])
+        return msb, mid, lsb, speed_mode
+
+    def _decode_gain(self, msb: int, mid: int, lsb: int, speed_mode: int) -> int | None:
+        """
+        Decode hardware bit-state into gain value (V/A).
+
+        speed_mode=1 → low-noise table, speed_mode=0 → high-speed table.
+        Returns None if the bit combination is not in the table.
+        """
+        bits = (msb, mid, lsb)
+        if speed_mode:
+            return _GAIN_BITS_LOW_NOISE.get(bits)
+        else:
+            return _GAIN_BITS_HIGH_SPEED.get(bits)
+
+    # ------------------------------------------------------------------
+    # Public API – control
+    # ------------------------------------------------------------------
+
+    def set_gain(self, amp_name: str, gain: float, force_high_speed: bool = False) -> None:
+        """
+        Set the transimpedance gain of a DLPCA-200 amplifier.
+
+        The method automatically selects low-noise mode (Pin14=HIGH) whenever
+        the requested gain is achievable in low-noise mode (1e3 – 1e9 V/A).
+        For gains of 1e10 and 1e11 V/A, high-speed mode is used automatically.
+
+        Parameters
+        ----------
+        amp_name : str
+            Amplifier name as defined in DLPCA200_AMPLIFIER_CONFIG (e.g. "bpm4").
+        gain : float or int
+            Target gain in V/A. Must be one of:
+            1e3, 1e4, 1e5, 1e6, 1e7, 1e8, 1e9, 1e10, 1e11.
+        force_high_speed : bool, optional
+            If True, force high-speed (low-noise=False) mode even for gains
+            below 1e10. Default: False (prefer low-noise).
+
+        Examples
+        --------
+        csaxs_amp.set_gain("bpm4", 1e7)          # low-noise mode (automatic)
+        csaxs_amp.set_gain("bim",  1e10)         # high-speed mode (automatic)
+        csaxs_amp.set_gain("bpm4", 1e7, force_high_speed=True)  # override to high-speed
+        """
+        gain_int = int(gain)
+        if gain_int not in _GAIN_TO_BITS:
+            valid_str = ", ".join(f"1e{int(round(__import__('math').log10(g)))}" for g in VALID_GAINS)
+            raise cSAXSDLPCA200Error(
+                f"{self.TAG} Invalid gain {gain:.2e} V/A for '{amp_name}'. "
+                f"Valid values: {valid_str}"
+            )
+
+        msb, mid, lsb, low_noise_preferred = _GAIN_TO_BITS[gain_int]
+
+        # Apply force_high_speed override
+        if force_high_speed and low_noise_preferred:
+            # Check if this gain is achievable in high-speed mode
+            hs_entry = next(
+                (bits for bits, g in _GAIN_BITS_HIGH_SPEED.items() if g == gain_int), None
+            )
+            if hs_entry is None:
+                raise cSAXSDLPCA200Error(
+                    f"{self.TAG} Gain {gain:.2e} V/A is not achievable in high-speed mode "
+                    f"for '{amp_name}'."
+                )
+            msb, mid, lsb = hs_entry
+            low_noise_preferred = False
+
+        use_low_noise = low_noise_preferred and not force_high_speed
+
+        try:
+            rio = self._get_rio(amp_name)
+            ch  = self._get_cfg(amp_name)["channels"]
+
+            self._dout_set(rio, ch["gain_msb"],   bool(msb))
+            self._dout_set(rio, ch["gain_mid"],   bool(mid))
+            self._dout_set(rio, ch["gain_lsb"],   bool(lsb))
+            self._dout_set(rio, ch["speed_mode"], use_low_noise)  # True=low-noise
+
+            mode_str = "low-noise" if use_low_noise else "high-speed"
+            logger.info(
+                f"{self.TAG} [{amp_name}] gain set to {gain_int:.2e} V/A "
+                f"({mode_str} mode, bits MSB={msb} MID={mid} LSB={lsb})"
+            )
+            print(
+                f"{amp_name}: gain → {gain_int:.2e} V/A  [{mode_str}]  "
+                f"(bits: MSB={msb} MID={mid} LSB={lsb})"
+            )
+
+        except cSAXSDLPCA200Error:
+            raise
+        except Exception as exc:
+            raise cSAXSDLPCA200Error(
+                f"{self.TAG} Failed to set gain on '{amp_name}': {exc}"
+            ) from exc
+
+    def set_coupling(self, amp_name: str, coupling: str) -> None:
+        """
+        Set AC or DC coupling on a DLPCA-200 amplifier.
+
+        Parameters
+        ----------
+        amp_name : str
+            Amplifier name (e.g. "bpm4", "bim").
+        coupling : str
+            "AC" or "DC" (case-insensitive).
+            DC → Pin13 HIGH,  AC → Pin13 LOW.
+
+        Examples
+        --------
+        csaxs_amp.set_coupling("bpm4", "DC")
+        csaxs_amp.set_coupling("bim",  "AC")
+        """
+        coupling_upper = coupling.strip().upper()
+        if coupling_upper not in ("AC", "DC"):
+            raise cSAXSDLPCA200Error(
+                f"{self.TAG} Invalid coupling '{coupling}' for '{amp_name}'. "
+                f"Use 'AC' or 'DC'."
+            )
+
+        pin13_high = coupling_upper == "DC"
+
+        try:
+            rio = self._get_rio(amp_name)
+            ch  = self._get_cfg(amp_name)["channels"]
+            self._dout_set(rio, ch["coupling"], pin13_high)
+
+            logger.info(f"{self.TAG} [{amp_name}] coupling set to {coupling_upper}")
+            print(f"{amp_name}: coupling → {coupling_upper}")
+
+        except cSAXSDLPCA200Error:
+            raise
+        except Exception as exc:
+            raise cSAXSDLPCA200Error(
+                f"{self.TAG} Failed to set coupling on '{amp_name}': {exc}"
+            ) from exc
+
+    # ------------------------------------------------------------------
+    # Public API – readback / reporting
+    # ------------------------------------------------------------------
+
+    def read_settings(self, amp_name: str) -> dict:
+        """
+        Read back the current settings from hardware digital outputs.
+
+        Returns
+        -------
+        dict with keys:
+            "amp_name"   : str
+            "gain"       : int or None    – gain in V/A (None if unknown bit pattern)
+            "mode"       : str            – "low-noise" or "high-speed"
+            "coupling"   : str            – "AC" or "DC"
+            "bits"       : dict           – raw bit values {msb, mid, lsb, speed_mode, coupling}
+        """
+        rio = self._get_rio(amp_name)
+        ch  = self._get_cfg(amp_name)["channels"]
+
+        msb        = self._dout_get(rio, ch["gain_msb"])
+        mid        = self._dout_get(rio, ch["gain_mid"])
+        lsb        = self._dout_get(rio, ch["gain_lsb"])
+        speed_mode = self._dout_get(rio, ch["speed_mode"])
+        coupling_bit = self._dout_get(rio, ch["coupling"])
+
+        gain = self._decode_gain(msb, mid, lsb, speed_mode)
+        mode = "low-noise" if speed_mode else "high-speed"
+        coupling = "DC" if coupling_bit else "AC"
+
+        return {
+            "amp_name": amp_name,
+            "gain":     gain,
+            "mode":     mode,
+            "coupling": coupling,
+            "bits": {
+                "msb":        msb,
+                "mid":        mid,
+                "lsb":        lsb,
+                "speed_mode": speed_mode,
+                "coupling":   coupling_bit,
+            },
+        }
+
+    def info(self, amp_name: str) -> None:
+        """
+        Print a plain summary of the current settings for one amplifier.
+
+        Example output
+        --------------
+        Amplifier   : bpm4
+        Description : Beam Position Monitor 4 current amplifier
+        RIO device  : galilrioesxbox
+        Gain        : 1.00e+07 V/A
+        Mode        : low-noise
+        Coupling    : DC
+        Raw bits    : MSB=1 MID=0 LSB=0  speed=1 coup=1
+        """
+        cfg = self._get_cfg(amp_name)
+
+        try:
+            s = self.read_settings(amp_name)
+        except Exception as exc:
+            print(f"{self.TAG} [{amp_name}] Could not read settings: {exc}")
+            return
+
+        gain_str = (
+            f"{s['gain']:.2e} V/A" if s["gain"] is not None else "UNKNOWN (invalid bit pattern)"
+        )
+        bits = s["bits"]
+
+        print(f"  {'Amplifier':<12}: {amp_name}")
+        print(f"  {'Description':<12}: {cfg.get('description', '')}")
+        print(f"  {'RIO device':<12}: {cfg['rio_device']}")
+        print(f"  {'Gain':<12}: {gain_str}")
+        print(f"  {'Mode':<12}: {s['mode']}")
+        print(f"  {'Coupling':<12}: {s['coupling']}")
+        print(f"  {'Raw bits':<12}: MSB={bits['msb']} MID={bits['mid']} LSB={bits['lsb']}  speed={bits['speed_mode']} coup={bits['coupling']}")
+
+    def info_all(self) -> None:
+        """
+        Print a plain summary for ALL configured amplifiers.
+        """
+        print("\nDLPCA-200 Amplifier Status Report")
+        print("-" * 40)
+        for amp_name in sorted(self._config.keys()):
+            self.info(amp_name)
+            print()
+
+    def list_amplifiers(self) -> list[str]:
+        """Return sorted list of configured amplifier names."""
+        return sorted(self._config.keys())

csaxs_bec/bec_ipython_client/plugins/cSAXS/filter_transmission.py

@@ -41,8 +41,10 @@ import builtins
 if builtins.__dict__.get("bec") is not None:
     bec = builtins.__dict__.get("bec")
     dev = builtins.__dict__.get("dev")
-    umv = builtins.__dict__.get("umv")
-    umvr = builtins.__dict__.get("umvr")
+    scans = builtins.__dict__.get("scans")
+
+def umv(*args):
+    return scans.umv(*args, relative=False)
 
 class cSAXSFilterTransmission:
     """

csaxs_bec/bec_ipython_client/plugins/cSAXS/smaract.py

@@ -8,11 +8,14 @@ from bec_lib import bec_logger
 logger = bec_logger.logger
 
 # Pull BEC globals if present
-bec = builtins.__dict__.get("bec")
-dev = builtins.__dict__.get("dev")
-umv = builtins.__dict__.get("umv")
-umvr = builtins.__dict__.get("umvr")
+if builtins.__dict__.get("bec") is not None:
+    bec = builtins.__dict__.get("bec")
+    dev = builtins.__dict__.get("dev")
+    scans = builtins.__dict__.get("scans")
 
+def umv(*args):
+    return scans.umv(*args, relative=False)
+    
 
 class cSAXSInitSmaractStagesError(Exception):
     pass
@@ -383,7 +386,6 @@ class cSAXSInitSmaractStages:
         if not self._yesno("Proceed with the motions listed above?", "y"):
             logger.info("[cSAXS] Motion to initial position aborted by user.")
             return
-
         # --- Execution phase (SIMULTANEOUS MOTION) ---
         if umv is None:
             logger.error("[cSAXS] 'umv' is not available in this session.")

csaxs_bec/bec_ipython_client/plugins/flomni/flomni.py

@@ -22,8 +22,10 @@ logger = bec_logger.logger
 if builtins.__dict__.get("bec") is not None:
     bec = builtins.__dict__.get("bec")
     dev = builtins.__dict__.get("dev")
-    umv = builtins.__dict__.get("umv")
-    umvr = builtins.__dict__.get("umvr")
+    scans = builtins.__dict__.get("scans")
+
+def umv(*args):
+    return scans.umv(*args, relative=False)
 
 
 class FlomniToolsError(Exception):

csaxs_bec/bec_ipython_client/plugins/flomni/gui_tools.py

@@ -7,8 +7,10 @@ from bec_widgets.cli.client import BECDockArea
 if builtins.__dict__.get("bec") is not None:
     bec = builtins.__dict__.get("bec")
     dev = builtins.__dict__.get("dev")
-    umv = builtins.__dict__.get("umv")
-    umvr = builtins.__dict__.get("umvr")
+    scans = builtins.__dict__.get("scans")
+
+def umv(*args):
+    return scans.umv(*args, relative=False)
 
 
 class flomniGuiToolsError(Exception):

csaxs_bec/bec_ipython_client/plugins/flomni/x_ray_eye_align.py

@@ -13,8 +13,10 @@ logger = bec_logger.logger
 # import builtins to avoid linter errors
 bec = builtins.__dict__.get("bec")
 dev = builtins.__dict__.get("dev")
-umv = builtins.__dict__.get("umv")
-umvr = builtins.__dict__.get("umvr")
+scans = builtins.__dict__.get("scans")
+
+def umv(*args):
+    return scans.umv(*args, relative=False)
 
 if TYPE_CHECKING:
     from bec_ipython_client.plugins.flomni import Flomni

csaxs_bec/bec_ipython_client/plugins/omny/gui_tools.py

@@ -7,8 +7,10 @@ from bec_widgets.cli.client import BECDockArea
 if builtins.__dict__.get("bec") is not None:
     bec = builtins.__dict__.get("bec")
     dev = builtins.__dict__.get("dev")
-    umv = builtins.__dict__.get("umv")
-    umvr = builtins.__dict__.get("umvr")
+    scans = builtins.__dict__.get("scans")
+
+def umv(*args):
+    return scans.umv(*args, relative=False)
 
 
 class OMNYGuiToolsError(Exception):

csaxs_bec/bec_ipython_client/plugins/omny/omny.py

@@ -27,9 +27,10 @@ logger = bec_logger.logger
 if builtins.__dict__.get("bec") is not None:
     bec = builtins.__dict__.get("bec")
     dev = builtins.__dict__.get("dev")
-    umv = builtins.__dict__.get("umv")
-    umvr = builtins.__dict__.get("umvr")
+    scans = builtins.__dict__.get("scans")
 
+def umv(*args):
+    return scans.umv(*args, relative=False)
 
 class OMNYInitError(Exception):
     pass

csaxs_bec/bec_ipython_client/plugins/omny/omny_general_tools.py

@@ -16,8 +16,10 @@ from rich.table import Table
 if builtins.__dict__.get("bec") is not None:
     bec = builtins.__dict__.get("bec")
     dev = builtins.__dict__.get("dev")
-    umv = builtins.__dict__.get("umv")
-    umvr = builtins.__dict__.get("umvr")
+    scans = builtins.__dict__.get("scans")
+
+def umv(*args):
+    return scans.umv(*args, relative=False)
 
 
 class OMNYToolsError(Exception):

csaxs_bec/bec_ipython_client/plugins/omny/omny_sample_transfer_mixin.py

@@ -16,8 +16,10 @@ from csaxs_bec.bec_ipython_client.plugins.cSAXS import epics_get, epics_put, fsh
 if builtins.__dict__.get("bec") is not None:
     bec = builtins.__dict__.get("bec")
     dev = builtins.__dict__.get("dev")
-    umv = builtins.__dict__.get("umv")
-    umvr = builtins.__dict__.get("umvr")
+    scans = builtins.__dict__.get("scans")
+
+def umv(*args):
+    return scans.umv(*args, relative=False)
 
 
 class OMNYTransferError(Exception):

csaxs_bec/bec_ipython_client/plugins/omny/x_ray_eye_align.py

@@ -13,8 +13,10 @@ logger = bec_logger.logger
 # import builtins to avoid linter errors
 bec = builtins.__dict__.get("bec")
 dev = builtins.__dict__.get("dev")
-umv = builtins.__dict__.get("umv")
-umvr = builtins.__dict__.get("umvr")
+scans = builtins.__dict__.get("scans")
+
+def umv(*args):
+    return scans.umv(*args, relative=False)
 
 if TYPE_CHECKING:
     from bec_ipython_client.plugins.omny import OMNY

csaxs_bec/bec_ipython_client/startup/post_startup.py

@@ -30,29 +30,74 @@ logger = bec_logger.logger
 
 logger.info("Using the cSAXS startup script.")
 
-# pylint: disable=import-error
-_args = _main_dict["args"]
-
-_session_name = "cSAXS"
-if _args.session.lower() == "lamni":
-    from csaxs_bec.bec_ipython_client.plugins.cSAXS import *
-    from csaxs_bec.bec_ipython_client.plugins.LamNI import *
-
-    _session_name = "LamNI"
-    lamni = LamNI(bec)
-    logger.success("LamNI session loaded.")
-
-elif _args.session.lower() == "csaxs":
-    print("Loading cSAXS session")
-    from csaxs_bec.bec_ipython_client.plugins.cSAXS import *
-
-    logger.success("cSAXS session loaded.")
 
 from csaxs_bec.bec_ipython_client.plugins.tool_box.debug_tools import DebugTools
 
 debug = DebugTools()
 logger.success("Debug tools loaded. Use 'debug' to access them.")
 
+# pylint: disable=import-error
+_args = _main_dict["args"]
+
+_session_name = "cSAXS"
+
+print("Loading cSAXS session")
+from csaxs_bec.bec_ipython_client.plugins.cSAXS.cSAXS import cSAXS
+csaxs = cSAXS(bec)
+logger.success("cSAXS session loaded.")
+
+
+if _args.session.lower() == "lamni":
+    from csaxs_bec.bec_ipython_client.plugins.LamNI import LamNI
+
+    _session_name = "LamNI"
+    lamni = LamNI(bec)
+    logger.success("LamNI session loaded.")
+    print(r"""
+    ██████╗ ███████╗ ██████╗     ██╗      █████╗ ███╗   ███╗███╗   ██╗██╗
+    ██╔══██╗██╔════╝██╔════╝     ██║     ██╔══██╗████╗ ████║████╗  ██║██║
+    ██████╔╝█████╗  ██║          ██║     ███████║██╔████╔██║██╔██╗ ██║██║
+    ██╔══██╗██╔══╝  ██║          ██║     ██╔══██║██║╚██╔╝██║██║╚██╗██║██║
+    ██████╔╝███████╗╚██████╗     ███████╗██║  ██║██║ ╚═╝ ██║██║ ╚████║██║
+    ╚═════╝ ╚══════╝ ╚═════╝     ╚══════╝╚═╝  ╚═╝╚═╝     ╚═╝╚═╝  ╚═══╝╚═╝
+                                                                            
+                                B E C   L a m N I
+    """)
+
+elif _args.session.lower() == "omny":
+    from csaxs_bec.bec_ipython_client.plugins.flomni import OMNY
+
+    _session_name = "OMNY"
+    omny = OMNY(bec)
+    logger.success("OMNY session loaded.")
+    print(r"""
+    ██████╗ ███████╗ ██████╗      ██████╗ ███╗   ███╗███╗   ██╗██╗   ██╗
+    ██╔══██╗██╔════╝██╔════╝     ██╔═══██╗████╗ ████║████╗  ██║╚██╗ ██╔╝
+    ██████╔╝█████╗  ██║          ██║   ██║██╔████╔██║██╔██╗ ██║ ╚████╔╝ 
+    ██╔══██╗██╔══╝  ██║          ██║   ██║██║╚██╔╝██║██║╚██╗██║  ╚██╔╝  
+    ██████╔╝███████╗╚██████╗     ╚██████╔╝██║ ╚═╝ ██║██║ ╚████║   ██║   
+    ╚═════╝ ╚══════╝ ╚═════╝      ╚═════╝ ╚═╝     ╚═╝╚═╝  ╚═══╝   ╚═╝   
+                                                                        
+                                B E C   O M N Y
+    """)
+
+elif _args.session.lower() == "flomni":
+    from csaxs_bec.bec_ipython_client.plugins.flomni import Flomni
+
+    _session_name = "flomni"
+    flomni = Flomni(bec)
+    logger.success("flomni session loaded.")
+    print(r"""
+    ██████╗ ███████╗ ██████╗     ███████╗██╗      ██████╗ ███╗   ███╗███╗   ██╗██╗
+    ██╔══██╗██╔════╝██╔════╝     ██╔════╝██║     ██╔═══██╗████╗ ████║████╗  ██║██║
+    ██████╔╝█████╗  ██║          █████╗  ██║     ██║   ██║██╔████╔██║██╔██╗ ██║██║
+    ██╔══██╗██╔══╝  ██║          ██╔══╝  ██║     ██║   ██║██║╚██╔╝██║██║╚██╗██║██║
+    ██████╔╝███████╗╚██████╗     ██║     ███████╗╚██████╔╝██║ ╚═╝ ██║██║ ╚████║██║
+    ╚═════╝ ╚══════╝ ╚═════╝     ╚═╝     ╚══════╝ ╚═════╝ ╚═╝     ╚═╝╚═╝  ╚═══╝╚═╝
+                                                                                    
+                                B E C   f l O M N I
+    """)
+
 
 # SETUP BEAMLINE INFO
 from bec_ipython_client.plugins.SLS.sls_info import OperatorInfo, SLSInfo

csaxs_bec/device_configs/bl_detectors.yaml

@@ -9,16 +9,27 @@ eiger_1_5:
   readoutPriority: async
   softwareTrigger: False
 
-ids_cam:
-  description: IDS camera for live image acquisition
-  deviceClass: csaxs_bec.devices.ids_cameras.IDSCamera
-  deviceConfig:
-    camera_id: 201
-    bits_per_pixel: 24
-    m_n_colormode: 1
-    live_mode: True
-  onFailure: raise
-  enabled: true
-  readoutPriority: async
-  softwareTrigger: True
+# eiger_9:
+#   description: Eiger 9M detector 
+#   deviceClass: csaxs_bec.devices.jungfraujoch.eiger_9m.Eiger9M
+#   deviceConfig:
+#     detector_distance: 100
+#     beam_center: [0, 0]
+#   onFailure: raise
+#   enabled: true
+#   readoutPriority: async
+#   softwareTrigger: False
+
+# ids_cam:
+#   description: IDS camera for live image acquisition
+#   deviceClass: csaxs_bec.devices.ids_cameras.IDSCamera
+#   deviceConfig:
+#     camera_id: 201
+#     bits_per_pixel: 24
+#     m_n_colormode: 1
+#     live_mode: True
+#   onFailure: raise
+#   enabled: true
+#   readoutPriority: async
+#   softwareTrigger: True
 

csaxs_bec/device_configs/bl_general.yaml

@@ -0,0 +1,25 @@
+############################################################
+##################### EPS ##################################
+############################################################
+x12saEPS:
+  description: X12SA EPS info and control
+  deviceClass: csaxs_bec.devices.epics.eps.EPS
+  deviceConfig: {}
+  enabled: true
+  onFailure: buffer
+  readOnly: false
+  readoutPriority: baseline
+############################################################
+##################### GalilRIO #############################
+############################################################
+
+galilrioesxbox:
+  description: Galil RIO for remote gain switching and slow reading ES XBox
+  deviceClass: csaxs_bec.devices.omny.galil.galil_rio.GalilRIO
+  deviceConfig:
+    host: galilrioesxbox.psi.ch
+  enabled: true
+  onFailure: raise
+  readOnly: false
+  readoutPriority: baseline
+  connectionTimeout: 20

csaxs_bec/device_configs/main.yaml

@@ -1,11 +1,11 @@
 # This is the main configuration file that is
 # commented or uncommented according to the type of experiment
 
-optics:
-  - !include ./bl_optics_hutch.yaml
+# optics:
+#   - !include ./bl_optics_hutch.yaml
 
-frontend:
-  - !include ./bl_frontend.yaml
+# frontend:
+#   - !include ./bl_frontend.yaml
 
 endstation:
   - !include ./bl_endstation.yaml
@@ -16,8 +16,8 @@ detectors:
 #sastt:
 #  - !include ./sastt.yaml
 
-#flomni:
-#  - !include ./ptycho_flomni.yaml
+flomni:
+ - !include ./ptycho_flomni.yaml
 
 #omny:
 #  - !include ./ptycho_omny.yaml

csaxs_bec/device_configs/ptycho_flomni.yaml

@@ -471,7 +471,7 @@ omnyfsh:
 #################### GUI Signals ###########################
 ############################################################
 omny_xray_gui:
-  description: Gui Epics signals
+  description: Gui signals
   deviceClass: csaxs_bec.devices.omny.xray_epics_gui.OMNYXRayEpicsGUI
   deviceConfig: {}
   enabled: true
@@ -486,4 +486,25 @@ calculated_signal:
     compute_method: "def just_rand():\n return 42"
   enabled: true
   readOnly: false
-  readoutPriority: baseline
+  readoutPriority: baseline
+
+############################################################
+#################### OMNY Pandabox #########################
+############################################################
+omny_panda:
+  readoutPriority: async
+  deviceClass: csaxs_bec.devices.panda_box.panda_box_omny.PandaBoxOMNY
+  deviceConfig:
+    host: omny-panda.psi.ch
+    signal_alias:
+      FMC_IN.VAL1.Min: cap_voltage_fzp_y_min
+      FMC_IN.VAL1.Max: cap_voltage_fzp_y_max
+      FMC_IN.VAL1.Mean: cap_voltage_fzp_y_mean
+      FMC_IN.VAL2.Min: cap_voltage_fzp_x_min
+      FMC_IN.VAL2.Max: cap_voltage_fzp_x_max
+      FMC_IN.VAL2.Mean: cap_voltage_fzp_x_mean
+  deviceTags:
+    - detector
+  enabled: true
+  readOnly: false
+  softwareTrigger: false

csaxs_bec/devices/epics/mcs_card/mcs_card_csaxs.py

@@ -317,10 +317,14 @@ class MCSCardCSAXS(PSIDeviceBase, MCSCard):
             old_value: Previous value of the signal.
             value: New value of the signal.
         """
-        scan_done = bool(value == self._num_total_triggers)
-        self.progress.put(value=value, max_value=self._num_total_triggers, done=scan_done)
-        if scan_done:
-            self._scan_done_event.set()
+        try:
+            scan_done = bool(value == self._num_total_triggers)
+            self.progress.put(value=value, max_value=self._num_total_triggers, done=scan_done)
+            if scan_done:
+                self._scan_done_event.set()
+        except Exception:
+            content = traceback.format_exc()
+            logger.info(f"Device {self.name}  error: {content}")
 
     def on_stage(self) -> None:
         """

csaxs_bec/devices/jungfraujoch/README.MD

@@ -0,0 +1,48 @@
+# Overview
+Integration module for Eiger detectors at the cSAXS beamline with JungfrauJoch backend.
+There are currently two supported Eiger detectors:
+- EIGER 1.5M
+- EIGER 9M
+
+This module provides a base integration for both detectors. A short list of useful
+information is also provided below.
+
+## JungfrauJoch Service
+The JungfrauJoch WEB UI is available on http://sls-jfjoch-001:8080. This is an interface
+to the broker which runs on sls-jfjoch-001.psi.ch. The writer service runs on
+xbl-daq-34.psi.ch. Permissions to get access to these machines and run systemctl or
+journalctl commands can be requested with the Infrastructure and Services group in AWI.
+Beamline scientists need to check if they have the necessary permissions to connect
+to these machines and run the commands below.
+
+Useful commands for the broker service on sls-jfjoch-001.psi.ch:
+- sudo systemctl status jfjoch_broker # Check status
+- sudo systemctl start jfjoch_broker # Start service
+- sudo systemctl stop jfjoch_broker # Stop service
+- sudo systemctl restart jfjoch_broker # Restart service
+
+For the writer service on xbl-daq-34.psi.ch:
+- sudo journalctl -u jfjoch_writer -f # streams live logs
+- sudo systemctl status jfjoch_writer # Check status
+- sudo systemctl start jfjoch_writer # Start service
+- sudo systemctl stop jfjoch_writer # Stop service
+- sudo systemctl restart jfjoch_writer # Restart service
+
+More information about the JungfrauJoch and API client can be found at: (https://jungfraujoch.readthedocs.io/en/latest/index.html)
+
+### JungfrauJoch API Client
+A thin wrapper for the JungfrauJoch API client is provided in the [jungfrau_joch_client](./jungfrau_joch_client.py). 
+Details about the specific integration are provided in the code. 
+
+
+## Eiger implementation
+The Eiger detector integration is provided in the [eiger.py](./eiger.py) module. It provides a base integration for both Eiger 1.5M and Eiger 9M detectors.
+Logic specific to each detector is implemented in the respective modules:
+- [eiger_1_5m.py](./eiger_1_5m.py)
+- [eiger_9m.py](./eiger_9m.py)
+
+With the current implementation, the detector initialization should be done by a beamline scientist through the JungfrauJoch WEB UI by choosing the 
+appropriate detector (1.5M or 9M) before loading the device config with BEC. BEC will check upon connecting if the selected detector matches the expected one.
+A preview stream for images is also provided which is forwarded and accessible through the `preview_image` signal.
+
+For more specific details, please check the code documentation. 

csaxs_bec/devices/jungfraujoch/eiger.py

@@ -1,34 +1,23 @@
 """
-Generic integration of JungfrauJoch backend with Eiger detectors
-for the cSAXS beamline at the Swiss Light Source.
 
-The WEB UI is available on http://sls-jfjoch-001:8080
+Integration module for Eiger detectors at the cSAXS beamline with JungfrauJoch backend.
 
-NOTE: this may not be the best place to store this information. It should be migrated to
-beamline documentation for debugging of Eiger & JungfrauJoch.
+A few notes on setup and operation of the Eiger detectors through the JungfrauJoch broker:
 
-The JungfrauJoch server for cSAXS runs on sls-jfjoch-001.psi.ch
-User with sufficient rights may use:
-- sudo systemctl restart jfjoch_broker
-- sudo systemctl status jfjoch_broker
-to check and/or restart the broker for the JungfrauJoch server.
-
-Some extra notes for setting up the detector:
 - If the energy on JFJ is set via DetectorSettings, the variable in DatasetSettings will be ignored
 - Changes in energy may take time,  good to implement logic that only resets energy if needed.
 - For the Eiger, the frame_time_us in DetectorSettings is ignored, only the frame_time_us in
   the DatasetSettings is relevant
 - The bit_depth will be adjusted automatically based on the exp_time. Here, we need to ensure
-  that subsequent triggers properly
-  consider the readout_time of the boards. For Jungfrau detectors, the difference between
-  count_time_us and frame_time_us is the readout_time of the boards. For the Eiger, this needs
-  to be taken into account during the integration.
+  that subsequent triggers properly consider the readout_time of the boards. For the Eiger detectors
+  at cSAXS, a readout time of 20us is configured through the JungfrauJoch deployment config. This
+  setting is sufficiently large for the detectors if they run in parallel mode.
 - beam_center and detector settings are required input arguments, thus, they may be set to wrong
   values for acquisitions to start. Please keep this in mind.
 
 Hardware related notes:
 - If there is an HW issue with the detector, power cycling may help.
-- The sls_detector package is available on console on /sls/X12SA/data/gac-x12sa/erik/micromamba
+- The sls_detector package is available on console on /sls/x12sa/applications/erik/micromamba
     - Run: source setup_9m.sh # Be careful, this connects to the detector, so it should not be
       used during operation
     - Useful commands:
@@ -39,9 +28,6 @@ Hardware related notes:
         - cd power_control_user/
         - ./on
         - ./off
-
-Further information that may be relevant for debugging:
-JungfrauJoch - one needs to connect to the jfj-server (sls-jfjoch-001)
 """
 
 from __future__ import annotations
@@ -84,10 +70,19 @@ class EigerError(Exception):
 
 class Eiger(PSIDeviceBase):
     """
-    Base integration of the Eiger1.5M and Eiger9M at cSAXS. All relevant
+    Base integration of the Eiger1.5M and Eiger9M at cSAXS.
+
+    Args:
+        name (str) : Name of the device
+        detector_name (str): Name of the detector. Supports ["EIGER 9M", "EIGER 8.5M (tmp)", "EIGER 1.5M"]
+        host (str): Hostname of the Jungfrau Joch server.
+        port (int): Port of the Jungfrau Joch server.
+        scan_info (ScanInfo): The scan info to use.
+        device_manager (DeviceManagerDS): The device manager to use.
+        **kwargs: Additional keyword arguments.
     """
 
-    USER_ACCESS = ["detector_distance", "beam_center"]
+    USER_ACCESS = ["set_detector_distance", "set_beam_center"]
 
     file_event = Cpt(FileEventSignal, name="file_event")
     preview_image = Cpt(PreviewSignal, name="preview_image", ndim=2)
@@ -105,23 +100,12 @@ class Eiger(PSIDeviceBase):
         device_manager=None,
         **kwargs,
     ):
-        """
-        Initialize the PSI Device Base class.
-
-        Args:
-            name (str) : Name of the device
-            detector_name (str): Name of the detector. Supports ["EIGER 9M", "EIGER 8.5M (tmp)", "EIGER 1.5M"]
-            host (str): Hostname of the Jungfrau Joch server.
-            port (int): Port of the Jungfrau Joch server.
-            scan_info (ScanInfo): The scan info to use.
-            device_manager (DeviceManagerDS): The device manager to use.
-            **kwargs: Additional keyword arguments.
-        """
         super().__init__(name=name, scan_info=scan_info, device_manager=device_manager, **kwargs)
         self._host = f"{host}:{port}"
         self.jfj_client = JungfrauJochClient(host=self._host, parent=self)
+        # NOTE: fetch this information from JungfrauJochClient during on_connected!
         self.jfj_preview_client = JungfrauJochPreview(
-            url="tcp://129.129.95.114:5400", cb=self.preview_image.put
+            url="tcp://129.129.95.114:5400", cb=self._preview_callback
         )  # IP of sls-jfjoch-001.psi.ch on port 5400 for ZMQ stream
         self.device_manager = device_manager
         self.detector_name = detector_name
@@ -129,53 +113,102 @@ class Eiger(PSIDeviceBase):
         self._beam_center = beam_center
         self._readout_time = readout_time
         self._full_path = ""
+        self._num_triggers = 0
+        self._wait_for_on_complete = 20  # seconds
         if self.device_manager is not None:
             self.device_manager: DeviceManagerDS
 
+    def _preview_callback(self, message: dict) -> None:
+        """
+        Callback method for handling preview messages as received from the JungfrauJoch preview stream.
+        These messages are dictionary dumps as described in the JFJ ZMQ preview stream documentation.
+        (https://jungfraujoch.readthedocs.io/en/latest/ZEROMQ_STREAM.html#preview-stream).
+
+        Args:
+            message (dict): The message received from the preview stream.
+        """
+        if message.get("type", "") == "image":
+            data = message.get("data", {}).get("default", None)
+            if data is None:
+                logger.error(f"Received image message on device {self.name} without data.")
+                return
+            logger.info(f"Received preview image on device {self.name}")
+            self.preview_image.put(data)
+
+    # pylint: disable=missing-function-docstring
     @property
     def detector_distance(self) -> float:
-        """The detector distance in mm."""
         return self._detector_distance
 
     @detector_distance.setter
     def detector_distance(self, value: float) -> None:
-        """Set the detector distance in mm."""
         if value <= 0:
             raise ValueError("Detector distance must be a positive value.")
         self._detector_distance = value
 
+    def set_detector_distance(self, distance: float) -> None:
+        """
+        Set the detector distance in mm.
+
+        Args:
+            distance (float): The detector distance in mm.
+        """
+        self.detector_distance = distance
+
+    # pylint: disable=missing-function-docstring
     @property
     def beam_center(self) -> tuple[float, float]:
-        """The beam center in pixels. (x,y)"""
         return self._beam_center
 
     @beam_center.setter
     def beam_center(self, value: tuple[float, float]) -> None:
-        """Set the beam center in pixels. (x,y)"""
+        if any(coord < 0 for coord in value):
+            raise ValueError("Beam center coordinates must be non-negative.")
         self._beam_center = value
 
-    def on_init(self) -> None:
+    def set_beam_center(self, x: float, y: float) -> None:
         """
-        Called when the device is initialized.
+        Set the beam center coordinates in pixels.
 
-        No siganls are connected at this point,
-        thus should not be set here but in on_connected instead.
+        Args:
+            x (float): The x coordinate of the beam center in pixels.
+            y (float): The y coordinate of the beam center in pixels.
         """
+        self.beam_center = (x, y)
+
+    def on_init(self) -> None:
+        """Hook called during device initialization."""
+
+    # pylint: disable=arguments-differ
+    def wait_for_connection(self, timeout: float = 10) -> None:
+        """
+        Wait for the device to be connected to the JungfrauJoch backend.
+
+        Args:
+            timeout (float): Timeout in seconds to wait for the connection.
+        """
+        self.jfj_client.api.status_get(_request_timeout=timeout)  # If connected, this responds
 
     def on_connected(self) -> None:
         """
+        Hook called after the device is connected to through the device server.
+
         Called after the device is connected and its signals are connected.
-        Default values for signals should be set here.
+        Default values for signals should be set here. Currently, the detector needs to be
+        initialised manually through the WEB UI of JungfrauJoch. Once agreed upon, the automated
+        initialisation can be re-enabled here (code commented below).
         """
+        start_time = time.time()
         logger.debug(f"On connected called for {self.name}")
         self.jfj_client.stop(request_timeout=3)
         # Check which detector is selected
 
         # Get available detectors
         available_detectors = self.jfj_client.api.config_select_detector_get(_request_timeout=5)
+        logger.debug(f"Available detectors {available_detectors}")
         # Get current detector
         current_detector_name = ""
-        if available_detectors.current_id:
+        if available_detectors.current_id is not None:
             detector_selection = [
                 det.description
                 for det in available_detectors.detectors
@@ -190,8 +223,9 @@ class Eiger(PSIDeviceBase):
             raise RuntimeError(
                 f"Detector {self.detector_name} is not in IDLE state, current state: {self.jfj_client.detector_state}. Please initialize the detector in the WEB UI: {self._host}."
             )
-        # TODO - check again once Eiger should be initialized automatically, currently human initialization is expected
-        # # Once the automation should be enabled, we may use here
+
+        # TODO - Currently the initialisation of the detector is done manually through the WEB UI. Once adjusted
+        # this can be automated here again.
         # detector_selection = [
         #     det for det in available_detectors.detectors if det.id == self.detector_name
         # ]
@@ -207,41 +241,51 @@ class Eiger(PSIDeviceBase):
 
         # Setup Detector settings, here we may also set the energy already as this might be time consuming
         settings = DetectorSettings(frame_time_us=int(500), timing=DetectorTiming.TRIGGER)
-        self.jfj_client.set_detector_settings(settings, timeout=10)
+        self.jfj_client.set_detector_settings(settings, timeout=5)
+
         # Set the file writer to the appropriate output for the HDF5 file
         file_writer_settings = FileWriterSettings(overwrite=True, format=FileWriterFormat.NXMXVDS)
         logger.debug(
             f"Setting writer_settings: {yaml.dump(file_writer_settings.to_dict(), indent=4)}"
         )
+
+        # Setup the file writer settings
         self.jfj_client.api.config_file_writer_put(
             file_writer_settings=file_writer_settings, _request_timeout=10
         )
+
         # Start the preview client
         self.jfj_preview_client.connect()
         self.jfj_preview_client.start()
-        logger.info(f"Connected to JungfrauJoch preview stream at {self.jfj_preview_client.url}")
+        logger.info(
+            f"Device {self.name} initialized after {time.time()-start_time:.2f}s. Preview stream connected on url: {self.jfj_preview_client.url}"
+        )
 
     def on_stage(self) -> DeviceStatus | None:
         """
-        Called while staging the device.
-
-        Information about the upcoming scan can be accessed from the scan_info object.
+        Hook called when staging the device. Information about the upcoming scan can be accessed from the scan_info object.
+        scan_msg = self.scan_info.msg
         """
         start_time = time.time()
         scan_msg = self.scan_info.msg
-        # Set acquisition parameter
-        # TODO add check of mono energy, this can then also be passed to DatasetSettings
+
+        # TODO: Check mono energy from device in BEC
+        # Setting incident energy in keV
         incident_energy = 12.0
+        # Setting up exp_time and num_triggers acquisition parameter
         exp_time = scan_msg.scan_parameters.get("exp_time", 0)
-        if exp_time <= self._readout_time:
+        if exp_time <= self._readout_time:  # Exp_time must be at least the readout time
             raise ValueError(
-                f"Receive scan request for scan {scan_msg.scan_name} with exp_time {exp_time}s, which must be larger than the readout time {self._readout_time}s of the detector {self.detector_name}."
+                f"Value error on device {self.name}: Exposure time {exp_time}s is less than readout time {self._readout_time}s."
             )
-        frame_time_us = exp_time  #
-        ntrigger = int(scan_msg.num_points * scan_msg.scan_parameters["frames_per_trigger"])
-        # Fetch file path
+        self._num_triggers = int(
+            scan_msg.num_points * scan_msg.scan_parameters["frames_per_trigger"]
+        )
+
+        # Setting up the full path for file writing
         self._full_path = get_full_path(scan_msg, name=f"{self.name}_master")
         self._full_path = os.path.abspath(os.path.expanduser(self._full_path))
+
         # Inform BEC about upcoming file event
         self.file_event.put(
             file_path=self._full_path,
@@ -249,11 +293,14 @@ class Eiger(PSIDeviceBase):
             successful=False,
             hinted_h5_entries={"data": "entry/data/data"},
         )
+
         # JFJ adds _master.h5 automatically
         path = os.path.relpath(self._full_path, start="/sls/x12sa/data").removesuffix("_master.h5")
+
+        # Create dataset settings for API call.
         data_settings = DatasetSettings(
-            image_time_us=int(frame_time_us * 1e6),  # This is currently ignored
-            ntrigger=ntrigger,
+            image_time_us=int(exp_time * 1e6),
+            ntrigger=self._num_triggers,
             file_prefix=path,
             beam_x_pxl=int(self._beam_center[0]),
             beam_y_pxl=int(self._beam_center[1]),
@@ -261,11 +308,15 @@ class Eiger(PSIDeviceBase):
             incident_energy_ke_v=incident_energy,
         )
         logger.debug(f"Setting data_settings: {yaml.dump(data_settings.to_dict(), indent=4)}")
-        prep_time = start_time - time.time()
-        logger.debug(f"Prepared information for eiger to start acquisition in {prep_time:.2f}s")
-        self.jfj_client.wait_for_idle(timeout=10, request_timeout=10)  # Ensure we are in IDLE state
+        prep_time = time.time()
+        self.jfj_client.wait_for_idle(timeout=10)  # Ensure we are in IDLE state
         self.jfj_client.start(settings=data_settings)  # Takes around ~0.6s
-        logger.debug(f"Wait for IDLE and start call took {time.time()-start_time-prep_time:.2f}s")
+
+        # Time the stage process
+        logger.info(
+            f"Device {self.name} staged for scan. Time spent {time.time()-start_time:.2f}s,"
+            f" with {time.time()-prep_time:.2f}s spent with communication to JungfrauJoch."
+        )
 
     def on_unstage(self) -> DeviceStatus:
         """Called while unstaging the device."""
@@ -278,7 +329,9 @@ class Eiger(PSIDeviceBase):
 
     def _file_event_callback(self, status: DeviceStatus) -> None:
         """Callback to update the file_event signal when the acquisition is done."""
-        logger.info(f"Acquisition done callback called for {self.name} for status {status.success}")
+        logger.debug(
+            f"File event callback on complete status for device {self.name}: done={status.done}, successful={status.success}"
+        )
         self.file_event.put(
             file_path=self._full_path,
             done=status.done,
@@ -287,19 +340,44 @@ class Eiger(PSIDeviceBase):
         )
 
     def on_complete(self) -> DeviceStatus:
-        """Called to inquire if a device has completed a scans."""
+        """
+        Called at the end of the scan. The method should implement an asynchronous wait for the
+        device to complete the acquisition. A callback to update the file_event signal is
+        attached that resolves the file event when the acquisition is done.
+
+        Returns:
+            DeviceStatus: The status object representing the completion of the acquisition.
+        """
 
         def wait_for_complete():
             start_time = time.time()
-            timeout = 10
-            for _ in range(timeout):
-                if self.jfj_client.wait_for_idle(timeout=1, request_timeout=10):
+            # NOTE: This adjust the time (s) that should be waited for completion of the scan.
+            timeout = self._wait_for_on_complete
+            while time.time() - start_time < timeout:
+                if self.jfj_client.wait_for_idle(timeout=1, raise_on_timeout=False):
+                    # TODO: Once available, add check for
+                    statistics: MeasurementStatistics = (
+                        self.jfj_client.api.statistics_data_collection_get(_request_timeout=5)
+                    )
+                    if statistics.images_collected < self._num_triggers:
+                        raise EigerError(
+                            f"Device {self.name} acquisition incomplete. "
+                            f"Expected {self._num_triggers} triggers, "
+                            f"but only {statistics.images_collected} were collected."
+                        )
                     return
+                logger.info(
+                    f"Waiting for device {self.name} to finish complete, time elapsed: "
+                    f"{time.time() - start_time}."
+                )
             statistics: MeasurementStatistics = self.jfj_client.api.statistics_data_collection_get(
                 _request_timeout=5
             )
+            broker_status = self.jfj_client.jfj_status
             raise TimeoutError(
-                f"Timeout after waiting for detector {self.name} to complete for {time.time()-start_time:.2f}s, measurement statistics: {yaml.dump(statistics.to_dict(), indent=4)}"
+                f"Timeout after waiting for device {self.name} to complete for {time.time()-start_time:.2f}s \n \n"
+                f"Broker status: \n{yaml.dump(broker_status.to_dict(), indent=4)} \n \n"
+                f"Measurement statistics: \n{yaml.dump(statistics.to_dict(), indent=4)}"
             )
 
         status = self.task_handler.submit_task(wait_for_complete, run=True)
@@ -312,7 +390,11 @@ class Eiger(PSIDeviceBase):
 
     def on_stop(self) -> None:
         """Called when the device is stopped."""
-        self.jfj_client.stop(
-            request_timeout=0.5
-        )  # Call should not block more than 0.5 seconds to stop all devices...
+        self.jfj_client.stop(request_timeout=0.5)
         self.task_handler.shutdown()
+
+    def on_destroy(self):
+        """Called when the device is destroyed."""
+        self.jfj_preview_client.stop()
+        self.on_stop()
+        return super().on_destroy()

csaxs_bec/devices/jungfraujoch/eiger_9m.py

@@ -21,18 +21,18 @@ if TYPE_CHECKING:  # pragma no cover
     from bec_server.device_server.device_server import DeviceManagerDS
 
 EIGER9M_READOUT_TIME_US = 500e-6  # 500 microseconds in s
-DETECTOR_NAME = "EIGER 8.5M (tmp)"  # "EIGER 9M""
+DETECTOR_NAME = "EIGER 9M"  # "EIGER 9M""
 
 
 # pylint:disable=invalid-name
 class Eiger9M(Eiger):
     """
-    Eiger 1.5M specific integration for the in-vaccum Eiger.
+    EIGER 9M specific integration for the in-vaccum Eiger.
 
     The logic implemented here is coupled to the DelayGenerator integration,
     repsonsible for the global triggering of all devices through a single Trigger logic.
     Please check the eiger.py class for more details about the integration of relevant backend
-    services. The detector_name must be set to "EIGER 1.5M:
+    services. The detector_name must be set to "EIGER 9M":
     """
 
     USER_ACCESS = Eiger.USER_ACCESS + []  # Add more user_access methods here.

csaxs_bec/devices/jungfraujoch/jungfrau_joch_client.py

@@ -1,13 +1,15 @@
-"""Module with client interface for the Jungfrau Joch detector API"""
+"""Module with a thin client wrapper around the Jungfrau Joch detector API"""
 
 from __future__ import annotations
 
 import enum
+import threading
 import time
 import traceback
 from typing import TYPE_CHECKING
 
 import requests
+import yaml
 from bec_lib.logger import bec_logger
 from jfjoch_client.api.default_api import DefaultApi
 from jfjoch_client.api_client import ApiClient
@@ -18,7 +20,7 @@ from jfjoch_client.models.detector_settings import DetectorSettings
 
 logger = bec_logger.logger
 
-if TYPE_CHECKING:
+if TYPE_CHECKING:  # pragma: no cover
     from ophyd import Device
 
 
@@ -29,7 +31,10 @@ class JungfrauJochClientError(Exception):
 
 
 class DetectorState(str, enum.Enum):
-    """Possible Detector states for Jungfrau Joch detector"""
+    """
+    Enum states of the BrokerStatus state. The pydantic model validates in runtime,
+    thus we keep the possible states here for a convenient overview and access.
+    """
 
     INACTIVE = "Inactive"
     IDLE = "Idle"
@@ -40,13 +45,15 @@ class DetectorState(str, enum.Enum):
 
 
 class JungfrauJochClient:
-    """Thin wrapper around the Jungfrau Joch API client.
+    """
+    Jungfrau Joch API client wrapper. It provides a thin wrapper methods around the API client,
+    that allow to connect, initialise, wait for state changes, set settings, start and stop
+    acquisitions.
 
-    sudo systemctl restart jfjoch_broker
-    sudo systemctl status jfjoch_broker
-
-    It looks as if the detector is not being stopped properly.
-    One module remains running, how can we restart the detector?
+    Args:
+        host (str): Hostname of the Jungfrau Joch broker service.
+                    Default is "http://sls-jfjoch-001:8080"
+        parent (Device, optional): Parent ophyd device, used for logging purposes.
     """
 
     def __init__(
@@ -59,50 +66,63 @@ class JungfrauJochClient:
         self._parent_name = parent.name if parent else self.__class__.__name__
 
     @property
-    def jjf_state(self) -> BrokerStatus:
-        """Get the status of JungfrauJoch"""
+    def jfj_status(self) -> BrokerStatus:
+        """Broker status of JungfrauJoch."""
         response = self.api.status_get()
         return BrokerStatus(**response.to_dict())
 
+    # pylint: disable=missing-function-docstring
     @property
     def initialised(self) -> bool:
-        """Check if jfj is connected and ready to receive commands"""
         return self._initialised
 
     @initialised.setter
     def initialised(self, value: bool) -> None:
-        """Set the connected status"""
         self._initialised = value
 
-    # TODO this is not correct, as it may be that the state in INACTIVE. Models are not in sync...
-    # REMOVE all model enums as most of the validation takes place in the Pydantic models, i.e. BrokerStatus here..
+    # pylint: disable=missing-function-docstring
     @property
     def detector_state(self) -> DetectorState:
-        """Get the status of JungfrauJoch"""
-        return DetectorState(self.jjf_state.state)
+        return DetectorState(self.jfj_status.state)
 
-    def connect_and_initialise(self, timeout: int = 10, **kwargs) -> None:
-        """Check if JungfrauJoch is connected and ready to receive commands"""
+    def connect_and_initialise(self, timeout: int = 10) -> None:
+        """
+        Connect and initialise the JungfrauJoch detector. The detector must be in
+        IDLE state to become initialised. This is a blocking call, the timeout parameter
+        will be passed to the HTTP requests timeout method of the wait_for_idle method.
+
+        Args:
+            timeout (int): Timeout in seconds for the initialisation and waiting for IDLE state.
+        """
         status = self.detector_state
+        # TODO: #135 Check if the detector has to be in INACTIVE state before initialisation
         if status != DetectorState.IDLE:
-            self.api.initialize_post()  # This is a blocking call....
-            self.wait_for_idle(timeout, request_timeout=timeout)  # Blocking call
+            self.api.initialize_post()
+            self.wait_for_idle(timeout)
         self.initialised = True
 
     def set_detector_settings(self, settings: dict | DetectorSettings, timeout: int = 10) -> None:
-        """Set the detector settings. JungfrauJoch must be in IDLE, Error or Inactive state.
-        Note, the full settings have to be provided, otherwise the settings will be overwritten with default values.
+        """
+        Set the detector settings. The state of JungfrauJoch must be in IDLE,
+        Error or Inactive state. Please note: a full set of setttings has to be provided,
+        otherwise the settings will be overwritten with default values.
 
         Args:
             settings (dict): dictionary of settings
+            timeout (int): Timeout in seconds for the HTTP request to set the settings.
         """
         state = self.detector_state
         if state not in [DetectorState.IDLE, DetectorState.ERROR, DetectorState.INACTIVE]:
+            logger.info(
+                f"JungfrauJoch backend fo device {self._parent_name} is not in IDLE state,"
+                " waiting 1s before retrying..."
+            )
             time.sleep(1)  # Give the detector 1s to become IDLE, retry
             state = self.detector_state
             if state not in [DetectorState.IDLE, DetectorState.ERROR, DetectorState.INACTIVE]:
                 raise JungfrauJochClientError(
-                    f"Error in {self._parent_name}. Detector must be in IDLE, ERROR or INACTIVE state to set settings. Current state: {state}"
+                    f"Error on {self._parent_name}. Detector must be in IDLE, ERROR or INACTIVE"
+                    " state to set settings. Current state: {state}"
                 )
 
         if isinstance(settings, dict):
@@ -110,28 +130,36 @@ class JungfrauJochClient:
         try:
             self.api.config_detector_put(detector_settings=settings, _request_timeout=timeout)
         except requests.exceptions.Timeout:
-            raise TimeoutError(f"Timeout while setting detector settings for {self._parent_name}")
+            raise TimeoutError(
+                f"Timeout on device {self._parent_name} while setting detector settings:\n "
+                f"{yaml.dump(settings, indent=4)}."
+            )
         except Exception:
             content = traceback.format_exc()
+            logger.error(
+                f"Error on device {self._parent_name} while setting detector settings:\n "
+                f"{yaml.dump(settings, indent=4)}. Error traceback: {content}"
+            )
             raise JungfrauJochClientError(
-                f"Error while setting detector settings for {self._parent_name}: {content}"
+                f"Error on device {self._parent_name} while setting detector settings:\n "
+                f"{yaml.dump(settings, indent=4)}. Full traceback: {content}."
             )
 
     def start(self, settings: dict | DatasetSettings, request_timeout: float = 10) -> None:
-        """Start the mesaurement. DatasetSettings must be provided, and JungfrauJoch must be in IDLE state.
-        The method call is blocking and JungfrauJoch will be ready to measure after the call resolves.
+        """
+        Start the acquisition with the provided dataset settings.
+        The detector must be in IDLE state. Settings must always provide a full set of
+        parameters, missing parameters will be set to default values.
 
         Args:
-            settings (dict): dictionary of settings
-
-        Please check the DataSettings class for the available settings. Minimum required settings are
-        beam_x_pxl, beam_y_pxl, detector_distance_mm, incident_energy_keV.
-
+            settings (dict | DatasetSettings): Dataset settings to start the acquisition with.
+            request_timeout (float): Timeout in sec for the HTTP request to start the acquisition.
         """
         state = self.detector_state
         if state != DetectorState.IDLE:
             raise JungfrauJochClientError(
-                f"Error in {self._parent_name}. Detector must be in IDLE state to set settings. Current state: {state}"
+                f"Error on device {self._parent_name}. "
+                f"Detector must be in IDLE state to start acquisition. Current state: {state}"
             )
 
         if isinstance(settings, dict):
@@ -141,46 +169,80 @@ class JungfrauJochClient:
                 dataset_settings=settings, _request_timeout=request_timeout
             )
         except requests.exceptions.Timeout:
+            content = traceback.format_exc()
+            logger.error(
+                f"Timeout error after {request_timeout} seconds on device {self._parent_name} "
+                f"during 'start' call with dataset settings: {yaml.dump(settings, indent=4)}. \n"
+                f"Traceback: {content}"
+            )
             raise TimeoutError(
-                f"TimeoutError in JungfrauJochClient for parent device {self._parent_name} for 'start' call"
+                f"Timeout error after {request_timeout} seconds on device {self._parent_name} "
+                f"during 'start' call with dataset settings: {yaml.dump(settings, indent=4)}."
             )
         except Exception:
             content = traceback.format_exc()
+            logger.error(
+                f"Error on device {self._parent_name} during 'start' post with dataset settings: \n"
+                f"{yaml.dump(settings, indent=4)}. \nTraceback: {content}"
+            )
             raise JungfrauJochClientError(
-                f"Error in JungfrauJochClient for parent device {self._parent_name} during 'start' call: {content}"
+                f"Error on device {self._parent_name} during 'start' post with dataset settings: \n"
+                f"{yaml.dump(settings, indent=4)}. \nTraceback: {content}."
             )
 
     def stop(self, request_timeout: float = 0.5) -> None:
         """Stop the acquisition, this only logs errors and is not raising."""
-        try:
-            self.api.cancel_post_with_http_info(_request_timeout=request_timeout)
-        except requests.exceptions.Timeout:
-            content = traceback.format_exc()
-            logger.error(
-                f"Timeout in JungFrauJochClient for device {self._parent_name} during stop: {content}"
-            )
-        except Exception:
-            content = traceback.format_exc()
-            logger.error(
-                f"Error in JungFrauJochClient for device {self._parent_name} during stop: {content}"
-            )
 
-    def wait_for_idle(self, timeout: int = 10, request_timeout: float | None = None) -> bool:
-        """Wait for JungfrauJoch to be in Idle state. Blocking call with timeout.
+        def _stop_call(self):
+            try:
+                self.api.cancel_post_with_http_info()  # (_request_timeout=request_timeout)
+            except requests.exceptions.Timeout:
+                content = traceback.format_exc()
+                logger.error(
+                    f"Timeout error after {request_timeout} seconds on device {self._parent_name} "
+                    f"during stop: {content}"
+                )
+            except Exception:
+                content = traceback.format_exc()
+                logger.error(f"Error on device {self._parent_name} during stop: {content}")
+
+        thread = threading.Thread(
+            target=_stop_call, daemon=True, args=(self,), name="stop_jungfraujoch_thread"
+        )
+        thread.start()
+
+    def wait_for_idle(self, timeout: int = 10, raise_on_timeout: bool = True) -> bool:
+        """
+        Method to wait until the detector is in IDLE state. This is a blocking call with a
+        timeout that can be specified. The additional parameter raise_on_timeout can be used to
+        raise an exception on timeout instead of returning boolean True/False.
 
         Args:
             timeout (int): timeout in seconds
+            raise_on_timeout (bool): If True, raises an exception on timeout. Default is True.
         Returns:
             bool: True if the detector is in IDLE state, False if timeout occurred
         """
-        if request_timeout is None:
-            request_timeout = timeout
         try:
-            self.api.wait_till_done_post(timeout=timeout, _request_timeout=request_timeout)
+            self.api.wait_till_done_post(timeout=timeout, _request_timeout=timeout)
         except requests.exceptions.Timeout:
-            raise TimeoutError(f"HTTP request timeout in wait_for_idle for {self._parent_name}")
-        except Exception:
             content = traceback.format_exc()
-            logger.debug(f"Waiting for device {self._parent_name} to become IDLE: {content}")
+            logger.info(
+                f"Timeout after {timeout} seconds on device {self._parent_name} in wait_for_idle: {content}"
+            )
+            if raise_on_timeout:
+                raise TimeoutError(
+                    f"Timeout after {timeout} seconds on device {self._parent_name} in wait_for_idle."
+                )
+            return False
+        except Exception as exc:
+            content = traceback.format_exc()
+            logger.info(
+                f"Error on device {self._parent_name} in wait_for_idle. Full traceback: {content}"
+            )
+            if raise_on_timeout:
+                raise JungfrauJochClientError(
+                    f"Error on device {self._parent_name} in wait_for_idle: {content}"
+                ) from exc
             return False
         return True

csaxs_bec/devices/jungfraujoch/jungfraujoch_preview.py

@@ -1,22 +1,136 @@
-"""Module for the Eiger preview ZMQ stream."""
+"""
+Module for the JungfrauJoch preview ZMQ stream for the Eiger detector at cSAXS.
+The Preview client is implemented for the JungfrauJoch ZMQ PUB-SUB interface, and
+should be independent of the EIGER detector type.
+
+The client connects to the ZMQ PUB-SUB preview stream and calls a user provided callback
+function with the decompressed messages received from the stream. The callback needs to be
+able to deal with the different message types sent by the JungfrauJoch server ("start",
+"image", "end") as described in the JungfrauJoch ZEROMQ preview stream documentation.
+(https://jungfraujoch.readthedocs.io/en/latest/ZEROMQ_STREAM.html#preview-stream).
+"""
 
 from __future__ import annotations
 
-import json
 import threading
 import time
 from typing import Callable
 
+import cbor2
 import numpy as np
 import zmq
 from bec_lib.logger import bec_logger
+from dectris.compression import decompress
 
 logger = bec_logger.logger
 
-ZMQ_TOPIC_FILTER = b""
+###############################
+###### CBOR TAG DECODERS ######
+###############################
+# Dectris specific CBOR tags and decoders for Jungfrau data
+# Reference:
+# https://github.com/dectris/documentation/blob/main/stream_v2/examples/client.py
+
+
+def decode_multi_dim_array(tag: cbor2.CBORTag, column_major: bool = False):
+    """Decode a multi-dimensional array from a CBOR tag."""
+    dimensions, contents = tag.value
+    if isinstance(contents, list):
+        array = np.empty((len(contents),), dtype=object)
+        array[:] = contents
+    elif isinstance(contents, (np.ndarray, np.generic)):
+        array = contents
+    else:
+        raise cbor2.CBORDecodeValueError("expected array or typed array")
+    return array.reshape(dimensions, order="F" if column_major else "C")
+
+
+def decode_typed_array(tag: cbor2.CBORTag, dtype: str):
+    """Decode a typed array from a CBOR tag."""
+    if not isinstance(tag.value, bytes):
+        raise cbor2.CBORDecodeValueError("expected byte string in typed array")
+    return np.frombuffer(tag.value, dtype=dtype)
+
+
+def decode_dectris_compression(tag: cbor2.CBORTag):
+    """Decode a Dectris compressed array from a CBOR tag."""
+    algorithm, elem_size, encoded = tag.value
+    return decompress(encoded, algorithm, elem_size=elem_size)
+
+
+#########################################
+#### Dectris CBOR TAG Extensions ########
+#########################################
+
+# Mapping of various additional CBOR tags from Dectris to decoder functions
+tag_decoders = {
+    40: lambda tag: decode_multi_dim_array(tag, column_major=False),
+    64: lambda tag: decode_typed_array(tag, dtype="u1"),
+    65: lambda tag: decode_typed_array(tag, dtype=">u2"),
+    66: lambda tag: decode_typed_array(tag, dtype=">u4"),
+    67: lambda tag: decode_typed_array(tag, dtype=">u8"),
+    68: lambda tag: decode_typed_array(tag, dtype="u1"),
+    69: lambda tag: decode_typed_array(tag, dtype="<u2"),
+    70: lambda tag: decode_typed_array(tag, dtype="<u4"),
+    71: lambda tag: decode_typed_array(tag, dtype="<u8"),
+    72: lambda tag: decode_typed_array(tag, dtype="i1"),
+    73: lambda tag: decode_typed_array(tag, dtype=">i2"),
+    74: lambda tag: decode_typed_array(tag, dtype=">i4"),
+    75: lambda tag: decode_typed_array(tag, dtype=">i8"),
+    77: lambda tag: decode_typed_array(tag, dtype="<i2"),
+    78: lambda tag: decode_typed_array(tag, dtype="<i4"),
+    79: lambda tag: decode_typed_array(tag, dtype="<i8"),
+    80: lambda tag: decode_typed_array(tag, dtype=">f2"),
+    81: lambda tag: decode_typed_array(tag, dtype=">f4"),
+    82: lambda tag: decode_typed_array(tag, dtype=">f8"),
+    83: lambda tag: decode_typed_array(tag, dtype=">f16"),
+    84: lambda tag: decode_typed_array(tag, dtype="<f2"),
+    85: lambda tag: decode_typed_array(tag, dtype="<f4"),
+    86: lambda tag: decode_typed_array(tag, dtype="<f8"),
+    87: lambda tag: decode_typed_array(tag, dtype="<f16"),
+    1040: lambda tag: decode_multi_dim_array(tag, column_major=True),
+    56500: lambda tag: decode_dectris_compression(tag),  # pylint: disable=unnecessary-lambda
+}
+
+
+def tag_hook(decoder, tag: int):
+    """
+    Tag hook for the cbor2.loads method. Both arguments "decoder" and "tag" mus be present.
+    We use the tag to choose the respective decoder from the tag_decoders registry if available.
+    """
+    tag_decoder = tag_decoders.get(tag.tag)
+    return tag_decoder(tag) if tag_decoder else tag
+
+
+######################
+#### ZMQ Settings ####
+######################
+
+ZMQ_TOPIC_FILTER = b""  # Subscribe to all topics
+ZMQ_CONFLATE_SETTING = 1  # Keep only the most recent message
+ZMQ_RCVHWM_SETTING = 1  # Set high water mark to 1, this configures the max number of queue messages
+
+
+#################################
+#### Jungfrau Preview Client ####
+#################################
 
 
 class JungfrauJochPreview:
+    """
+    Preview client for the JungfrauJoch ZMQ preview stream. The client is started with
+    a URL to receive the data from the JungfrauJoch PUB-SUB preview interface, and a
+    callback function that is called with messages received from the preview stream.
+    The callback needs to be able to deal with the different message types sent
+    by the JungfrauJoch server ("start", "image", "end") as described in the
+    JungfrauJoch ZEROMQ preview stream documentation. Messages are dictionary dumps.
+    (https://jungfraujoch.readthedocs.io/en/latest/ZEROMQ_STREAM.html#preview-stream).
+
+    Args:
+        url (str): ZMQ PUB-SUB preview stream URL.
+        cb (Callable): Callback function called with messages received from the stream.
+    """
+
     USER_ACCESS = ["start", "stop"]
 
     def __init__(self, url: str, cb: Callable):
@@ -27,16 +141,18 @@ class JungfrauJochPreview:
         self._on_update_callback = cb
 
     def connect(self):
-        """Connect to the JungfrauJoch PUB-SUB streaming interface
-
-        JungfrauJoch may reject connection for a few seconds when it restarts,
-        so if it fails, wait a bit and try to connect again.
+        """
+        Connect to the JungfrauJoch PUB-SUB streaming interface. If the connection is refused
+        it will reattempt a second time after a one second delay.
         """
         # pylint: disable=no-member
 
         context = zmq.Context()
         self._socket = context.socket(zmq.SUB)
+        self._socket.setsockopt(zmq.CONFLATE, ZMQ_CONFLATE_SETTING)
         self._socket.setsockopt(zmq.SUBSCRIBE, ZMQ_TOPIC_FILTER)
+        self._socket.setsockopt(zmq.RCVHWM, ZMQ_RCVHWM_SETTING)
+
         try:
             self._socket.connect(self.url)
         except ConnectionRefusedError:
@@ -44,17 +160,26 @@ class JungfrauJochPreview:
             self._socket.connect(self.url)
 
     def start(self):
+        """Start the ZMQ update loop in a background thread."""
         self._zmq_thread = threading.Thread(
             target=self._zmq_update_loop, daemon=True, name="JungfrauJoch_live_preview"
         )
         self._zmq_thread.start()
 
     def stop(self):
+        """Stop the ZMQ update loop and wait for the thread to finish."""
         self._shutdown_event.set()
         if self._zmq_thread:
-            self._zmq_thread.join()
+            self._zmq_thread.join(timeout=1.0)
 
-    def _zmq_update_loop(self):
+    def _zmq_update_loop(self, poll_interval: float = 0.2):
+        """
+        ZMQ update loop running in a background thread. The polling is throttled by
+        the poll_interval parameter.
+
+        Args:
+            poll_interval (float): Time in seconds to wait between polling attempts.
+        """
         while not self._shutdown_event.is_set():
             if self._socket is None:
                 self.connect()
@@ -64,18 +189,21 @@ class JungfrauJochPreview:
                 # Happens when ZMQ partially delivers the multipart message
                 pass
             except zmq.error.Again:
-                # Happens when receive queue is empty
-                time.sleep(0.1)
+                logger.debug(
+                    f"ZMQ Again exception, receive queue is empty for JFJ preview at {self.url}."
+                )
+            finally:
+                # We throttle the polling to avoid heavy load on the device server
+                time.sleep(poll_interval)
 
     def _poll(self):
         """
-        Poll the ZMQ socket for new data. It will throttle the data update and
-        only subscribe to the topic for a single update. This is not very nice
-        but it seems like there is currently no option to set the update rate on
-        the backend.
+        Poll the ZMQ socket for new data. We are currently subscribing and unsubscribing
+        for each poll loop to avoid receiving too many messages. Throttling of the update
+        loop is handled in the _zmq_update_loop method.
         """
 
-        if self._shutdown_event.wait(0.2):
+        if self._shutdown_event.is_set():
             return
 
         try:
@@ -90,7 +218,19 @@ class JungfrauJochPreview:
             # Unsubscribe from the topic
             self._socket.setsockopt(zmq.UNSUBSCRIBE, ZMQ_TOPIC_FILTER)
 
-    def _parse_data(self, data):
-        # TODO decode and parse the data
-        # self._on_update_callback(data)
-        pass
+    def _parse_data(self, bytes_list: list[bytes]):
+        """
+        Parse the received ZMQ data from the JungfrauJoch preview stream.
+        We will call the _on_update_callback with the decompressed messages as a dictionary.
+
+        The callback needs to be able to deal with the different message types sent
+        by the JungfrauJoch server ("start", "image", "end") as described in the
+        JungfrauJoch ZEROMQ preview stream documentation. Messages are dictionary dumps.
+        (https://jungfraujoch.readthedocs.io/en/latest/ZEROMQ_STREAM.html#preview-stream).
+
+        Args:
+            bytes_list (list[bytes]): List of byte messages received from ZMQ recv_multipart.
+        """
+        for byte_msg in bytes_list:
+            msg = cbor2.loads(byte_msg, tag_hook=tag_hook)
+            self._on_update_callback(msg)

csaxs_bec/devices/omny/galil/galil_ophyd.py

@@ -4,6 +4,7 @@ This module contains the base class for Galil controllers as well as the signals
 
 import functools
 import time
+from typing import Any
 
 from bec_lib import bec_logger
 from ophyd.utils import ReadOnlyError
@@ -347,7 +348,7 @@ class GalilSignalBase(SocketSignal):
     def __init__(self, signal_name, **kwargs):
         self.signal_name = signal_name
         super().__init__(**kwargs)
-        self.controller = self.parent.controller
+        self.controller = self.root.controller if hasattr(self.root, "controller") else None
 
 
 class GalilSignalRO(GalilSignalBase):

csaxs_bec/devices/omny/galil/galil_rio.py

@@ -6,24 +6,26 @@ Link to the Galil RIO vendor page:
 https://www.galil.com/plcs/remote-io/rio-471xx
 
 This module provides the GalilRIOController for communication with the RIO controller
-over TCP/IP. It also provides a device integration that interfaces to these
-8 analog channels.
+over TCP/IP. It also provides a device integration that interfaces to its
+8 analog channels, and 16 digital output channels. Some PLCs may have 24 digital output channels,
+which can be easily supported by changing the _NUM_DIGITAL_OUTPUT_CHANNELS variable.
 """
 
 from __future__ import annotations
 
-import time
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Literal
 
 from bec_lib.logger import bec_logger
-from ophyd import Component as Cpt
+from ophyd import DynamicDeviceComponent as DDC
+from ophyd import Kind
+from ophyd.utils import ReadOnlyError
 from ophyd_devices import PSIDeviceBase
 from ophyd_devices.utils.controller import Controller, threadlocked
 from ophyd_devices.utils.socket import SocketIO
 
 from csaxs_bec.devices.omny.galil.galil_ophyd import (
     GalilCommunicationError,
-    GalilSignalRO,
+    GalilSignalBase,
     retry_once,
 )
 
@@ -35,15 +37,11 @@ logger = bec_logger.logger
 
 
 class GalilRIOController(Controller):
-    """
-    Controller Class for Galil RIO controller communication.
-
-    Multiple controllers are in use at the cSAXS beamline:
-    - 129.129.98.64 (port 23)
-    """
+    """Controller Class for Galil RIO controller communication."""
 
     @threadlocked
     def socket_put(self, val: str) -> None:
+        """Socker put method."""
         self.sock.put(f"{val}\r".encode())
 
     @retry_once
@@ -64,21 +62,95 @@ class GalilRIOController(Controller):
             )
 
 
-class GalilRIOSignalRO(GalilSignalRO):
+class GalilRIOAnalogSignalRO(GalilSignalBase):
     """
-    Read-only Signal for reading a single analog input channel from the Galil RIO controller.
-    It always read all 8 analog channels at once, and updates the reabacks of all channels.
-    New readbacks are only fetched from the controller if the last readback is older than
-    _READ_TIMEOUT seconds, otherwise the last cached readback is returned to reduce network traffic.
+    Signal for reading analog input channels of the Galil RIO controller. This signal is read-only, so
+    the set method raises a ReadOnlyError. The get method retrieves the values of all analog
+    channels in a single socket command. The readback values of all channels are updated based
+    on the response, and subscriptions are run for all channels. Readings are cached as implemented
+    in the SocketSignal class, so that multiple reads of the same channel within an update cycle do
+    not result in multiple socket calls.
 
     Args:
-        signal_name (str): Name of the signal.
-        channel (int): Analog channel number (0-7).
-        parent (GalilRIO): Parent GalilRIO device.
+        signal_name (str): The name of the signal, e.g. "ch0", "ch1", ..., "ch7"
+        channel (int): The channel number corresponding to the signal, e.g. 0 for "ch0", 1 for "ch1", ...
+        parent (GalilRIO): The parent device instance that this signal belongs to.
     """
 
     _NUM_ANALOG_CHANNELS = 8
-    _READ_TIMEOUT = 0.1  # seconds
+
+    def __init__(self, signal_name: str, channel: int, parent: GalilRIO, **kwargs):
+        super().__init__(signal_name=signal_name, parent=parent, **kwargs)
+        self._channel = channel
+        self._metadata["connected"] = False
+        self._metadata["write_access"] = False
+
+    def _socket_set(self, val):
+        """Read-only signal, so set method raises an error."""
+        raise ReadOnlyError(f"Signal {self.name} is read-only.")
+
+    def _socket_get(self) -> float:
+        """Get command for the readback signal"""
+        cmd = "MG@" + ", @".join([f"AN[{ii}]" for ii in range(self._NUM_ANALOG_CHANNELS)])
+        ret = self.controller.socket_put_and_receive(cmd)
+        values = [float(val) for val in ret.strip().split(" ")]
+        # Run updates for all channels. This also updates the _readback and metadata timestamp
+        # value of this channel.
+        self._update_all_channels(values)
+        return self._readback
+
+    # pylint: disable=protected-access
+    def _update_all_channels(self, values: list[float]) -> None:
+        """
+        Method to receive a list of readback values for channels 0 to 7. Updates for each channel idx
+        are applied to the corresponding GalilRIOAnalogSignalRO signal with matching attr_name "ch{idx}".
+
+        We also update the _last_readback attribute of each of the signals, to avoid multiple socket calls,
+        but rather use the cached value of the combined reading for all channels.
+
+        Args:
+            values (list[float]): List of new readback values for all channels, where the
+                index corresponds to the channel number (0-7).
+        """
+        updates: dict[str, tuple[float, float]] = {}  # attr_name -> (new_val, old_val)
+        # Update all readbacks first
+        for walk in self.parent.walk_signals():
+            if isinstance(walk.item, GalilRIOAnalogSignalRO):
+                idx = int(walk.item.attr_name[-1])
+                if 0 <= idx < len(values):
+                    old_val = walk.item._readback
+                    new_val = values[idx]
+                    walk.item._metadata["timestamp"] = self._last_readback
+                    walk.item._last_readback = self._last_readback
+                    walk.item._readback = new_val
+                    if (
+                        idx != self._channel
+                    ):  # Only run subscriptions on other channels, not on itself
+                        # as this is handled by the SocketSignal and we want to avoid running multiple
+                        # subscriptions for the same channel update
+                        updates[walk.item.attr_name] = (new_val, old_val)
+                else:
+                    logger.warning(
+                        f"Received {len(values)} values but found channel index {idx} in signal {walk.item.name}. Skipping update for this signal."
+                    )
+
+        # Run subscriptions after all readbacks have been updated
+        # on all channels except the one that triggered the update
+        for walk in self.parent.walk_signals():
+            if walk.item.attr_name in updates:
+                new_val, old_val = updates[walk.item.attr_name]
+                walk.item._run_subs(
+                    sub_type=walk.item.SUB_VALUE,
+                    old_value=old_val,
+                    value=new_val,
+                    timestamp=self._last_readback,
+                )
+
+
+class GalilRIODigitalOutSignal(GalilSignalBase):
+    """Signal for controlling digital outputs of the Galil RIO controller."""
+
+    _NUM_DIGITAL_OUTPUT_CHANNELS = 16
 
     def __init__(self, signal_name: str, channel: int, parent: GalilRIO, **kwargs):
         super().__init__(signal_name, parent=parent, **kwargs)
@@ -87,81 +159,83 @@ class GalilRIOSignalRO(GalilSignalRO):
 
     def _socket_get(self) -> float:
         """Get command for the readback signal"""
-        cmd = "MG@" + ",@".join([f"AN[{ii}]" for ii in range(self._NUM_ANALOG_CHANNELS)])
+        cmd = f"MG@OUT[{self._channel}]"
         ret = self.controller.socket_put_and_receive(cmd)
-        values = [float(val) for val in ret.strip().split(" ")]
-        # This updates all channels' readbacks, including self._readback
-        self._update_all_channels(values)
+        self._readback = float(ret.strip())
         return self._readback
 
-    def get(self):
-        """Get current analog channel values from the Galil RIO controller."""
-        # If the last readback has happend more than _READ_TIMEOUT seconds ago, read all channels again
-        if time.monotonic() - self.parent.last_readback > self._READ_TIMEOUT:
-            self._readback = self._socket_get()
-        return self._readback
+    def _socket_set(self, val: Literal[0, 1]) -> None:
+        """Set command for the digital output signal. Value should be 0 or 1."""
 
-    # pylint: disable=protected-access
-    def _update_all_channels(self, values: list[float]) -> None:
-        """
-        Update all analog channel readbacks based on the provided list of values.
-        List of values must be in order from an_ch0 to an_ch7.
+        if val not in (0, 1):
+            raise ValueError("Digital output value must be 0 or 1.")
+        cmd = f"SB{self._channel}" if val == 1 else f"CB{self._channel}"
+        self.controller.socket_put_confirmed(cmd)
 
-        We first have to update the _last_readback timestamp of the GalilRIO parent device.
-        Then we update all readbacks of all an_ch channels, before we run any subscriptions.
-        This ensures that all readbacks are updated before any subscriptions are run, which
-        may themselves read other channels.
 
-        Args:
-            values (list[float]): List of 8 float values corresponding to the analog channels.
-                                  They must be in order from an_ch0 to an_ch7.
-        """
-        timestamp = time.time()
-        # Update parent's last readback before running subscriptions!!
-        self.parent._last_readback = time.monotonic()
-        updates: dict[str, tuple[float, float]] = {}  # attr_name -> (new_val, old_val)
-        # Update all readbacks first
-        for walk in self.parent.walk_signals():
-            if walk.item.attr_name.startswith("an_ch"):
-                idx = int(walk.item.attr_name[-1])
-                if 0 <= idx < len(values):
-                    old_val = walk.item._readback
-                    new_val = values[idx]
-                    walk.item._metadata["timestamp"] = timestamp
-                    walk.item._readback = new_val
-                    updates[walk.item.attr_name] = (new_val, old_val)
+def _create_analog_channels(num_channels: int) -> dict[str, tuple]:
+    """
+    Helper method to create a dictionary of analog channel definitions for the DynamicDeviceComponent.
 
-        # Run subscriptions after all readbacks have been updated
-        for walk in self.parent.walk_signals():
-            if walk.item.attr_name in updates:
-                new_val, old_val = updates[walk.item.attr_name]
-                walk.item._run_subs(
-                    sub_type=walk.item.SUB_VALUE,
-                    old_value=old_val,
-                    value=new_val,
-                    timestamp=timestamp,
-                )
+    Args:
+        num_channels (int): The number of analog channels to create.
+    """
+    an_channels = {}
+    for i in range(0, num_channels):
+        an_channels[f"ch{i}"] = (
+            GalilRIOAnalogSignalRO,
+            f"ch{i}",
+            {"kind": Kind.normal, "notify_bec": True, "channel": i, "doc": f"Analog channel {i}."},
+        )
+    return an_channels
+
+
+def _create_digital_output_channels(num_channels: int) -> dict[str, tuple]:
+    """
+    Helper method to create a dictionary of digital output channel definitions for the DynamicDeviceComponent.
+
+    Args:
+        num_channels (int): The number of digital output channels to create.
+    """
+    di_out_channels = {}
+    for i in range(0, num_channels):
+        di_out_channels[f"ch{i}"] = (
+            GalilRIODigitalOutSignal,
+            f"ch{i}",
+            {
+                "kind": Kind.config,
+                "notify_bec": True,
+                "channel": i,
+                "doc": f"Digital output channel {i}.",
+            },
+        )
+    return di_out_channels
 
 
 class GalilRIO(PSIDeviceBase):
     """
-    Galil RIO controller integration with 8 analog input channels. To implement the device,
-    please provide the appropriate host and port (default port is 23).
+    Galil RIO controller integration with 16 digital output channels and 8 analog input channels.
+    The default port for the controller is 23.
 
     Args:
         host (str): Hostname or IP address of the Galil RIO controller.
+        port (int, optional): Port number for the TCP/IP connection. Defaults to 23.
+        socket_cls (type[SocketIO], optional): Socket class to use for communication. Defaults to SocketIO.
+        scan_info (ScanInfo, optional): ScanInfo object for the device.
+        device_manager (DeviceManagerDS): The device manager instance that manages this device.
+        **kwargs: Additional keyword arguments passed to the PSIDeviceBase constructor.
     """
 
     SUB_CONNECTION_CHANGE = "connection_change"
 
-    an_ch0 = Cpt(GalilRIOSignalRO, signal_name="an_ch0", channel=0, doc="Analog input channel 0")
-    an_ch1 = Cpt(GalilRIOSignalRO, signal_name="an_ch1", channel=1, doc="Analog input channel 1")
-    an_ch2 = Cpt(GalilRIOSignalRO, signal_name="an_ch2", channel=2, doc="Analog input channel 2")
-    an_ch3 = Cpt(GalilRIOSignalRO, signal_name="an_ch3", channel=3, doc="Analog input channel 3")
-    an_ch4 = Cpt(GalilRIOSignalRO, signal_name="an_ch4", channel=4, doc="Analog input channel 4")
-    an_ch5 = Cpt(GalilRIOSignalRO, signal_name="an_ch5", channel=5, doc="Analog input channel 5")
-    an_ch6 = Cpt(GalilRIOSignalRO, signal_name="an_ch6", channel=6, doc="Analog input channel 6")
-    an_ch7 = Cpt(GalilRIOSignalRO, signal_name="an_ch7", channel=7, doc="Analog input channel 7")
+    #############################
+    ### Analog input channels ###
+    #############################
+
+    analog_in = DDC(_create_analog_channels(GalilRIOAnalogSignalRO._NUM_ANALOG_CHANNELS))
+    digital_out = DDC(
+        _create_digital_output_channels(GalilRIODigitalOutSignal._NUM_DIGITAL_OUTPUT_CHANNELS)
+    )
 
     def __init__(
         self,
@@ -177,19 +251,18 @@ class GalilRIO(PSIDeviceBase):
         if port is None:
             port = 23  # Default port for Galil RIO controller
         self.controller = GalilRIOController(
-            socket_cls=socket_cls, socket_host=host, socket_port=port, device_manager=device_manager
+            name=f"GalilRIOController_{name}",
+            socket_cls=socket_cls,
+            socket_host=host,
+            socket_port=port,
+            device_manager=device_manager,
         )
-        self._last_readback: float = time.monotonic()
+        self._readback_metadata: dict[str, float] = {"last_readback": 0.0}
         super().__init__(name=name, device_manager=device_manager, scan_info=scan_info, **kwargs)
         self.controller.subscribe(
             self._update_connection_state, event_type=self.SUB_CONNECTION_CHANGE
         )
 
-    @property
-    def last_readback(self) -> float:
-        """Return the time of the last readback from the controller."""
-        return self._last_readback
-
     # pylint: disable=arguments-differ
     def wait_for_connection(self, timeout: float = 30.0) -> None:
         """Wait for the RIO controller to be connected within timeout period."""
@@ -207,7 +280,7 @@ class GalilRIO(PSIDeviceBase):
 
 
 if __name__ == "__main__":
-    HOST_NAME = "129.129.98.64"
+    HOST_NAME = "129.129.122.14"
     from bec_server.device_server.tests.utils import DMMock
 
     dm = DMMock()

csaxs_bec/devices/panda_box/panda_box.py

@@ -0,0 +1,101 @@
+"""Module to integrate the PandaBox for cSAXS measurements."""
+
+import time
+
+from bec_lib.logger import bec_logger
+from ophyd_devices import AsyncMultiSignal, StatusBase
+from ophyd_devices.devices.panda_box.panda_box import PandaBox, PandaState
+from pandablocks.responses import FrameData
+
+logger = bec_logger.logger
+
+
+class PandaBoxCSAXS(PandaBox):
+
+    def on_init(self):
+        super().on_init()
+        self._acquisition_group = "burst"
+        self._timeout_on_completed = 10
+
+    def on_stage(self):
+        # TODO, adjust as seen fit.
+        # Adjust the acquisition group based on scan parameters if needed
+        if self.scan_info.msg.scan_type == "fly":
+            self._acquisition_group = "fly"
+        elif self.scan_info.msg.scan_type == "step":
+            if self.scan_info.msg.scan_parameters["frames_per_trigger"] == 1:
+                self._acquisition_group = "monitored"
+            else:
+                self._acquisition_group = "burst"
+
+    def on_complete(self):
+        """On complete is called after the scan is complete. We need to wait for the capture to complete before we can disarm the PandaBox."""
+
+        def _check_capture_complete():
+            captured = 0
+            start_time = time.monotonic()
+            try:
+                expected_points = int(self.scan_info.msg.num_points * self.scan_info.msg.scan_parameters.get("frames_per_trigger",1))
+                while captured < expected_points:
+                    logger.info(
+                        f"Run with captured {captured} and expected points : {expected_points}."
+                    )
+                    ret = self.send_raw("*PCAP.CAPTURED?")
+                    captured = int(ret[0].split("=")[-1])
+                    time.sleep(0.01)
+                    if (time.monotonic() - start_time) > self._timeout_on_completed:
+                        raise TimeoutError(f"Pandabox {self.name} did not complete after {self._timeout_on_completed} with points captured {captured}/{expected_points}")
+            finally:
+                self._disarm()
+
+        _check_capture_complete()
+
+        # NOTE: This utility class allows to submit a blocking function to a thread and return a status object
+        # that can be awaited for. This allows for asynchronous waiting for the capture to complete without blocking
+        # the main duty cycle of the device server. The device server knows how to handle the status object (future)
+        # and will wait for it to complete.
+        # status = self.task_handler.submit_task(_check_capture_complete, run=True)
+
+        # status_panda_state = StatusBase(obj=self)
+        # self.add_status_callback(
+        #     status, success=[PandaState.END, PandaState.DISARMED], failure=[PandaState.READY]
+        # )
+        # ret_status = status & status_panda_state
+        # self.cancel_on_stop(ret_status)
+        # return ret_status
+
+
+if __name__ == "__main__":
+    import time
+
+    panda = PandaBoxCSAXS(
+        name="omny_panda",
+        host="omny-panda.psi.ch",
+        signal_alias={
+            "FMC_IN.VAL2.Value": "alias",
+            "FMC_IN.VAL1.Min": "alias2",
+            "FMC_IN.VAL1.Max": "alias3",
+            "FMC_IN.VAL1.Mean": "alias4",
+        },
+    )
+    panda.on_connected()
+    status = StatusBase(obj=panda)
+    panda.add_status_callback(
+        status=status, success=[PandaState.DISARMED], failure=[PandaState.READY]
+    )
+    panda.stop()
+    status.wait(timeout=2)
+    panda.unstage()
+    logger.info(f"Panda connected")
+    ret = panda.stage()
+    logger.info(f"Panda staged")
+    ret = panda.pre_scan()
+    ret.wait(timeout=5)
+    logger.info(f"Panda pre scan done")
+    time.sleep(5)
+    panda.stop()
+    st = panda.complete()
+    st.wait(timeout=5)
+    logger.info(f"Measurement completed")
+    panda.unstage()
+    logger.info(f"Panda Unstaged")

csaxs_bec/devices/panda_box/panda_box_omny.py

@@ -0,0 +1,102 @@
+"""Module to integrate the PandaBox for cSAXS measurements."""
+
+import time
+
+from bec_lib.logger import bec_logger
+from ophyd_devices import AsyncMultiSignal, StatusBase
+from ophyd_devices.devices.panda_box.panda_box import PandaBox, PandaState
+from pandablocks.responses import FrameData
+
+logger = bec_logger.logger
+
+
+class PandaBoxOMNY(PandaBox):
+
+    def on_init(self):
+        super().on_init()
+        self._acquisition_group = "burst"
+        self._timeout_on_completed = 10
+
+    def on_stage(self):
+        
+        # TODO, adjust as seen fit.
+        # Adjust the acquisition group based on scan parameters if needed
+        if self.scan_info.msg.scan_type == "fly":
+            self._acquisition_group = "fly"
+        elif self.scan_info.msg.scan_type == "step":
+            if self.scan_info.msg.scan_parameters["frames_per_trigger"] == 1:
+                self._acquisition_group = "monitored"
+            else:
+                self._acquisition_group = "burst"
+
+    def on_complete(self):
+        """On complete is called after the scan is complete. We need to wait for the capture to complete before we can disarm the PandaBox."""
+
+        def _check_capture_complete():
+            captured = 0
+            start_time = time.monotonic()
+            try:
+                expected_points = int(self.scan_info.msg.num_points * self.scan_info.msg.scan_parameters.get("frames_per_trigger",1))
+                while captured < expected_points:
+                    logger.info(
+                        f"Run with captured {captured} and expected points : {expected_points}."
+                    )
+                    ret = self.send_raw("*PCAP.CAPTURED?")
+                    captured = int(ret[0].split("=")[-1])
+                    time.sleep(0.01)
+                    if (time.monotonic() - start_time) > self._timeout_on_completed:
+                        raise TimeoutError(f"Pandabox {self.name} did not complete after {self._timeout_on_completed} with points captured {captured}/{expected_points}")
+            finally:
+                self._disarm()
+
+        _check_capture_complete()
+
+        # NOTE: This utility class allows to submit a blocking function to a thread and return a status object
+        # that can be awaited for. This allows for asynchronous waiting for the capture to complete without blocking
+        # the main duty cycle of the device server. The device server knows how to handle the status object (future)
+        # and will wait for it to complete.
+        # status = self.task_handler.submit_task(_check_capture_complete, run=True)
+
+        # status_panda_state = StatusBase(obj=self)
+        # self.add_status_callback(
+        #     status, success=[PandaState.END, PandaState.DISARMED], failure=[PandaState.READY]
+        # )
+        # ret_status = status & status_panda_state
+        # self.cancel_on_stop(ret_status)
+        # return ret_status
+
+
+if __name__ == "__main__":
+    import time
+
+    panda = PandaBoxCSAXS(
+        name="omny_panda",
+        host="omny-panda.psi.ch",
+        signal_alias={
+            "FMC_IN.VAL2.Value": "alias",
+            "FMC_IN.VAL1.Min": "alias2",
+            "FMC_IN.VAL1.Max": "alias3",
+            "FMC_IN.VAL1.Mean": "alias4",
+        },
+    )
+    panda.on_connected()
+    status = StatusBase(obj=panda)
+    panda.add_status_callback(
+        status=status, success=[PandaState.DISARMED], failure=[PandaState.READY]
+    )
+    panda.stop()
+    status.wait(timeout=2)
+    panda.unstage()
+    logger.info(f"Panda connected")
+    ret = panda.stage()
+    logger.info(f"Panda staged")
+    ret = panda.pre_scan()
+    ret.wait(timeout=5)
+    logger.info(f"Panda pre scan done")
+    time.sleep(5)
+    panda.stop()
+    st = panda.complete()
+    st.wait(timeout=5)
+    logger.info(f"Measurement completed")
+    panda.unstage()
+    logger.info(f"Panda Unstaged")

csaxs_bec/scans/LamNIFermatScan.py

@@ -210,7 +210,7 @@ class LamNIFermatScan(ScanBase, LamNIMixin):
     arg_input = {}
     arg_bundle_size = {"bundle": len(arg_input), "min": None, "max": None}
 
-    def __init__(self, *args, parameter: dict = None, **kwargs):
+    def __init__(self, *args, parameter: dict = None, frames_per_trigger:int=1, exp_time:float=0,**kwargs):
         """
         A LamNI scan following Fermat's spiral.
 
@@ -230,10 +230,10 @@ class LamNIFermatScan(ScanBase, LamNIMixin):
 
         Examples:
             >>> scans.lamni_fermat_scan(fov_size=[20], step=0.5, exp_time=0.1)
-            >>> scans.lamni_fermat_scan(fov_size=[20, 25], center_x=0.02, center_y=0, shift_x=0, shift_y=0, angle=0, step=0.5, fov_circular=0, exp_time=0.1)
+            >>> scans.lamni_fermat_scan(fov_size=[20, 25], center_x=0.02, center_y=0, shift_x=0, shift_y=0, angle=0, step=0.5, fov_circular=0, exp_time=0.1, frames_per_trigger=1)
         """
 
-        super().__init__(parameter=parameter, **kwargs)
+        super().__init__(parameter=parameter, frames_per_trigger=frames_per_trigger, exp_time=exp_time,**kwargs)
         self.axis = []
         scan_kwargs = parameter.get("kwargs", {})
         self.fov_size = scan_kwargs.get("fov_size")
@@ -482,6 +482,7 @@ class LamNIFermatScan(ScanBase, LamNIMixin):
         yield from self.open_scan()
         yield from self.stage()
         yield from self.run_baseline_reading()
+        yield from self.pre_scan()
         yield from self.scan_core()
         yield from self.finalize()
         yield from self.unstage()

csaxs_bec/scans/flomni_fermat_scan.py

@@ -52,6 +52,7 @@ class FlomniFermatScan(SyncFlyScanBase):
         angle: float = None,
         corridor_size: float = 3,
         parameter: dict = None,
+        frames_per_trigger:int=1,
         **kwargs,
     ):
         """
@@ -62,7 +63,8 @@ class FlomniFermatScan(SyncFlyScanBase):
             fovy(float) [um]: Fov in the piezo plane (i.e. piezo range). Max 100 um
             cenx(float) [um]: center position in x.
             ceny(float) [um]: center position in y.
-            exp_time(float) [s]: exposure time
+            exp_time(float) [s]: exposure time per burst frame
+            frames_per_trigger(int) : Number of burst frames per point
             step(float) [um]: stepsize
             zshift(float) [um]: shift in z
             angle(float) [deg]: rotation angle (will rotate first)
@@ -71,10 +73,10 @@ class FlomniFermatScan(SyncFlyScanBase):
         Returns:
 
         Examples:
-            >>> scans.flomni_fermat_scan(fovx=20, fovy=25, cenx=0.02, ceny=0, zshift=0, angle=0, step=0.5, exp_time=0.01)
+            >>> scans.flomni_fermat_scan(fovx=20, fovy=25, cenx=0.02, ceny=0, zshift=0, angle=0, step=0.5, exp_time=0.01, frames_per_trigger=1)
         """
 
-        super().__init__(parameter=parameter, exp_time=exp_time, **kwargs)
+        super().__init__(parameter=parameter, exp_time=exp_time, frames_per_trigger=frames_per_trigger, **kwargs)
         self.show_live_table = False
         self.axis = []
         self.fovx = fovx
@@ -323,6 +325,7 @@ class FlomniFermatScan(SyncFlyScanBase):
         yield from self.stage()
         yield from self.run_baseline_reading()
         yield from self._prepare_setup_part2()
+        yield from self.pre_scan()
         yield from self.scan_core()
         yield from self.finalize()
         yield from self.unstage()

csaxs_bec/scans/omny_fermat_scan.py

@@ -51,6 +51,7 @@ class OMNYFermatScan(SyncFlyScanBase):
         angle: float = None,
         corridor_size: float = 3,
         parameter: dict = None,
+        frames_per_trigger:int=1,
         **kwargs,
     ):
         """
@@ -62,6 +63,7 @@ class OMNYFermatScan(SyncFlyScanBase):
             cenx(float) [um]: center position in x.
             ceny(float) [um]: center position in y.
             exp_time(float) [s]: exposure time
+            frames_per_trigger:int: Number of burst frames per trigger, defaults to 1.
             step(float) [um]: stepsize
             zshift(float) [um]: shift in z
             angle(float) [deg]: rotation angle (will rotate first)
@@ -73,7 +75,7 @@ class OMNYFermatScan(SyncFlyScanBase):
             >>> scans.omny_fermat_scan(fovx=20, fovy=25, cenx=10, ceny=0, zshift=0, angle=0, step=2, exp_time=0.01)
         """
 
-        super().__init__(parameter=parameter, **kwargs)
+        super().__init__(parameter=parameter, exp_time=exp_time, frames_per_trigger=frames_per_trigger, **kwargs)
         self.axis = []
         self.fovx = fovx
         self.fovy = fovy
@@ -299,6 +301,7 @@ class OMNYFermatScan(SyncFlyScanBase):
         yield from self.stage()
         yield from self.run_baseline_reading()
         yield from self._prepare_setup_part2()
+        yield from self.pre_scan()
         yield from self.scan_core()
         yield from self.finalize()
         yield from self.unstage()

docs/user/ptychography/flomni.md

@@ -193,14 +193,15 @@ The basic scan function can be called by `scans.flomni_fermat_scan()` and offers
 | fovy (float) | Fov in the piezo plane (i.e. piezo range). Max 100 um |
 | cenx (float) | center position in x |
 | ceny (float) | center position in y |
-| exp_time (float) | exposure time |
+| exp_time (float) | exposure time per frame |
+| frames_per_trigger(int) | Number of burst frames per position |
 | step (float) | stepsize |
 | zshift (float) | shift in z |
 | angle (float) | rotation angle (will rotate first) |
 | corridor_size (float) | corridor size for the corridor optimization. Default 3 um |
 
 Example:  
-`scans.flomni_fermat_scan(fovx=20, fovy=25, cenx=0.02, ceny=0, zshift=0, angle=0, step=0.5, exp_time=0.01)`
+`scans.flomni_fermat_scan(fovx=20, fovy=25, cenx=0.02, ceny=0, zshift=0, angle=0, step=0.5, exp_time=0.01, frames_per_trigger=1)`
 
 #### Overview of the alignment steps
 

docs/user/ptychography/omny.md

@@ -327,14 +327,15 @@ The basic scan function can be called by `scans.omny_fermat_scan()` and offers a
 | fovy (float) | Fov in the piezo plane (i.e. piezo range). Max 100 um |
 | cenx (float) | center position in x |
 | ceny (float) | center position in y |
-| exp_time (float) | exposure time |
+| exp_time (float) | exposure time per frame |
+| frames_per_trigger(int) | Number of burst frames per position |
 | step (float) | stepsize |
 | zshift (float) | shift in z |
 | angle (float) | rotation angle (will rotate first) |
 | corridor_size (float) | corridor size for the corridor optimization. Default 3 um |
 
 Example:  
-`scans.omny_fermat_scan(fovx=20, fovy=25, cenx=0.02, ceny=0, zshift=0, angle=0, step=0.5, exp_time=0.01)`
+`scans.omny_fermat_scan(fovx=20, fovy=25, cenx=0.02, ceny=0, zshift=0, angle=0, step=0.5, exp_time=0.01, frames_per_trigger=1)`
 
 #### Overview of the alignment steps
 

pyproject.toml

@@ -25,6 +25,8 @@ dependencies = [
     "bec_widgets",
     "zmq",
     "opencv-python",
+    "dectris-compression", # for JFJ preview stream decompression
+    "cbor2",
 ]
 
 [project.optional-dependencies]

tests/conftest.py

@@ -1,14 +0,0 @@
-"""
-Conftest runs for all tests in this directory and subdirectories. Thereby, we know for
-certain that the SocketSignal.READBACK_TIMEOUT is set to 0 for all tests, which prevents
-hanging tests when a readback is attempted on a non-connected socket.
-"""
-
-# conftest.py
-import pytest
-from ophyd_devices.utils.socket import SocketSignal
-
-
-@pytest.fixture(autouse=True)
-def patch_socket_timeout(monkeypatch):
-    monkeypatch.setattr(SocketSignal, "READBACK_TIMEOUT", 0.0)

tests/tests_devices/test_eiger.py

@@ -5,6 +5,7 @@ from time import time
 from typing import TYPE_CHECKING, Generator
 from unittest import mock
 
+import numpy as np
 import pytest
 from bec_lib.messages import FileMessage, ScanStatusMessage
 from jfjoch_client.models.broker_status import BrokerStatus
@@ -78,7 +79,7 @@ def detector_list(request) -> Generator[DetectorList, None, None]:
             ),
             DetectorListElement(
                 id=2,
-                description="EIGER 8.5M (tmp)",
+                description="EIGER 9M",
                 serial_number="123456",
                 base_ipv4_addr="192.168.0.1",
                 udp_interface_count=1,
@@ -103,7 +104,11 @@ def eiger_1_5m(mock_scan_info) -> Generator[Eiger1_5M, None, None]:
     name = "eiger_1_5m"
     dev = Eiger1_5M(name=name, beam_center=(256, 256), detector_distance=100.0)
     dev.scan_info.msg = mock_scan_info
-    yield dev
+    try:
+        yield dev
+    finally:
+        if dev._destroyed is False:
+            dev.destroy()
 
 
 @pytest.fixture(scope="function")
@@ -113,7 +118,19 @@ def eiger_9m(mock_scan_info) -> Generator[Eiger9M, None, None]:
     name = "eiger_9m"
     dev = Eiger9M(name=name)
     dev.scan_info.msg = mock_scan_info
-    yield dev
+    try:
+        yield dev
+    finally:
+        if dev._destroyed is False:
+            dev.destroy()
+
+
+def test_eiger_wait_for_connection(eiger_1_5m, eiger_9m):
+    """Test the wait_for_connection metho is calling status_get on the JFJ API client."""
+    for eiger in (eiger_1_5m, eiger_9m):
+        with mock.patch.object(eiger.jfj_client.api, "status_get") as mock_status_get:
+            eiger.wait_for_connection(timeout=1)
+            mock_status_get.assert_called_once_with(_request_timeout=1)
 
 
 @pytest.mark.parametrize("detector_state", ["Idle", "Inactive"])
@@ -141,7 +158,7 @@ def test_eiger_1_5m_on_connected(eiger_1_5m, detector_list, detector_state):
         else:
             eiger.on_connected()
             assert mock_set_det.call_args == mock.call(
-                DetectorSettings(frame_time_us=500, timing=DetectorTiming.TRIGGER), timeout=10
+                DetectorSettings(frame_time_us=500, timing=DetectorTiming.TRIGGER), timeout=5
             )
             assert mock_file_writer.call_args == mock.call(
                 file_writer_settings=FileWriterSettings(
@@ -179,7 +196,7 @@ def test_eiger_9m_on_connected(eiger_9m, detector_list, detector_state):
         else:
             eiger.on_connected()
             assert mock_set_det.call_args == mock.call(
-                DetectorSettings(frame_time_us=500, timing=DetectorTiming.TRIGGER), timeout=10
+                DetectorSettings(frame_time_us=500, timing=DetectorTiming.TRIGGER), timeout=5
             )
             assert mock_file_writer.call_args == mock.call(
                 file_writer_settings=FileWriterSettings(
@@ -216,11 +233,39 @@ def test_eiger_on_stop(eiger_1_5m):
         stop_event.wait(timeout=5)  # Thread should be killed from task_handler
 
 
+def test_eiger_on_destroy(eiger_1_5m):
+    """Test the on_destroy logic of the Eiger detector. This is equivalent for 9M and 1_5M."""
+    eiger = eiger_1_5m
+    start_event = threading.Event()
+    stop_event = threading.Event()
+
+    def tmp_task():
+        start_event.set()
+        try:
+            while True:
+                time.sleep(0.1)
+        finally:
+            stop_event.set()
+
+    eiger.task_handler.submit_task(tmp_task)
+    start_event.wait(timeout=5)
+
+    with (
+        mock.patch.object(eiger.jfj_preview_client, "stop") as mock_jfj_preview_client_stop,
+        mock.patch.object(eiger.jfj_client, "stop") as mock_jfj_client_stop,
+    ):
+        eiger.on_destroy()
+        mock_jfj_preview_client_stop.assert_called_once()
+        mock_jfj_client_stop.assert_called_once()
+        stop_event.wait(timeout=5)
+
+
 @pytest.mark.timeout(25)
 @pytest.mark.parametrize("raise_timeout", [True, False])
 def test_eiger_on_complete(eiger_1_5m, raise_timeout):
     """Test the on_complete logic of the Eiger detector. This is equivalent for 9M and 1_5M."""
     eiger = eiger_1_5m
+    eiger._wait_for_on_complete = 1  # reduce wait time for testing
 
     callback_completed_event = threading.Event()
 
@@ -230,7 +275,7 @@ def test_eiger_on_complete(eiger_1_5m, raise_timeout):
 
     unblock_wait_for_idle = threading.Event()
 
-    def mock_wait_for_idle(timeout: int, request_timeout: float):
+    def mock_wait_for_idle(timeout: float, raise_on_timeout: bool) -> bool:
         if unblock_wait_for_idle.wait(timeout):
             if raise_timeout:
                 return False
@@ -238,11 +283,18 @@ def test_eiger_on_complete(eiger_1_5m, raise_timeout):
         return False
 
     with (
+        mock.patch.object(
+            eiger.jfj_client.api, "status_get", return_value=BrokerStatus(state="Idle")
+        ),
         mock.patch.object(eiger.jfj_client, "wait_for_idle", side_effect=mock_wait_for_idle),
         mock.patch.object(
             eiger.jfj_client.api,
             "statistics_data_collection_get",
-            return_value=MeasurementStatistics(run_number=1),
+            return_value=MeasurementStatistics(
+                run_number=1,
+                images_collected=eiger.scan_info.msg.num_points
+                * eiger.scan_info.msg.scan_parameters["frames_per_trigger"],
+            ),
         ),
     ):
         status = eiger.complete()
@@ -284,7 +336,7 @@ def test_eiger_file_event_callback(eiger_1_5m, tmp_path):
     assert file_msg.hinted_h5_entries == {"data": "entry/data/data"}
 
 
-def test_eiger_on_sage(eiger_1_5m):
+def test_eiger_on_stage(eiger_1_5m):
     """Test the on_stage and on_unstage logic of the Eiger detector. This is equivalent for 9M and 1_5M."""
     eiger = eiger_1_5m
     scan_msg = eiger.scan_info.msg
@@ -316,3 +368,35 @@ def test_eiger_on_sage(eiger_1_5m):
         )
         assert mock_start.call_args == mock.call(settings=data_settings)
         assert eiger.staged is Staged.yes
+
+
+def test_eiger_set_det_distance_test_beam_center(eiger_1_5m):
+    """Test the set_detector_distance and set_beam_center methods. Equivalent for 9M and 1_5M."""
+    eiger = eiger_1_5m
+    old_distance = eiger.detector_distance
+    new_distance = old_distance + 100
+    old_beam_center = eiger.beam_center
+    new_beam_center = (old_beam_center[0] + 20, old_beam_center[1] + 50)
+    eiger.set_detector_distance(new_distance)
+    assert eiger.detector_distance == new_distance
+    eiger.set_beam_center(x=new_beam_center[0], y=new_beam_center[1])
+    assert eiger.beam_center == new_beam_center
+    with pytest.raises(ValueError):
+        eiger.set_beam_center(x=-10, y=100)  # Cannot set negative beam center
+    with pytest.raises(ValueError):
+        eiger.detector_distance = -50  # Cannot set negative detector distance
+
+
+def test_eiger_preview_callback(eiger_1_5m):
+    """Preview callback test for the Eiger detector. This is equivalent for 9M and 1_5M."""
+    eiger = eiger_1_5m
+    # NOTE: I don't find models for the CBOR messages used by JFJ, currently using a dummay dict.
+    # Please adjust once the proper model is found.
+    for msg_type in ["start", "end", "image", "calibration", "metadata"]:
+        msg = {"type": msg_type, "data": {"default": np.array([[1, 2], [3, 4]])}}
+        with mock.patch.object(eiger.preview_image, "put") as mock_preview_put:
+            eiger._preview_callback(msg)
+            if msg_type == "image":
+                mock_preview_put.assert_called_once_with(msg["data"]["default"])
+            else:
+                mock_preview_put.assert_not_called()

tests/tests_devices/test_fupr_ophyd.py

@@ -2,6 +2,7 @@ from unittest import mock
 
 import pytest
 from ophyd_devices.tests.utils import SocketMock
+from ophyd_devices.utils.socket import SocketSignal
 
 from csaxs_bec.devices.omny.galil.fupr_ophyd import FuprGalilController, FuprGalilMotor
 
@@ -17,6 +18,11 @@ def fsamroy(dm_with_devices):
         socket_cls=SocketMock,
         device_manager=dm_with_devices,
     )
+    for walk in fsamroy_motor.walk_signals():
+        if isinstance(walk.item, SocketSignal):
+            walk.item._readback_timeout = (
+                0.0  # Set the readback timeout to 0 to avoid waiting during tests
+            )
     fsamroy_motor.controller.on()
     assert isinstance(fsamroy_motor.controller, FuprGalilController)
     yield fsamroy_motor

tests/tests_devices/test_galil.py

@@ -9,7 +9,11 @@ from ophyd_devices.tests.utils import SocketMock
 from csaxs_bec.devices.npoint.npoint import NPointAxis, NPointController
 from csaxs_bec.devices.omny.galil.fgalil_ophyd import FlomniGalilController, FlomniGalilMotor
 from csaxs_bec.devices.omny.galil.fupr_ophyd import FuprGalilController, FuprGalilMotor
-from csaxs_bec.devices.omny.galil.galil_rio import GalilRIO, GalilRIOController, GalilRIOSignalRO
+from csaxs_bec.devices.omny.galil.galil_rio import (
+    GalilRIO,
+    GalilRIOAnalogSignalRO,
+    GalilRIOController,
+)
 from csaxs_bec.devices.omny.galil.lgalil_ophyd import LamniGalilController, LamniGalilMotor
 from csaxs_bec.devices.omny.galil.ogalil_ophyd import OMNYGalilController, OMNYGalilMotor
 from csaxs_bec.devices.omny.galil.sgalil_ophyd import GalilController, SGalilMotor
@@ -272,26 +276,27 @@ def test_galil_rio_signal_read(galil_rio):
     ## Test read of all channels
     ###########
 
-    assert galil_rio.an_ch0._READ_TIMEOUT == 0.1  # Default read timeout of 100ms
+    assert galil_rio.analog_in.ch0._readback_timeout == 0.1  # Default read timeout of 100ms
     # Mock the socket to return specific values
-    galil_rio.controller.sock.buffer_recv = [b" 1.234 2.345 3.456 4.567 5.678 6.789 7.890 8.901"]
-    galil_rio._last_readback = 0  # Force read from controller
-
+    analog_bufffer = b" 1.234 2.345 3.456 4.567 5.678 6.789 7.890 8.901\r\n"
+    galil_rio.controller.sock.buffer_recv = []  # Clear any existing buffer
+    galil_rio.controller.sock.buffer_recv.append(analog_bufffer)
     read_values = galil_rio.read()
     assert len(read_values) == 8  # 8 channels
+
     expected_values = {
-        galil_rio.an_ch0.name: {"value": 1.234},
-        galil_rio.an_ch1.name: {"value": 2.345},
-        galil_rio.an_ch2.name: {"value": 3.456},
-        galil_rio.an_ch3.name: {"value": 4.567},
-        galil_rio.an_ch4.name: {"value": 5.678},
-        galil_rio.an_ch5.name: {"value": 6.789},
-        galil_rio.an_ch6.name: {"value": 7.890},
-        galil_rio.an_ch7.name: {"value": 8.901},
+        galil_rio.analog_in.ch0.name: {"value": 1.234},
+        galil_rio.analog_in.ch1.name: {"value": 2.345},
+        galil_rio.analog_in.ch2.name: {"value": 3.456},
+        galil_rio.analog_in.ch3.name: {"value": 4.567},
+        galil_rio.analog_in.ch4.name: {"value": 5.678},
+        galil_rio.analog_in.ch5.name: {"value": 6.789},
+        galil_rio.analog_in.ch6.name: {"value": 7.890},
+        galil_rio.analog_in.ch7.name: {"value": 8.901},
     }
     # All timestamps should be the same
     assert all(
-        ret["timestamp"] == read_values[galil_rio.an_ch0.name]["timestamp"]
+        ret["timestamp"] == read_values[galil_rio.analog_in.ch0.name]["timestamp"]
         for signal_name, ret in read_values.items()
     )
     # Check values
@@ -301,7 +306,7 @@ def test_galil_rio_signal_read(galil_rio):
 
     # Check communication command to socker
     assert galil_rio.controller.sock.buffer_put == [
-        b"MG@AN[0],@AN[1],@AN[2],@AN[3],@AN[4],@AN[5],@AN[6],@AN[7]\r"
+        b"MG@AN[0], @AN[1], @AN[2], @AN[3], @AN[4], @AN[5], @AN[6], @AN[7]\r"
     ]
 
     ###########
@@ -313,11 +318,11 @@ def test_galil_rio_signal_read(galil_rio):
 
     def value_callback(value, old_value, **kwargs):
         obj = kwargs.get("obj")
-        galil = obj.parent
+        galil = obj.parent.parent
         readback = galil.read()
         value_callback_buffer.append(readback)
 
-    galil_rio.an_ch0.subscribe(value_callback, run=False)
+    galil_rio.analog_in.ch0.subscribe(value_callback, run=False)
     galil_rio.controller.sock.buffer_recv = [b" 2.5 2.6 2.7 2.8 2.9 3.0 3.1 3.2"]
     expected_values = [2.5, 2.6, 2.7, 2.8, 2.9, 3.0, 3.1, 3.2]
 
@@ -327,13 +332,15 @@ def test_galil_rio_signal_read(galil_rio):
 
     # Should have used the cached value
     for walk in galil_rio.walk_signals():
-        walk.item._READ_TIMEOUT = 10  # Make sure cached read is used
-    ret = galil_rio.an_ch0.read()
+        walk.item._readback_timeout = 10  # Make sure cached read is used
+    ret = galil_rio.analog_in.ch0.read()
 
     # Should not trigger callback since value did not change
-    assert np.isclose(ret[galil_rio.an_ch0.name]["value"], 1.234)
+    assert np.isclose(ret[galil_rio.analog_in.ch0.name]["value"], 1.234)
     # Same timestamp as for another channel as this is cached read
-    assert np.isclose(ret[galil_rio.an_ch0.name]["timestamp"], galil_rio.an_ch7.timestamp)
+    assert np.isclose(
+        ret[galil_rio.analog_in.ch0.name]["timestamp"], galil_rio.analog_in.ch7.timestamp
+    )
     assert len(value_callback_buffer) == 0
 
     ##################
@@ -341,10 +348,10 @@ def test_galil_rio_signal_read(galil_rio):
     ##################
 
     # Now force a read from the controller
-    galil_rio._last_readback = 0  # Force read from controller
-    ret = galil_rio.an_ch0.read()
+    galil_rio.analog_in.ch0._last_readback = 0  # Force read from controller
+    ret = galil_rio.analog_in.ch0.read()
 
-    assert np.isclose(ret[galil_rio.an_ch0.name]["value"], 2.5)
+    assert np.isclose(ret[galil_rio.analog_in.ch0.name]["value"], 2.5)
 
     # Check callback invocation, but only 1 callback even with galil_rio.read() call in callback
     assert len(value_callback_buffer) == 1
@@ -352,7 +359,45 @@ def test_galil_rio_signal_read(galil_rio):
     assert np.isclose(values, expected_values).all()
     assert all(
         [
-            value["timestamp"] == value_callback_buffer[0][galil_rio.an_ch0.name]["timestamp"]
+            value["timestamp"]
+            == value_callback_buffer[0][galil_rio.analog_in.ch0.name]["timestamp"]
             for value in value_callback_buffer[0].values()
         ]
     )
+
+
+def test_galil_rio_digital_out_signal(galil_rio):
+    """
+    Test that the Galil RIO digital output signal can be set correctly.
+    """
+    ## Test Read from digital output channels
+    buffer_receive = []
+    excepted_put_buffer = []
+    for ii in range(galil_rio.digital_out.ch0._NUM_DIGITAL_OUTPUT_CHANNELS):
+        cmd = f"MG@OUT[{ii}]\r".encode()
+        excepted_put_buffer.append(cmd)
+        recv = " 1.000".encode()
+        buffer_receive.append(recv)
+
+    galil_rio.controller.sock.buffer_recv = buffer_receive  # Mock response for readback
+
+    digital_read = galil_rio.read_configuration()  # Read to populate readback values
+
+    for walk in galil_rio.digital_out.walk_signals():
+        assert np.isclose(digital_read[walk.item.name]["value"], 1.0)
+
+    assert galil_rio.controller.sock.buffer_put == excepted_put_buffer
+
+    # Test writing to digital output channels
+    galil_rio.controller.sock.buffer_put = []  # Clear buffer put
+    galil_rio.controller.sock.buffer_recv = [b":"]  # Mock response for readback
+
+    # Set digital output channel 0 to high
+    galil_rio.digital_out.ch0.put(1)
+    assert galil_rio.controller.sock.buffer_put == [b"SB0\r"]
+
+    # Set digital output channel 0 to low
+    galil_rio.controller.sock.buffer_put = []  # Clear buffer put
+    galil_rio.controller.sock.buffer_recv = [b":"]  # Mock response for readback
+    galil_rio.digital_out.ch0.put(0)
+    assert galil_rio.controller.sock.buffer_put == [b"CB0\r"]