bec/bec_widgets
1
0
Fork 0
mirror of https://github.com/bec-project/bec_widgets.git synced 2026-05-05 06:16:32 +02:00
Code Activity

refactor: address code review - specific exceptions and shared fixture

Browse Source 
Agent-Logs-Url: https://github.com/bec-project/bec_widgets/sessions/872a29f8-acdf-42e5-94b9-bad871aef4a0

Co-authored-by: wyzula-jan <133381102+wyzula-jan@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-04-30 08:31:58 +00:00
committed by GitHub
parent 5c29be4383
commit f299537fc3
2 changed files with 21 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bec_widgets/widgets/containers/dock_area/dock_area.py
+1 -1
View File
@@ -402,7 +402,7 @@ class BECDockArea(DockAreaWidget):
# Build plugin widget menu (only shown when plugin widgets are available)
try:
plugin_widgets_dict = get_all_plugin_widgets().as_dict()
except Exception:
except (ImportError, AttributeError, RuntimeError):
logger.warning("Failed to load plugin widgets for toolbar menu.", exc_info=True)
plugin_widgets_dict = {}
plugin_actions: dict[str, tuple[str, str, str]] = {
tests/unit_tests/test_dock_area.py
+20 -24
View File
@@ -44,6 +44,22 @@ from bec_widgets.widgets.plots.waveform.waveform import Waveform
from .client_mocks import mocked_client
@pytest.fixture
def fake_plugin_widget_cls():
"""Return a fake plugin widget class for use in toolbar plugin menu tests."""
from bec_widgets.utils.bec_widget import BECWidget
from qtpy.QtWidgets import QWidget as _QWidget
class FakePluginWidget(BECWidget, _QWidget):
ICON_NAME = "star"
PLUGIN = True
def __init__(self, parent=None, **kwargs):
super().__init__(parent=parent, **kwargs)
return FakePluginWidget
@pytest.fixture
def advanced_dock_area(qtbot, mocked_client):
"""Create an AdvancedDockArea instance for testing."""
@@ -1040,23 +1056,13 @@ class TestToolbarFunctionality:
# Verify no "menu_plugins" bundle exists in the toolbar
assert "menu_plugins" not in widget.toolbar.bundles
def test_plugin_menu_shown_when_plugins_available(self, qtbot, mocked_client):
def test_plugin_menu_shown_when_plugins_available(self, qtbot, mocked_client, fake_plugin_widget_cls):
"""Test that the plugin menu is shown when plugin widgets are available."""
from bec_widgets.utils.bec_widget import BECWidget
from qtpy.QtWidgets import QWidget as _QWidget
class FakePluginWidget(BECWidget, _QWidget):
ICON_NAME = "star"
PLUGIN = True
def __init__(self, parent=None, **kwargs):
super().__init__(parent=parent, **kwargs)
with patch(
"bec_widgets.widgets.containers.dock_area.dock_area.get_all_plugin_widgets"
) as mock_plugins:
container_mock = MagicMock()
container_mock.as_dict.return_value = {"FakePluginWidget": FakePluginWidget}
container_mock.as_dict.return_value = {"FakePluginWidget": fake_plugin_widget_cls}
mock_plugins.return_value = container_mock
widget = BECDockArea(client=mocked_client)
@@ -1071,23 +1077,13 @@ class TestToolbarFunctionality:
assert plugin_entry[2] == "FakePluginWidget" # widget type name
assert "menu_plugins" in widget.toolbar.bundles
def test_plugin_menu_action_triggers_new(self, qtbot, mocked_client):
def test_plugin_menu_action_triggers_new(self, qtbot, mocked_client, fake_plugin_widget_cls):
"""Test that clicking a plugin menu action creates a new dock with the plugin widget."""
from bec_widgets.utils.bec_widget import BECWidget
from qtpy.QtWidgets import QWidget as _QWidget
class FakePluginWidget(BECWidget, _QWidget):
ICON_NAME = "star"
PLUGIN = True
def __init__(self, parent=None, **kwargs):
super().__init__(parent=parent, **kwargs)
with patch(
"bec_widgets.widgets.containers.dock_area.dock_area.get_all_plugin_widgets"
) as mock_plugins:
container_mock = MagicMock()
container_mock.as_dict.return_value = {"FakePluginWidget": FakePluginWidget}
container_mock.as_dict.return_value = {"FakePluginWidget": fake_plugin_widget_cls}
mock_plugins.return_value = container_mock
widget = BECDockArea(client=mocked_client)