Merge pull request #78 from tiqi-group/feat/removes_private_attr_set_warning

Feat: removes warning if private attribute is set

pyproject.toml

@@ -82,7 +82,7 @@ ignore = [
     "PERF203",  # try-except-in-loop
 ]
 extend-exclude = [
-  "docs", "frontend"
+  "docs", "frontend", "tests"
 ]
 
 [tool.ruff.lint.mccabe]

src/pydase/data_service/data_service.py

@@ -67,9 +67,6 @@ class DataService(rpyc.Service, AbstractDataService):
         # Check and warn for unexpected type changes in attributes
         self._warn_on_type_change(__name, __value)
 
-        # Warn if setting private attributes
-        self._warn_on_private_attr_set(__name)
-
         # every class defined by the user should inherit from DataService if it is
         # assigned to a public attribute
         if not __name.startswith("_"):
@@ -103,15 +100,6 @@ class DataService(rpyc.Service, AbstractDataService):
             )
         )
 
-    def _warn_on_private_attr_set(self, attr_name: str) -> None:
-        if attr_name.startswith(f"_{self.__class__.__name__}__"):
-            logger.warning(
-                "Warning: You should not set private but rather protected attributes! "
-                "Use %s instead of %s.",
-                attr_name.replace(f"_{self.__class__.__name__}__", "_"),
-                attr_name.replace(f"_{self.__class__.__name__}__", "__"),
-            )
-
     def __check_instance_classes(self) -> None:
         for attr_name, attr_value in get_class_and_instance_attributes(self).items():
             # every class defined by the user should inherit from DataService if it is

tests/utils/test_warnings.py

@@ -34,20 +34,6 @@ def test_instance_attr_inheritance_warning(caplog: LogCaptureFixture) -> None:
     ) in caplog.text
 
 
-def test_private_attribute_warning(caplog: LogCaptureFixture) -> None:
-    class ServiceClass(DataService):
-        def __init__(self) -> None:
-            super().__init__()
-            self.__something = ""
-
-    ServiceClass()
-
-    assert (
-        " Warning: You should not set private but rather protected attributes! Use "
-        "_something instead of __something." in caplog.text
-    )
-
-
 def test_protected_attribute_warning(caplog: LogCaptureFixture) -> None:
     class SubClass:
         name = "Hello"