ITQC/pydase
24
0
Fork 0
mirror of https://github.com/tiqi-group/pydase.git synced 2025-04-20 08:20:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: replaces single quote with double quote in PropertyObserver

Browse Source 
When collecting collection item property dependencies, the
PropertyObserver was adding dict keys in single quotes instead of double
quotes.
This commit is contained in:
Mose Müller 2024-12-20 14:18:45 +01:00
parent 17b2ad32e5
commit 090b8acd44
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/pydase/observer_pattern/observer/property_observer.py
View File

@ -100,7 +100,7 @@ class PropertyObserver(Observer):
elif isinstance(collection, dict): elif isinstance(collection, dict):
for key, val in collection.items(): for key, val in collection.items():
if isinstance(val, Observable): if isinstance(val, Observable):
new_prefix = f"{parent_path}['{key}']" new_prefix = f'{parent_path}["{key}"]'
deps.update( deps.update(
self._get_properties_and_their_dependencies(val, new_prefix) self._get_properties_and_their_dependencies(val, new_prefix)
) )

4
tests/data_service/test_data_service_observer.py
View File

@ -167,8 +167,8 @@ def test_normalized_attr_path_in_dependent_property_changes(
state_manager = StateManager(service=service_instance) state_manager = StateManager(service=service_instance)
observer = DataServiceObserver(state_manager=state_manager) observer = DataServiceObserver(state_manager=state_manager)
assert observer.property_deps_dict["service_dict['one']._prop"] == [ assert observer.property_deps_dict['service_dict["one"]._prop'] == [
"service_dict['one'].prop" 'service_dict["one"].prop'
] ]
# We can use dict key path encoded with double quotes # We can use dict key path encoded with double quotes