From 090b8acd448f904509704725916f6fef1e5365c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mose=20M=C3=BCller?= Date: Fri, 20 Dec 2024 14:18:45 +0100 Subject: [PATCH] fix: replaces single quote with double quote in PropertyObserver When collecting collection item property dependencies, the PropertyObserver was adding dict keys in single quotes instead of double quotes. --- src/pydase/observer_pattern/observer/property_observer.py | 2 +- tests/data_service/test_data_service_observer.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pydase/observer_pattern/observer/property_observer.py b/src/pydase/observer_pattern/observer/property_observer.py index 0e8ae4c..a686765 100644 --- a/src/pydase/observer_pattern/observer/property_observer.py +++ b/src/pydase/observer_pattern/observer/property_observer.py @@ -100,7 +100,7 @@ class PropertyObserver(Observer): elif isinstance(collection, dict): for key, val in collection.items(): if isinstance(val, Observable): - new_prefix = f"{parent_path}['{key}']" + new_prefix = f'{parent_path}["{key}"]' deps.update( self._get_properties_and_their_dependencies(val, new_prefix) ) diff --git a/tests/data_service/test_data_service_observer.py b/tests/data_service/test_data_service_observer.py index 347ff54..9b7e7e9 100644 --- a/tests/data_service/test_data_service_observer.py +++ b/tests/data_service/test_data_service_observer.py @@ -167,8 +167,8 @@ def test_normalized_attr_path_in_dependent_property_changes( state_manager = StateManager(service=service_instance) observer = DataServiceObserver(state_manager=state_manager) - assert observer.property_deps_dict["service_dict['one']._prop"] == [ - "service_dict['one'].prop" + assert observer.property_deps_dict['service_dict["one"]._prop'] == [ + 'service_dict["one"].prop' ] # We can use dict key path encoded with double quotes