ITQC/containernetworking-plugins
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 34 Wiki Activity
1,649 Commits 6 Branches 48 Tags
c347755f87ece51792712ea5ca827274ef9370fe
Commit Graph

1649 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Etienne Champetier
c347755f87 Fix ValidateExpectedRoute with non default routes and nil GW 
Using ptp plugin with non default routes, we get the following error
when cri-o call CheckNetworkList():
```
Expected Route {Dst:{IP:198.18.128.0 Mask:ffff8000} GW:<nil>} not found in routing table
```
Using cniVersion 0.3.1 to bypass the check, we can see that the
route is added with a gateway
```
$ ip r
198.18.0.0/17 via 198.18.0.1 dev eth0 src 198.18.3.102
198.18.0.1 dev eth0 scope link src 198.18.3.102
198.18.128.0/17 via 198.18.0.1 dev eth0
```

If GW is nil only check if we have a route with a DST that matches, and
ignore the GW.

Fixes #886
Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
 2023-04-20 15:24:20 -04:00
Casey Callendrello
9f1f9a588b Merge pull request #875 from mlguerrero12/adddefaultvlanparam 
Add parameter to disable default vlan
 2023-04-17 17:47:34 +02:00
Casey Callendrello
71aa710196 Merge pull request #873 from maiqueb/mac-spoof-remove-index-when-adding-rules 
bridge, spoof check: remove drop rule index
 2023-04-17 17:07:11 +02:00
dependabot[bot]
4a6147a155 Merge pull request #881 from containernetworking/dependabot/go_modules/golang.org/x/sys-0.7.0 2023-04-05 19:24:31 +00:00
dependabot[bot]
435ef2235d build(deps): bump golang.org/x/sys from 0.6.0 to 0.7.0 
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.6.0 to 0.7.0.
- [Release notes](https://github.com/golang/sys/releases)
- [Commits](https://github.com/golang/sys/compare/v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-04-05 19:14:01 +00:00
Casey Callendrello
43db9cc063 Merge pull request #879 from squeed/bump-deps 
go.mod: bump all deps
 2023-04-05 21:13:05 +02:00
Marcelo Guerrero Viveros
821982da1c Add parameter to disable default vlan 
This new parameter allows users to remove the default vlan

Fixes: #667
Signed-off-by: Marcelo Guerrero Viveros <marguerr@redhat.com>
 2023-04-05 18:20:40 +02:00
Miguel Duarte Barroso
cac8230e7c bridge, spoof check: remove drop rule index 
Rules are appendend by default, thus using an index is redundant.
Using an index also requires the full NFT cache, which causes a CNI ADD
to be extremely slow.

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
 2023-04-04 17:10:08 +02:00
Casey Callendrello
bc5f3defe7 go.mod: bump all deps 
Bump all transitive and direct dependencies.

Signed-off-by: Casey Callendrello <c1@caseyc.net>
 2023-04-04 16:31:14 +02:00
Casey Callendrello
47a4319462 Merge pull request #861 from containernetworking/dependabot/github_actions/actions/setup-go-4 
build(deps): bump actions/setup-go from 3 to 4
 2023-04-04 16:27:44 +02:00
Casey Callendrello
68a661999a Merge pull request #870 from containernetworking/dependabot/github_actions/actions/stale-8 
build(deps): bump actions/stale from 7 to 8
 2023-04-04 16:27:10 +02:00
Casey Callendrello
63235a2531 Merge pull request #878 from maiqueb/fix-ginkgo-linter-warnings 
linter: fix ginkgolinter errors
 2023-04-04 16:23:41 +02:00
Miguel Duarte Barroso
7bbd4d19e9 linter: fix ginkgolinter errors 
Use:
- `BeEmpty` instead of `HaveLen(0)`
- `Expect(x).To(BeZero())` instead of `Expect(x == 0).To(BeTrue())`

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
 2023-04-04 16:09:01 +02:00
Casey Callendrello
deec68747e Merge pull request #853 from mmorel-35/ginkgolinter 
enable ginkgolinter linter
 2023-04-04 15:24:20 +02:00
Casey Callendrello
6f6345ca05 Merge pull request #871 from mlguerrero12/fixwastedassignlinter 
Fix wastedassign linter errors
 2023-04-04 15:23:28 +02:00
Marcelo Guerrero Viveros
6c0d73ecc0 Fix wastedassign linter errors 
Signed-off-by: Marcelo Guerrero Viveros <marguerr@redhat.com>
 2023-03-27 18:42:49 +02:00
Dan Williams
8813bfea7b Merge pull request #855 from mmorel-35/linters 
enable durationcheck,  predeclared, unconvert, unused and wastedassign linters
 2023-03-27 10:53:34 -05:00
Dan Williams
16d05ec100 Merge pull request #867 from mlguerrero12/fixlinters 
Fix revive linter errors
 2023-03-27 10:49:33 -05:00
dependabot[bot]
086f7eb7a1 build(deps): bump actions/stale from 7 to 8 
Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/stale/compare/v7...v8)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-03-27 03:04:07 +00:00
Marcelo Guerrero Viveros
d71d0f2da1 Fix revive linter errors 
Golangci-lint is now running version 1.52.1. This introduced some errors.

Signed-off-by: Marcelo Guerrero Viveros <marguerr@redhat.com>
 2023-03-24 21:04:39 +01:00
dependabot[bot]
00e0d3b758 build(deps): bump actions/setup-go from 3 to 4 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-03-20 03:01:39 +00:00
Matthieu MOREL
2fb0efe8a3 enable durationcheck, predeclared, unconvert, unused and wastedassign linters 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-03-16 07:29:37 +01:00
Casey Callendrello
3bc00017e3 Merge pull request #854 from mmorel-35/clean-linters 
remove govet and gofmt from test_linux.sh
 2023-03-14 11:49:37 +01:00
Matthieu MOREL
c0fe3b7bde remove govet and gofmt from test_linux.sh 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-03-13 22:47:17 +00:00
Matthieu MOREL
09f36a295d enable ginkgolinter linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-03-13 22:27:21 +00:00
Casey Callendrello
d3ee71f240 Merge pull request #843 from mmorel-35/golangci-lint 
ci(lint): setup golangci-lint
 2023-03-13 22:26:32 +01:00
Matthieu MOREL
a02bf4b463 enable revive linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-03-13 17:59:41 +01:00
Matthieu MOREL
79f524689c enable gocritic linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-03-13 17:59:33 +01:00
Matthieu MOREL
5a7619c019 enable gosimple linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-03-13 17:59:31 +01:00
Matthieu MOREL
709e775b13 enable nonamedreturns linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-03-13 17:59:28 +01:00
Matthieu MOREL
3a04eb00bb enable ineffassign linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-03-06 11:51:40 +01:00
Matthieu MOREL
16ba4222bc enable contextcheck linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-03-06 11:23:07 +01:00
Matthieu MOREL
177e0bf2d9 enable staticcheck linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-03-02 11:06:22 +01:00
Matthieu MOREL
d12b81dec5 ci(lint): setup golangci-lint 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-03-01 06:55:40 +00:00
Casey Callendrello
86e39cfe3c Merge pull request #836 from mmorel-35/yamllint 
ci(lint): setup yamllint linter
 2023-02-28 16:35:10 +01:00
Matthieu MOREL
6223674f25 ci(lint): setup yamllint linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-02-25 12:10:11 +00:00
Dan Williams
36e1e162fa Merge pull request #812 from liornoy/ginkgov2 
Update ginkgo to v2
 2023-02-20 10:58:24 -06:00
Dan Williams
286064b9ec Merge pull request #831 from mlguerrero12/fixerrorignored 
Fix overwritten error var in getMTUByName
 2023-02-20 10:13:34 -06:00
Marcelo Guerrero Viveros
9ee4d3225d Fix overwritten error var in getMTUByName 
this prevents the error to be lost which was causing the
panic while accesing a nil var.

Fix #830

Signed-off-by: Marcelo Guerrero Viveros <marguerr@redhat.com>
 2023-02-16 12:28:17 +01:00
liornoy
2d1005ec02 Update tests to utilize ginkgo/v2 
This commit updates the import of ginkgo to v2 in
all of the tests.

Signed-off-by: liornoy <lnoy@redhat.com>
Co-authored-by: Sascha Grunert <sgrunert@redhat.com>
 2023-02-13 21:15:18 +02:00
liornoy
23c2134110 Update ginkgo to v2 in go.mod, go.sum, vendor 
This commit updates ginkgo to v2.
Note that because ginkgo/v2 requires go1.18, it was
updated as well.

Signed-off-by: liornoy <lnoy@redhat.com>
Co-authored-by: Sascha Grunert <sgrunert@redhat.com>
 2023-02-13 21:15:18 +02:00
Casey Callendrello
fb92605570 Merge pull request #784 from mmirecki/tap-plugin 
Tap plugin
 2023-02-13 17:26:06 +01:00
mmirecki
01d0031487 Tap plugin 
This PR adds a plugin to create tap devices.
The plugin adds a tap device to the container.

The plugin has a workaround for a golang netlink library
which does not allow for tap devices with no owner/group
to be created. When no tap owner/group is requested, the
plugin will fall back to using the ip tool for creating
the tap device. A fix to the golang netlink lib is pending.

Signed-off-by: mmirecki <mmirecki@redhat.com>
 2023-02-13 17:14:46 +01:00
Dan Williams
98e01b7c80 Merge pull request #824 from containernetworking/dependabot/go_modules/github.com/onsi/gomega-1.26.0 
build(deps): bump github.com/onsi/gomega from 1.24.2 to 1.26.0
 2023-02-13 10:09:15 -06:00
dependabot[bot]
9a2f763345 build(deps): bump github.com/onsi/gomega from 1.24.2 to 1.26.0 
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.24.2 to 1.26.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.24.2...v1.26.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-02-13 10:23:59 +00:00
Casey Callendrello
98359ff8b4 Merge pull request #828 from containernetworking/dependabot/go_modules/golang.org/x/sys-0.5.0 
build(deps): bump golang.org/x/sys from 0.4.0 to 0.5.0
 2023-02-13 11:23:00 +01:00
dependabot[bot]
29e6486154 build(deps): bump golang.org/x/sys from 0.4.0 to 0.5.0 
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.4.0 to 0.5.0.
- [Release notes](https://github.com/golang/sys/releases)
- [Commits](https://github.com/golang/sys/compare/v0.4.0...v0.5.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-02-13 03:22:30 +00:00
Casey Callendrello
bbf47c1083 Merge pull request #814 from mmirecki/macvlan_incontainermaster 
Add support for in-container master for macvlans
 2023-02-08 12:55:44 +01:00
Dan Williams
5d02d91c96 Merge pull request #813 from mmirecki/ipvlan_incontainermaster 
Add support for in-container master for ipvlan
 2023-02-06 09:49:06 -06:00
Dan Williams
755714d716 Merge pull request #781 from mmirecki/vlan_incontainermaster 
Add support for in-container master for vlans
 2023-02-06 09:47:58 -06:00