ITQC/containernetworking-plugins
24
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 34 Wiki Activity
115 Commits 6 Branches 48 Tags
Commit Graph

115 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Casey Callendrello
61d3f4515a testing: test invocation of newer plugins with an older libcni 2016-10-25 16:33:35 +02:00
Gabe Rosenhouse
cfb2ff3dcd skel tests: correct name of CNI_CONTAINERID in tests of env vars 2016-10-16 17:18:57 -07:00
Gabe Rosenhouse
b07b226c97 testing: adds basic test of backwards compatibility 2016-10-02 22:18:53 -07:00
Gabe Rosenhouse
f721eaf6ed skel: use named constant for Incompatible CNI Version error code 2016-09-19 13:25:33 -07:00
Gabe Rosenhouse
04ba7c7761 versioning: plugins require version match with config 
infer version 0.1.0 when config is missing an explicit "cniVersion" field
 2016-09-19 13:00:49 -07:00
Gabe Rosenhouse
1e4e8fdb5d versioning: add basic version decode for network config 2016-09-19 12:57:08 -07:00
Gabe Rosenhouse
921292ff77 skel: Plugins require a cniVersion in the NetConf 2016-09-18 21:30:57 -07:00
Gabe Rosenhouse
de91f31ae7 versioning: revert spec version to 0.2.0 2016-09-06 15:37:42 -04:00
Gabe Rosenhouse
bf6948da19 versioning: misc cleanups 
highlights:
 - NetConf struct finally includes cniVersion field
 - improve test coverage of current version report behavior
 - godoc a few key functions
 - allow tests to control version list reported by no-op plugin
 2016-09-06 15:35:58 -04:00
Gabe Rosenhouse
2f97407396 invoke: better name and unit test coverage for GetVersionInfo 2016-09-02 16:39:01 -04:00
Gabe Rosenhouse
f467134838 invoke: correctly infer version for 0.1.0-vintage plugins 
Older plugins return a known error when issued the VERSION command.
Capture this error and report it as a 0.1.0 version plugin.
 2016-09-02 16:02:07 -04:00
Gabe Rosenhouse
2142c076ab versioning: adds tooling to compile a program against a given old CNI version 
Allows us to write tests that cover interactions between components of
differing versions
 2016-09-02 16:02:02 -04:00
Gabe Rosenhouse
bd3ade0c54 pkg/invoke: refactor plugin exec and backfill unit tests 2016-09-02 15:59:25 -04:00
Gabe Rosenhouse
383c84031e versioning: document meaning of 'Legacy' version support 2016-09-02 11:26:17 -04:00
Gabe Rosenhouse
b1e254d901 versioning: plugins report a list of supported versions 
Further progress on versioning support (Issue #266).
Bump CNI spec version to 0.3.0
 2016-09-02 11:26:17 -04:00
Gabe Rosenhouse
63ace9e496 Merge pull request #293 from rosenhouse/backfill-invoke-exec-tests 
Backfill tests for plugin execution
 2016-08-31 20:49:08 -04:00
Dan Williams
26241a517a Merge pull request #290 from asridharan/dcos 
Fixed the check for network namespace path.
 2016-08-31 18:19:02 -05:00
Avinash Sridharan
1ce5e54e99 pkg/ns: fixed the check for network namespace path. 
The expectation on older kernels (< 3.19) was to have the network
namespace always be a directory. This is not true if the network
namespace is bind mounted to a file, and will make the plugin fail
erroneously in such cases. The fix is to remove this assumption
completely and just do a basic check on the file system types being
returned.

Fixes #288
 2016-08-31 21:41:00 +00:00
Tom Denham
31ef82276a pkg/ip: Ensure that SetupVeth returns correct hostVeth 
The veth is moved from the container NS to the host NS.
This is handled by the code that sets the link to UP but the wrong
hostVeth is returned to the calling code.
 2016-08-31 14:17:25 -07:00
Gabe Rosenhouse
0e675fa14f invoke: backfill tests for plugin execution 2016-08-30 23:52:47 -04:00
Tom Denham
415d707faf Merge pull request #267 from rosenhouse/version-cmd 
Adds VERSION command
 2016-08-12 15:06:22 -07:00
Prateek Gogia
3c1d4581c4 pkg/ip: Return correct error if container name provided exists, and test cases 
If interface name for a container provided by a user is already present,
Veth creation fails with incorrect error.
If os.IsExist error is returned by makeVethPair:
* Check for peer name, if exists generate another random peer name,
* else, IsExist error is due to container interface present, return error.

Fixes #155
 2016-08-11 18:51:03 +00:00
Stefan Junker
22a0ddc906 pkg/utils/hwaddr tests: cover v4 in v6 addr 2016-08-01 16:50:40 -07:00
Stefan Junker
00f27577d5 pkg/ip link_test: ensure SetHWAddrByIP has an effect 2016-07-22 15:34:54 -07:00
Stefan Junker
c317888ac5 pkg/ip: use iface name in SetHWAddrByIP 2016-07-22 15:34:53 -07:00
Stefan Junker
1a04d9abba pkg/ip tests: cover SetupVeth and DelLinkByName* 2016-07-22 15:34:53 -07:00
Stefan Junker
b6137de993 plugins: set MAC addresses based on IP 
This will give deterministic MAC addresses for all interfaces CNI
creates and manages the IP for:
* bridge: container veth and host bridge
* macvlan: container veth
* ptp: container veth and host veth
 2016-07-22 15:34:53 -07:00
Stefan Junker
c3e8563e77 pkg/utils/hwaddr: migrate code from IPAM pkg 2016-07-22 15:18:38 -07:00
Stefan Junker
7ea07a6405 pkg/ipam{,test}: improve error handling and tests 
* _suite.go and _test.go file should be in the same package, using the
  _test package for that, which requires some fields and methods to be
  exported
* Introduce error type for cleaner error handling
* test adaptions for error type checking
 2016-07-22 15:17:22 -07:00
Minhan Xia
75f1fa2260 add tests for generateHardwardAddr 2016-07-22 15:01:57 -07:00
Minhan Xia
c19b82efc2 configure mac address based on assigned ip 2016-07-22 14:57:52 -07:00
Gabe Rosenhouse
6496749565 plugins: adds new no-op plugin that may be used as a test-double 
Plugin can be configured to record all inputs and to respond with
arbitrary stdout or error message.  Will support upcoming integration
testing.
 2016-07-15 12:48:02 -07:00
Gabe Rosenhouse
728071e7d1 misc: fix up copyright dates 2016-07-14 16:09:27 -07:00
Gabe Rosenhouse
30c99d17cc pkg/skel: plugins now respond to VERSION command 
To support CNI spec versioning, plugins must be able to report version
information to container runtimes.
 2016-07-14 00:24:32 -04:00
Gabe Rosenhouse
eda79f7645 pkg/skel: improve error message for missing CNI_COMMAND env var 
This makes the error message for missing CNI_COMMAND consistent with
that of other required environment variables.
 2016-07-14 00:24:32 -04:00
Gabe Rosenhouse
f2b6ec0375 pkg/skel: missing env var log lines appear in stderr 
Previously, the log lines appeared in stdout before the JSON encoding of
the error message.  That would break JSON parsing of stdout.  Instead, we use
stderr for these unstructured logs, consistent with the CNI spec.
 2016-07-14 00:24:27 -04:00
Gabe Rosenhouse
3c43314926 pkg/skel: refactor to use dependency injection 
Extract dependencies on os to enable more complete unit test coverage
 2016-07-14 00:06:58 -04:00
Pengfei Ni
bd341ab5d1 pkg/ns: fix misspelling in comment 2016-06-14 09:52:58 -07:00
Stefan Junker
d48cb53715 pkg/types: cover string for unmarshal tests 2016-06-13 18:18:36 -07:00
Tom Denham
efc0f2987f pkg/types: Add UnmarshallableString type 
Allow strings to be unmarshalled for CNI_ARGS

CNI_ARGS uses types.LoadArgs to populate a struct.
The fields in the struct must meet the TextUnmarshaler interface.

This code adds a UnmarshallableString type to assist with this.
 2016-06-09 14:45:58 -07:00
Stefan Junker
3a4124d257 pkg/ns: introduce error types indicate NS verification 2016-05-27 13:50:16 +02:00
Stefan Junker
cfedcfd8f2 skel/test: add case for empty NETNS 2016-05-27 12:26:42 +02:00
Stefan Junker
5fe036b88a plugins: don't require CNI_NETNS for DEL command 
This will allow to free up the IPAM allocations when the caller doesn't
have access to the network namespace anymore, e.g. due to a reboot.
 2016-05-27 10:57:39 +02:00
Stefan Junker
d7de8d4f98 pkg/skel: allow arg requriements specified by CMD 2016-05-27 10:56:24 +02:00
Stefan Junker
2d47b0396d pkg/ns: consider PROCFS during NS verification 
This is an attempt to bring compatibility with Kernel <3.19, where NSFS
where PROCFS was used for network namespaces.
 2016-05-26 12:42:50 +02:00
Stefan Junker
ea073fc4c7 pkg/ns: test IsNSFS() 2016-05-24 22:30:49 +02:00
Stefan Junker
f64cfb84f8 pkg/ns: test case for rejecting a non-ns nspath 2016-05-24 22:30:49 +02:00
Stefan Junker
39eace3c38 pkg/ns: verify netns when initialized with GetNS 2016-05-24 22:30:49 +02:00
Stefan Junker
a8d1029294 pkg/ns: add tests cases for Close()'d NS 2016-05-24 21:15:51 +02:00
Stefan Junker
40440ec887 pkg/ns: don't allow operations after Close() 2016-05-24 20:52:00 +02:00