ITQC/containernetworking-plugins
24
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 34 Wiki Activity

Merge pull request #391 from beautytiger/dev-190925

Browse Source 
bugfix: defer after err check, or it may panic
This commit is contained in:
Bryan Boreham 2019-09-25 16:25:21 +01:00 committed by GitHub
commit e91889678b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/ipam/host-local/dns_test.go
View File

@ -65,12 +65,11 @@ options four
func parse(contents string) (*types.DNS, error) { func parse(contents string) (*types.DNS, error) {
f, err := ioutil.TempFile("", "host_local_resolv") f, err := ioutil.TempFile("", "host_local_resolv")
defer f.Close()
defer os.Remove(f.Name())
if err != nil { if err != nil {
return nil, err return nil, err
} }
defer f.Close()
defer os.Remove(f.Name())
if _, err := f.WriteString(contents); err != nil { if _, err := f.WriteString(contents); err != nil {
return nil, err return nil, err