From 8ec6bd6a42f422b84f1280323a52ae7f97384036 Mon Sep 17 00:00:00 2001 From: Guangming Wang Date: Wed, 25 Sep 2019 22:21:49 +0800 Subject: [PATCH] bugfix: defer after err check, or it may panic Signed-off-by: Guangming Wang --- plugins/ipam/host-local/dns_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/plugins/ipam/host-local/dns_test.go b/plugins/ipam/host-local/dns_test.go index 4f3a05fa..1b870026 100644 --- a/plugins/ipam/host-local/dns_test.go +++ b/plugins/ipam/host-local/dns_test.go @@ -65,12 +65,11 @@ options four func parse(contents string) (*types.DNS, error) { f, err := ioutil.TempFile("", "host_local_resolv") - defer f.Close() - defer os.Remove(f.Name()) - if err != nil { return nil, err } + defer f.Close() + defer os.Remove(f.Name()) if _, err := f.WriteString(contents); err != nil { return nil, err