Stupid error: Minutes and seconds start from 0, not 1.

Fix or rather workaround for MinGW and maybe other systems without localtime_r function
function pointer type problem fixed
2015-02-10 16:48:39 +00:00 · 2014-06-24 13:20:19 +00:00 · 2014-06-24 13:19:36 +00:00 · 2014-05-02 15:10:18 +00:00 · 2014-05-02 15:09:49 +00:00 · 2014-05-02 15:08:36 +00:00
36 changed files with 146 additions and 73 deletions
--- a/doc/PSI.gif
+++ b/doc/PSI.gif
--- a/doc/PSI.png
+++ b/doc/PSI.png
--- a/doc/aai.html
+++ b/doc/aai.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: aai Records</h1>
+<h1>aai Records</h1>
 <p>
 <b>Note:</b> aai record support is disabled per default.
 Enable it in <code>src/CONFIG_STREAM</code>.
--- a/doc/aao.html
+++ b/doc/aao.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: aao Records</h1>
+<h1>aao Records</h1>
 <p>
 <b>Note:</b> aao record support is disabled per default.
 Enable it in <code>src/CONFIG_STREAM</code>.
--- a/doc/ai.html
+++ b/doc/ai.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: ai Records</h1>
+<h1>ai Records</h1>

 <h2>Normal Operation</h2>
 <p>
--- a/doc/ao.html
+++ b/doc/ao.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: ao Records</h1>
+<h1>ao Records</h1>

 <h2>Normal Operation</h2>
 <p>
--- a/doc/bi.html
+++ b/doc/bi.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: bi Records</h1>
+<h1>bi Records</h1>

 <h2>Normal Operation</h2>
 <p>
--- a/doc/bo.html
+++ b/doc/bo.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: bo Records</h1>
+<h1>bo Records</h1>

 <h2>Normal Operation</h2>
 <p>
--- a/doc/calcout.html
+++ b/doc/calcout.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: calcout Records</h1>
+<h1>calcout Records</h1>

 <p>
 <b>Note:</b> Device support for calcout records is only available for
--- a/doc/epics3_13.html
+++ b/doc/epics3_13.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: Using EPICS 3.13</h1>
+<h1>Using EPICS 3.13</h1>

 <a name="pre"></a>
 <h2>1. Prerequisites</h2>
--- a/doc/formatconverter.html
+++ b/doc/formatconverter.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: Format Converter API</h1>
+<h1>Format Converter API</h1>

 <a name="class"></a>
 <h2>Converter Class</h2>
--- a/doc/formats.html
+++ b/doc/formats.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: Format Converters</h1>
+<h1>Format Converters</h1>

 <a name="syntax"></a>
 <h2>1. Format Syntax</h2>
--- a/doc/longin.html
+++ b/doc/longin.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: longin Records</h1>
+<h1>longin Records</h1>

 <h2>Normal Operation</h2>
 <p>
--- a/doc/longout.html
+++ b/doc/longout.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: longout Records</h1>
+<h1>longout Records</h1>

 <h2>Normal Operation</h2>
 <p>
--- a/doc/makepdf
+++ b/doc/makepdf
@ -0,0 +1,35 @@
+PAGES="
+index.html
+setup.html
+epics3_13.html
+protocol.html
+formats.html
+processing.html
+recordtypes.html
+aai.html
+aao.html
+ai.html
+ao.html
+bi.html
+bo.html
+mbbi.html
+mbbo.html
+mbbiDirect.html
+mbboDirect.html
+stringin.html
+stringout.html
+longin.html
+longout.html
+waveform.html
+calcout.html
+scalcout.html
+tipsandtricks.html
+recordinterface.html
+businterface.html
+formatconverter.html
+osinterface.html
+"
+
+rm -f stream.pdf
+wkhtmltopdf --print-media-type --dpi 1200 --zoom 0.85 --page-size Letter \
+$PAGES stream.pdf
--- a/doc/mbbi.html
+++ b/doc/mbbi.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: mbbi Records</h1>
+<h1>mbbi Records</h1>

 <h2>Normal Operation</h2>
 <p>
--- a/doc/mbbiDirect.html
+++ b/doc/mbbiDirect.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: mbbiDirect Records</h1>
+<h1>mbbiDirect Records</h1>

 <h2>Normal Operation</h2>
 <p>
--- a/doc/mbbo.html
+++ b/doc/mbbo.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: mbbo Records</h1>
+<h1>mbbo Records</h1>

 <h2>Normal Operation</h2>
 <p>
--- a/doc/mbboDirect.html
+++ b/doc/mbboDirect.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: mbboDirect Records</h1>
+<h1>mbboDirect Records</h1>

 <h2>Normal Operation</h2>
 <p>
--- a/doc/osinterface.html
+++ b/doc/osinterface.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: Operating System API</h1>
+<h1>Operating System API</h1>

 <h2>Sorry, this documentation is still missing.</h2>

--- a/doc/processing.html
+++ b/doc/processing.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: Record Processing</h1>
+<h1>Record Processing</h1>

 <a name="proc"></a>
 <h2>1. Normal Processing</h2>
--- a/doc/protocol.html
+++ b/doc/protocol.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: Protocol Files</h1>
+<h1>Protocol Files</h1>
 <a name="gen"></a>
 <h2>1. General Information</h2>
 <p>
--- a/doc/recordinterface.html
+++ b/doc/recordinterface.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: Record API</h1>
+<h1>Record API</h1>

 <h2>Sorry, this documentation is still missing.</h2>

--- a/doc/recordtypes.html
+++ b/doc/recordtypes.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: Record Types</h1>
+<h1>Record Types</h1>

 <h2>Supported Record Types</h2>
 <p>
--- a/doc/scalcout.html
+++ b/doc/scalcout.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: scalcout Records</h1>
+<h1>scalcout Records</h1>

 <p>
 <b>Note:</b> The scalcout record is part of the <i>calc</i> module of
--- a/doc/setup.html
+++ b/doc/setup.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: Setup</h1>
+<h1>Setup</h1>

 <a name="pre"></a>
 <h2>1. Prerequisites</h2>
--- a/doc/stream.css
+++ b/doc/stream.css
@ -5,8 +5,9 @@ a:hover   {color: #FF0000;}
 body {
    margin-right:1em;
    margin-left:15em;
-    margin-top:11ex;
-    font-family: "HelveticaNeue-Light", "Helvetica Neue Light", "Helvetica Neue", Helvetica, Arial, "Lucida Grande", sans-serif;
+    margin-top:70px;
+    padding-top:1px;
+    font-family: Helvetica, Arial, sans-serif;
    font-size:14px;
    background-color:#ffffff;
 }
@ -30,26 +31,26 @@ dt {
 }

 h1 {
-    font-size:225%;
+    font-size:250%;
    margin-top:0;
    font-style:italic;
-    font-family:serif;
+    font-weight:bold;
+    font-family:"Times New Roman", serif;
    text-align:center;
    position:fixed;
    top:0;
    left:0;
    width:100%;
-    min-height:60px;
-    height: 4ex;
    line-height:190%;
    background-color:white;
-    border-top:6px solid #1b4486;
-    border-bottom:4px solid #1b4486;
+    border-width:0;
+    border-bottom:3px solid #1b4486;
    white-space:nowrap;
-    background-image:url(PSI.gif);
+    background-image:url(PSI.png);
    background-repeat:no-repeat;
-    background-position:10px 2px;
-    text-shadow: .1em .1em .1em lightgray;           
+    background-position:10px 5px;
+    text-shadow:.1em .1em .1em darkgray;
+    box-shadow:0 .3em .1em -.2em darkgray;
 }

 h2 {
@ -91,7 +92,7 @@ code {
    position:fixed;
    left:0;
    top:0;
-    padding-top:9ex;
+    padding-top:70px;
    width:14em;
    height:100%;
    border-style:solid;
@ -115,13 +116,9 @@ a[target=ex]:hover:after {
 }

@media print {
-  a:link    {color: black; text-decoration:none;}
-  a:visited {color: black; text-decoration:none;}
-  a:hover   {color: black; text-decoration:none;}
-  a[target=ex] {text-decoration:underline;}
+  a:link    {text-decoration:none;}
  a[target=ex]:after {content:" [" attr(href) "]";}
-  code      {color: black; }
-  body      {margin-left:10px;}
-  h1        {position:absolute;}
+  body      {margin:0 4em;}
+  h1        {position:relative; background-position:0 0;}
  #navleft  {display:none;}
 }
--- a/doc/stringin.html
+++ b/doc/stringin.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: stringin Records</h1>
+<h1>stringin Records</h1>

 <h2>Normal Operation</h2>
 <p>
--- a/doc/stringout.html
+++ b/doc/stringout.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: stringout Records</h1>
+<h1>stringout Records</h1>

 <h2>Normal Operation</h2>
 <p>
--- a/doc/tipsandtricks.html
+++ b/doc/tipsandtricks.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: Tips and Tricks</h1>
+<h1>Tips and Tricks</h1>

 <a name="argvar"></a>
 <h2>I have many almost identical protocols</h2>
--- a/doc/waveform.html
+++ b/doc/waveform.html
@ -10,7 +10,7 @@
 </head>
 <body>
 <iframe src="nav.html" id="navleft"></iframe>
-<h1>StreamDevice: waveform Records</h1>
+<h1>waveform Records</h1>

 <h2>Normal Operation</h2>
 <p>
--- a/src/AsynDriverInterface.cc
+++ b/src/AsynDriverInterface.cc
@ -371,9 +371,11 @@ supportsEvent()
                intrCallbackInt32, this, &intrPvtInt32);
            return true;
        }
-        error("%s: port does not allow to register for "
+        const char *portname;
+        pasynManager->getPortName(pasynUser, &portname);
+        error("%s: port %s does not allow to register for "
            "Int32 interrupts: %s\n",
-            clientName(), pasynUser->errorMessage);
+            clientName(), portname, pasynUser->errorMessage);
        pasynInt32 = NULL;
        intrPvtInt32 = NULL;
    }
@ -397,9 +399,11 @@ supportsEvent()
                intrCallbackUInt32, this, 0xFFFFFFFF, &intrPvtInt32);
            return true;
        }
-        error("%s: port does not allow to register for "
+        const char *portname;
+        pasynManager->getPortName(pasynUser, &portname);
+        error("%s: port %s does not allow to register for "
            "UInt32 interrupts: %s\n",
-            clientName(), pasynUser->errorMessage);
+            clientName(), portname, pasynUser->errorMessage);
        pasynUInt32 = NULL;
        intrPvtUInt32 = NULL;
    }
@ -662,15 +666,18 @@ writeHandler()
    size_t written = 0;

    pasynUser->timeout = 0;
-    if (pasynGpib)
-         pasynOctet->flush(pvtOctet, pasynUser);
-    else
+    if (!pasynGpib)
    // discard any early input, but forward it to potential async records
    // thus do not use pasynOctet->flush()
+    // unfortunately we cannot do this with GPIB because addressing a device as talker
+    // when it has nothing to say is an error. Also timeout=0 does not help here (would need
+    // a change in asynGPIB), thus use flush() for GPIB.
    do {
        char buffer [256];
        size_t received = 0;
        int eomReason = 0;
+        debug("AsynDriverInterface::writeHandler(%s): reading old input\n",
+            clientName());
        status = pasynOctet->read(pvtOctet, pasynUser,
            buffer, sizeof(buffer), &received, &eomReason);
        if (received == 0) break;
@ -679,6 +686,12 @@ writeHandler()
            clientName(), (long)received, StreamBuffer(buffer, received).expand()());
 #endif
    } while (status == asynSuccess);
+    else
+    {
+        debug("AsynDriverInterface::writeHandler(%s): flushing old input\n",
+            clientName());
+         pasynOctet->flush(pvtOctet, pasynUser);
+    }
        
    // discard any early events
    receivedEvent = 0;
@ -713,6 +726,12 @@ writeHandler()
        clientName(), (long)outputSize,  (long)written,
        pasynUser->timeout, asynStatusStr[status]);

+    if (oldeoslen >= 0) // restore asyn terminator
+    {
+        pasynOctet->setOutputEos(pvtOctet, pasynUser,
+            oldeos, oldeoslen);
+    }
+    
    // Up to asyn 4.17 I can't see when the server has disconnected. Why?
    int connected;
    pasynManager->isConnected(pasynUser, &connected);
@ -726,11 +745,6 @@ writeHandler()
        return;
    }

-    if (oldeoslen >= 0) // restore asyn terminator
-    {
-        pasynOctet->setOutputEos(pvtOctet, pasynUser,
-            oldeos, oldeoslen);
-    }
    switch (status)
    {
        case asynSuccess:
@ -755,32 +769,34 @@ writeHandler()
            writeCallback(StreamIoSuccess);
            return;
        case asynTimeout:
+            error("%s: asynTimeout (%g sec) in write. Asyn says: %s\n",
+                clientName(), pasynUser->timeout, pasynUser->errorMessage);
            writeCallback(StreamIoTimeout);
            return;
        case asynOverflow:
-            error("%s: asynOverflow in write: %s\n",
+            error("%s: asynOverflow in write. Asyn driver says: %s\n",
                clientName(), pasynUser->errorMessage);
            writeCallback(StreamIoFault);
            return;
        case asynError:
-            error("%s: asynError in write: %s\n",
+            error("%s: asynError in write. Asyn driver says: %s\n",
                clientName(), pasynUser->errorMessage);
            writeCallback(StreamIoFault);
            return;
 #ifdef ASYN_VERSION // asyn >= 4.14
        case asynDisconnected:
-            error("%s: asynDisconnected in write: %s\n",
+            error("%s: asynDisconnected in write. Asyn driver says: %s\n",
                clientName(), pasynUser->errorMessage);
            writeCallback(StreamIoFault);
            return;
        case asynDisabled:
-            error("%s: asynDisconnected in write: %s\n",
+            error("%s: asynDisconnected in write. Asyn driver says: %s\n",
                clientName(), pasynUser->errorMessage);
            writeCallback(StreamIoFault);
            return;
 #endif
        default:
-            error("%s: unknown asyn error in write: %s\n",
+            error("%s: unknown asyn error in write. Asyn driver says: %s\n",
                clientName(), pasynUser->errorMessage);
            writeCallback(StreamIoFault);
            return;
@ -1078,29 +1094,29 @@ readHandler()
                }
                peeksize = inputBuffer.capacity();
                // deliver whatever we could save
-                error("%s: asynOverflow in read: %s\n",
+                error("%s: asynOverflow in read. Asyn driver says: %s\n",
                    clientName(), pasynUser->errorMessage);
                readCallback(StreamIoFault, buffer, received);
                break;
            case asynError:
-                error("%s: asynError in read: %s\n",
+                error("%s: asynError in read. Asyn driver says: %s\n",
                    clientName(), pasynUser->errorMessage);
                readCallback(StreamIoFault, buffer, received);
                break;
 #ifdef ASYN_VERSION // asyn >= 4.14
            case asynDisconnected:
-                error("%s: asynDisconnected in read: %s\n",
+                error("%s: asynDisconnected in read. Asyn driver says: %s\n",
                    clientName(), pasynUser->errorMessage);
                readCallback(StreamIoFault);
                return;
            case asynDisabled:
-                error("%s: asynDisconnected in read: %s\n",
+                error("%s: asynDisconnected in read. Asyn driver says: %s\n",
                    clientName(), pasynUser->errorMessage);
                readCallback(StreamIoFault);
                return;
 #endif
            default:
-                error("%s: unknown asyn error in read: %s\n",
+                error("%s: unknown asyn error in read. Asyn driver says: %s\n",
                    clientName(), pasynUser->errorMessage);
                readCallback(StreamIoFault);
                return;
--- a/src/StreamCore.cc
+++ b/src/StreamCore.cc
@ -59,7 +59,7 @@ static char* printCommands(StreamBuffer& buffer, const char* c)
                break;
            case wait_cmd:
                timeout = extract<unsigned long>(c);
-                buffer.print("    wait %ld;\n # ms", timeout);
+                buffer.print("    wait %ld; # ms\n", timeout);
                break;
            case event_cmd:
                eventnumber = extract<unsigned long>(c);
--- a/src/StreamEpics.cc
+++ b/src/StreamEpics.cc
@ -270,7 +270,7 @@ epicsExportRegistrar(streamRegistrar);
 struct stream_drvsup {
    long number;
    long (*report)(int);
-    DRVSUPFUN init;
+    long (*init)();
 } stream = {
    2,
    Stream::report,
--- a/src/TimestampConverter.cc
+++ b/src/TimestampConverter.cc
@ -26,6 +26,24 @@
 #include <stdlib.h>
 #include <errno.h>

+/* timezone in UNIX contains the seconds between UTC and local time,
+but not in Free-BSD! Here timezone() is a function delivering
+the time zone abbreviation (e.g. CET). Alternatively, the timezone
+value can also be gained from tm_gmtoff of the tm-structure. 
+                                                    HJK, 4.4.14 */
+/* The same seems to be true for other BSDs. DZ. */
+                                                    
+#if defined(__FreeBSD__) || \
+    defined(__NetBSD__) || \
+    defined(__OpenBSD__) || \
+    defined(__bsdi__ ) || \
+    defined(__DragonFly__)
+static int timezone_bsd=0;
+#define timezone timezone_bsd
+#define tzset() { struct tm tm; time_t timet; tzset(); time(&timet);	\
+                  localtime_r(&timet, &tm); timezone=tm.tm_gmtoff; }
+#endif
+
 #ifdef _WIN32
 #define tzset() _tzset()
 #define timezone _timezone
@ -46,6 +64,13 @@ int timezone = 0;
 } while (0)
 #endif

+#if defined(__MINGW32__)
+/* MinGW has no re-entrant localtime. How about other environments? */
+/* Just let's hope for the best */
+#undef localtime_r
+#define localtime_r(timet,tm) (*(tm)=*localtime(timet))
+#endif
+
 class TimestampConverter : public StreamFormatConverter
 {
    int parse(const StreamFormat&, StreamBuffer&, const char*&, bool);
@ -366,7 +391,7 @@ startover:
                        debug ("TimestampConverter::scantime: %s hour = %d\n", pm?"PM":"AM", tm->tm_hour);
                        break;
                    case 'M': /* minute */
-                        i = nummatch(input, 1, 59);
+                        i = nummatch(input, 0, 59);
                        if (i < 0)
                        {
                            error ("error parsing minute: '%.20s'\n", input);
@ -376,7 +401,7 @@ startover:
                        debug ("TimestampConverter::scantime: min = %d\n", tm->tm_min);
                        break;
                    case 'S': /* second */
-                        i = nummatch(input, 1, 60);
+                        i = nummatch(input, 0, 60);
                        if (i < 0)
                        {
                            error ("error parsing week second: '%.20s'\n", input);
--- a/src/devStream.h
+++ b/src/devStream.h
@ -23,7 +23,7 @@

 #define STREAM_MAJOR 2
 #define STREAM_MINOR 6
-#define STREAM_PATCHLEVEL 4
+#define STREAM_PATCHLEVEL 6

 #if defined(__vxworks) || defined(vxWorks)
 #include <vxWorks.h>
Author	SHA1	Message	Date
zimoch	3a5a3e22b9	Stupid error: Minutes and seconds start from 0, not 1.	2015-02-10 16:48:39 +00:00
zimoch	51bd766ba6	Fix or rather workaround for MinGW and maybe other systems without localtime_r function	2014-06-24 13:20:19 +00:00
zimoch	0ab0d6db07	function pointer type problem fixed	2014-06-24 13:19:36 +00:00
zimoch	a12de614d6	script to make a pdf from the hrml pages	2014-05-02 15:10:18 +00:00
zimoch	240abd2788	new logo and design cleanup, printing improved	2014-05-02 15:09:49 +00:00
zimoch	e131fcb32f	new logo, png instead of gif, better quality	2014-05-02 15:08:36 +00:00
zimoch	f88f594e87	shorter header, better for printing	2014-05-02 15:07:06 +00:00
zimoch	56ef0651f2	fix for BSD Linux	2014-04-07 11:55:36 +00:00
zimoch	9b9726b800	patchlevel fixed	2013-11-06 13:29:42 +00:00
zimoch	b139221f0b	error messages improved	2013-11-06 10:22:51 +00:00
zimoch	b0ab8a7a8b	write error message on write timeout	2013-11-06 09:52:39 +00:00
zimoch	ddac589676	newline in report output fixed	2013-11-06 09:44:18 +00:00