avoid buffer overflow

This commit is contained in:
zimoch
2015-04-08 09:35:00 +00:00
parent 7530c7c67d
commit b721d26fb8

View File

@ -965,13 +965,13 @@ getFieldAddress(const char* fieldname, StreamBuffer& address)
else
{
// FIELD in this record or VAL in other record
char fullname[PVNAME_SZ + 1];
sprintf(fullname, "%s.%s", name(), fieldname);
if (dbNameToAddr(fullname, &dbaddr) != OK)
StreamBuffer fullname;
fullname.print("%s.%s", name(), fieldname);
if (dbNameToAddr(fullname(), &dbaddr) != OK)
{
// VAL in other record
sprintf(fullname, "%s.VAL", fieldname);
if (dbNameToAddr(fullname, &dbaddr) != OK) return false;
fullname.clear().print("%s.VAL", fieldname);
if (dbNameToAddr(fullname(), &dbaddr) != OK) return false;
}
}
address.append(&dbaddr, sizeof(dbaddr));