AEK_8220_Libraries/firmware_vhdl_evr320
0
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix for issue #5 (wrong endianness of data stream in test bed) #6

Merged
straumann_t merged 1 commits from fix_issue_#5 into master 2021-02-24 11:47:13 +01:00
Conversation 3 Commits 1 Files Changed 1 +5 -9
straumann_t commented 2021-02-24 11:17:11 +01:00 (Migrated from git.psi.ch)
Copy Link

The 'evr320_data_filter' entity presents data in little-endian format.
However, the test is written for big-endian; set the SWAP generic to
fix this.

Also; once this test passes events won't be detected because the checksum
timeout is not reached. Set to zero.

Last: ghdl complains about mem_data(x) indexing when x > C_MEM_DATA_WIDTH.
Replaced hard-coded statements by a simple loop that runs from
0 to C_MEM_DATA_WIDTH/8 - 1.

The 'evr320_data_filter' entity presents data in little-endian format. However, the test is written for big-endian; set the SWAP generic to fix this. Also; once this test passes events won't be detected because the checksum timeout is not reached. Set to zero. Last: ghdl complains about mem_data(x) indexing when x > C_MEM_DATA_WIDTH. Replaced hard-coded statements by a simple loop that runs from 0 to C_MEM_DATA_WIDTH/8 - 1.
straumann_t commented 2021-02-24 11:18:11 +01:00 (Migrated from git.psi.ch)
Copy Link

mentioned in issue #5

mentioned in issue #5
stef_b commented 2021-02-24 11:47:13 +01:00 (Migrated from git.psi.ch)
Copy Link

merged

merged
stef_b commented 2021-02-24 11:47:13 +01:00 (Migrated from git.psi.ch)
Copy Link

mentioned in commit df8522473d

mentioned in commit df8522473d53f9a4bcd9318553754566fb555d7b
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug_tb
Improvement
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
stef_b
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: AEK_8220_Libraries/firmware_vhdl_evr320#6
No description provided.
Delete Branch "fix_issue_#5"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?