zebra/pyzebra
3
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

ccl integrate tables with angles #43

New Issue
Closed
opened 2021-11-08 13:10:59 +01:00 by usov_i · 2 comments
usov_i commented 2021-11-08 13:10:59 +01:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

Created by: zaharko

'Ccl integrate'
nb-geometry
Gamma is missing.
The systematic way would be to have different subtables for bi- and nb- geometries
For bi- 2theta, om, chi,phi
For nb - gamma, om, nu
ccl_integrate_nb_20211532

*Created by: zaharko* 'Ccl integrate' nb-geometry Gamma is missing. The systematic way would be to have different subtables for bi- and nb- geometries For bi- 2theta, om, chi,phi For nb - gamma, om, nu <img width="1630" alt="ccl_integrate_nb_20211532" src="https://user-images.githubusercontent.com/50512596/140739704-b4ddb41a-1a1e-4004-9147-f94d17cb54d3.png">
usov_i commented 2021-11-08 16:29:07 +01:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

Created by: ivan-usov

Based on 1.1 in https://github.com/paulscherrerinstitute/pyzebra/issues/41 it was 2theta for both, bi- and nb-geometries.
But I can add a new column gamma to fix the current issue.

Ok, splitting all scans into 2 tables based on their geometries sounds like an option. The only tradeoff I see is that if all scans are of the same geometry, the second table will just occupy space. Though, maybe it's also helpful to know there are only one geometry scans. Which option would you prefer?

*Created by: ivan-usov* Based on 1.1 in https://github.com/paulscherrerinstitute/pyzebra/issues/41 it was `2theta` for both, bi- and nb-geometries. But I can add a new column `gamma` to fix the current issue. Ok, splitting all scans into 2 tables based on their geometries sounds like an option. The only tradeoff I see is that if all scans are of the same geometry, the second table will just occupy space. Though, maybe it's also helpful to know there are only one geometry scans. Which option would you prefer?
usov_i commented 2021-11-12 10:24:48 +01:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

Created by: ivan-usov

Splitting the table might be more difficult than expected. Maybe I'll return to it later if you still think it significantly improves UX.

*Created by: ivan-usov* Splitting the table might be more difficult than expected. Maybe I'll return to it later if you still think it significantly improves UX.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
sibille_r (sibille_r) usov_i (usov_i) zaharko (zaharko)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zebra/pyzebra#43